summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Yohei Yukawa <yukawa@google.com> 2017-06-22 22:30:45 -0700
committer Yohei Yukawa <yukawa@google.com> 2017-06-22 22:30:45 -0700
commitf14fe14a3bd09ac60d70e33248eae88c4da08a66 (patch)
tree739c0021b96cd10b6a388765f886a86d7c92b70c
parent3e32b84ed7ba30a5d85c37de6996e7885b8c5310 (diff)
Remove a redundant synchronized block
This CL removes a redundant synchronized block, which was accidentally added in the previous CL [1] that simplified TextServicesManagerService (TSMS) by using RemoteCallbackList<E>. Since SpellCheckerBindGroup#removeListener() internally acquires the lock on TSMS#mSpellCheckerMap, there is no need to acquire the same lock in the caller. This CL is just a mechanical clean-up. No behavior change is intended. [1]: I38942765ed6bec6713757b1d5f325e7a633c2ba7 f982e75a262db16e60fd3565638d399315dba761 Bug: 35102403 Test: compile Change-Id: I6d47e8cb6e301286bcb26922b74ee7cac2c5c1c5
-rw-r--r--services/core/java/com/android/server/TextServicesManagerService.java7
1 files changed, 2 insertions, 5 deletions
diff --git a/services/core/java/com/android/server/TextServicesManagerService.java b/services/core/java/com/android/server/TextServicesManagerService.java
index 21aeee292ed5..098b43c897e7 100644
--- a/services/core/java/com/android/server/TextServicesManagerService.java
+++ b/services/core/java/com/android/server/TextServicesManagerService.java
@@ -1024,7 +1024,7 @@ public class TextServicesManagerService extends ITextServicesManager.Stub {
}
}
- private final class InternalDeathRecipients extends
+ private static final class InternalDeathRecipients extends
RemoteCallbackList<ISpellCheckerSessionListener> {
private final SpellCheckerBindGroup mGroup;
@@ -1034,11 +1034,8 @@ public class TextServicesManagerService extends ITextServicesManager.Stub {
@Override
public void onCallbackDied(ISpellCheckerSessionListener listener) {
- synchronized(mSpellCheckerMap) {
- mGroup.removeListener(listener);
- }
+ mGroup.removeListener(listener);
}
-
}
private static final class ISpellCheckerServiceCallbackBinder