summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Joe Castro <joecastro@google.com> 2023-01-12 01:06:17 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2023-01-12 01:06:17 +0000
commitf0f951f7a85fec367d2b88014e9a766c6ce98958 (patch)
tree02b0eecc5cd7ad0a83fa720bea76de078ecb7dc7
parent6d0057ce3c1c1b1c8ed54e21cec4ab59852efa7c (diff)
parent02b90551b98575cc1609e38f4571e874e7e904bf (diff)
Merge "Don't remove permission when cleaning up orphaned tree on uninstall" into tm-qpr-dev
-rw-r--r--services/core/java/com/android/server/pm/permission/PermissionManagerServiceImpl.java21
1 files changed, 0 insertions, 21 deletions
diff --git a/services/core/java/com/android/server/pm/permission/PermissionManagerServiceImpl.java b/services/core/java/com/android/server/pm/permission/PermissionManagerServiceImpl.java
index 554e2690b878..20c9a211e586 100644
--- a/services/core/java/com/android/server/pm/permission/PermissionManagerServiceImpl.java
+++ b/services/core/java/com/android/server/pm/permission/PermissionManagerServiceImpl.java
@@ -4215,7 +4215,6 @@ public class PermissionManagerServiceImpl implements PermissionManagerServiceInt
}
boolean changed = false;
- Set<Permission> needsUpdate = null;
synchronized (mLock) {
final Iterator<Permission> it = mRegistry.getPermissionTrees().iterator();
while (it.hasNext()) {
@@ -4234,26 +4233,6 @@ public class PermissionManagerServiceImpl implements PermissionManagerServiceInt
+ " that used to be declared by " + bp.getPackageName());
it.remove();
}
- if (needsUpdate == null) {
- needsUpdate = new ArraySet<>();
- }
- needsUpdate.add(bp);
- }
- }
- if (needsUpdate != null) {
- for (final Permission bp : needsUpdate) {
- final AndroidPackage sourcePkg =
- mPackageManagerInt.getPackage(bp.getPackageName());
- final PackageStateInternal sourcePs =
- mPackageManagerInt.getPackageStateInternal(bp.getPackageName());
- synchronized (mLock) {
- if (sourcePkg != null && sourcePs != null) {
- continue;
- }
- Slog.w(TAG, "Removing dangling permission tree: " + bp.getName()
- + " from package " + bp.getPackageName());
- mRegistry.removePermission(bp.getName());
- }
}
}
return changed;