diff options
author | 2024-11-27 10:02:28 -0800 | |
---|---|---|
committer | 2024-11-27 10:07:15 -0800 | |
commit | f0d51dde83d466c1a42512a895481f6487517a9d (patch) | |
tree | 5e067e34513c61bb04a314d0eb59404be018fd10 | |
parent | e11147f7ff3ab692421a16f0d90e34274ee4f362 (diff) |
Change ravenwood default log level to verbose
- Otherwise, it'll be hard to debug issues from the log from the CI server.
- Also change all ravenwood related log to a "Ravenwood" tag, to make it easy
to filter out ravenwood log.
Bug: 380949304
Test: $ANDROID_BUILD_TOP/frameworks/base/ravenwood/scripts/run-ravenwood-tests.sh -s
Test: ANDROID_LOG_TAGS='Ravenwood:s' atest -t RavenwoodBivalentTest
Flag: EXEMPT host test change only
Change-Id: Ia114d094256b365beea55c905766a4602852c742
13 files changed, 12 insertions, 20 deletions
diff --git a/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodAwareTestRunner.java b/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodAwareTestRunner.java index de3c5f2c23ab..9644a52a749e 100644 --- a/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodAwareTestRunner.java +++ b/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodAwareTestRunner.java @@ -63,8 +63,6 @@ import java.util.function.BiConsumer; * - Handle {@link android.platform.test.annotations.DisabledOnRavenwood}. */ public final class RavenwoodAwareTestRunner extends RavenwoodAwareTestRunnerBase { - public static final String TAG = "Ravenwood"; - /** Scope of a hook. */ public enum Scope { Class, diff --git a/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodContext.java b/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodContext.java index 239c8061b757..9eff20ad70e6 100644 --- a/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodContext.java +++ b/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodContext.java @@ -45,7 +45,7 @@ import java.util.concurrent.Executor; import java.util.function.Supplier; public class RavenwoodContext extends RavenwoodBaseContext { - private static final String TAG = "Ravenwood"; + private static final String TAG = com.android.ravenwood.common.RavenwoodCommonUtils.TAG; private final Object mLock = new Object(); private final String mPackageName; diff --git a/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodEnablementChecker.java b/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodEnablementChecker.java index 77275c445dd9..3cb2c67adf09 100644 --- a/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodEnablementChecker.java +++ b/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodEnablementChecker.java @@ -27,8 +27,6 @@ import org.junit.runner.Description; * Calculates which tests need to be executed on Ravenwood. */ public class RavenwoodEnablementChecker { - private static final String TAG = "RavenwoodDisablementChecker"; - private RavenwoodEnablementChecker() { } diff --git a/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodRunnerState.java b/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodRunnerState.java index 6dfcf4ce03cf..a5d0bfd51a0f 100644 --- a/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodRunnerState.java +++ b/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodRunnerState.java @@ -40,7 +40,7 @@ import java.util.Set; * All members must be called from the runner's main thread. */ public final class RavenwoodRunnerState { - private static final String TAG = "RavenwoodRunnerState"; + private static final String TAG = com.android.ravenwood.common.RavenwoodCommonUtils.TAG; private static final String RAVENWOOD_RULE_ERROR = "RavenwoodRule(s) are not executed in the correct order"; diff --git a/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodRuntimeEnvironmentController.java b/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodRuntimeEnvironmentController.java index 3d2bb8e78a7e..930914f586eb 100644 --- a/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodRuntimeEnvironmentController.java +++ b/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodRuntimeEnvironmentController.java @@ -96,7 +96,7 @@ import java.util.function.Supplier; * Responsible for initializing and the environment. */ public class RavenwoodRuntimeEnvironmentController { - private static final String TAG = "RavenwoodRuntimeEnvironmentController"; + private static final String TAG = com.android.ravenwood.common.RavenwoodCommonUtils.TAG; private RavenwoodRuntimeEnvironmentController() { } diff --git a/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodSystemProperties.java b/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodSystemProperties.java index 99b38ed4c92c..fac07910be11 100644 --- a/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodSystemProperties.java +++ b/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodSystemProperties.java @@ -34,7 +34,7 @@ import java.util.Set; * A class to manage the core default system properties of the Ravenwood environment. */ public class RavenwoodSystemProperties { - private static final String TAG = "RavenwoodSystemProperties"; + private static final String TAG = com.android.ravenwood.common.RavenwoodCommonUtils.TAG; /** We pull in properties from this file. */ private static final String RAVENWOOD_BUILD_PROP = "ravenwood-data/ravenwood-build.prop"; diff --git a/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodTestStats.java b/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodTestStats.java index 787058545fed..c8b10d20843f 100644 --- a/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodTestStats.java +++ b/ravenwood/junit-impl-src/android/platform/test/ravenwood/RavenwoodTestStats.java @@ -41,7 +41,7 @@ import java.util.Map; * `/tmp/Ravenwood-stats_[TEST-MODULE=NAME]_latest.csv`. */ public class RavenwoodTestStats { - private static final String TAG = "RavenwoodTestStats"; + private static final String TAG = com.android.ravenwood.common.RavenwoodCommonUtils.TAG; private static final String HEADER = "Module,Class,OuterClass,Passed,Failed,Skipped"; private static RavenwoodTestStats sInstance; diff --git a/ravenwood/junit-src/android/platform/test/ravenwood/RavenwoodAwareTestRunnerBase.java b/ravenwood/junit-src/android/platform/test/ravenwood/RavenwoodAwareTestRunnerBase.java index 31a14164bd51..f3688d664142 100644 --- a/ravenwood/junit-src/android/platform/test/ravenwood/RavenwoodAwareTestRunnerBase.java +++ b/ravenwood/junit-src/android/platform/test/ravenwood/RavenwoodAwareTestRunnerBase.java @@ -35,7 +35,7 @@ import org.junit.runners.model.RunnerBuilder; import org.junit.runners.model.TestClass; abstract class RavenwoodAwareTestRunnerBase extends Runner implements Filterable, Orderable { - private static final String TAG = "Ravenwood"; + public static final String TAG = com.android.ravenwood.common.RavenwoodCommonUtils.TAG; boolean mRealRunnerTakesRunnerBuilder = false; diff --git a/ravenwood/junit-src/android/platform/test/ravenwood/RavenwoodRule.java b/ravenwood/junit-src/android/platform/test/ravenwood/RavenwoodRule.java index d4b15c66c68b..d8cde0e029c9 100644 --- a/ravenwood/junit-src/android/platform/test/ravenwood/RavenwoodRule.java +++ b/ravenwood/junit-src/android/platform/test/ravenwood/RavenwoodRule.java @@ -41,7 +41,7 @@ import java.util.regex.Pattern; */ @Deprecated public final class RavenwoodRule implements TestRule { - private static final String TAG = "RavenwoodRule"; + private static final String TAG = com.android.ravenwood.common.RavenwoodCommonUtils.TAG; static final boolean IS_ON_RAVENWOOD = RavenwoodCommonUtils.isOnRavenwood(); diff --git a/ravenwood/junit-stub-src/android/platform/test/ravenwood/RavenwoodAwareTestRunner.java b/ravenwood/junit-stub-src/android/platform/test/ravenwood/RavenwoodAwareTestRunner.java index b4b751788c6e..8d9bcd5b242f 100644 --- a/ravenwood/junit-stub-src/android/platform/test/ravenwood/RavenwoodAwareTestRunner.java +++ b/ravenwood/junit-stub-src/android/platform/test/ravenwood/RavenwoodAwareTestRunner.java @@ -31,8 +31,6 @@ import org.junit.runners.model.TestClass; * This is only used when a real device-side test has Ravenizer enabled. */ public class RavenwoodAwareTestRunner extends RavenwoodAwareTestRunnerBase { - private static final String TAG = "Ravenwood"; - private static class NopRule implements TestRule { @Override public Statement apply(Statement base, Description description) { diff --git a/ravenwood/runtime-common-src/com/android/ravenwood/common/RavenwoodCommonUtils.java b/ravenwood/runtime-common-src/com/android/ravenwood/common/RavenwoodCommonUtils.java index 2a04d4469ef4..a967a3fff0d7 100644 --- a/ravenwood/runtime-common-src/com/android/ravenwood/common/RavenwoodCommonUtils.java +++ b/ravenwood/runtime-common-src/com/android/ravenwood/common/RavenwoodCommonUtils.java @@ -33,7 +33,7 @@ import java.util.Arrays; import java.util.function.Supplier; public class RavenwoodCommonUtils { - private static final String TAG = "RavenwoodCommonUtils"; + public static final String TAG = "Ravenwood"; private RavenwoodCommonUtils() { } diff --git a/ravenwood/runtime-helper-src/framework/android/util/Log_ravenwood.java b/ravenwood/runtime-helper-src/framework/android/util/Log_ravenwood.java index 96fa21221694..7ab9cda378b7 100644 --- a/ravenwood/runtime-helper-src/framework/android/util/Log_ravenwood.java +++ b/ravenwood/runtime-helper-src/framework/android/util/Log_ravenwood.java @@ -62,8 +62,7 @@ public class Log_ravenwood { sTagLogLevels.putAll(map); var def = map.get("*"); - sDefaultLogLevel = def != null ? def - : RavenwoodCommonUtils.RAVENWOOD_VERBOSE_LOGGING ? Log.VERBOSE : Log.INFO; + sDefaultLogLevel = def != null ? def : Log.VERBOSE; } } @@ -80,7 +79,7 @@ public class Log_ravenwood { if (parts.length == 2) { String tag = parts[0]; try { - int priority = switch (parts[1]) { + int priority = switch (parts[1].toUpperCase(Locale.ROOT)) { case "V": yield Log.VERBOSE; case "D": yield Log.DEBUG; case "I": yield Log.INFO; diff --git a/ravenwood/tests/coretest/test/com/android/ravenwoodtest/coretest/RavenwoodLogLevelTest.java b/ravenwood/tests/coretest/test/com/android/ravenwoodtest/coretest/RavenwoodLogLevelTest.java index 7be562c86434..74c1f3f686aa 100644 --- a/ravenwood/tests/coretest/test/com/android/ravenwoodtest/coretest/RavenwoodLogLevelTest.java +++ b/ravenwood/tests/coretest/test/com/android/ravenwoodtest/coretest/RavenwoodLogLevelTest.java @@ -41,9 +41,8 @@ public class RavenwoodLogLevelTest { assertEquals(true, Log.isLoggable("TAG1", Log.INFO)); assertEquals(true, Log.isLoggable("TAG2", Log.INFO)); - var verboseEnabled = RavenwoodCommonUtils.RAVENWOOD_VERBOSE_LOGGING; - assertEquals(verboseEnabled, Log.isLoggable("TAG1", Log.DEBUG)); - assertEquals(verboseEnabled, Log.isLoggable("TAG2", Log.VERBOSE)); + assertEquals(true, Log.isLoggable("TAG1", Log.DEBUG)); + assertEquals(true, Log.isLoggable("TAG2", Log.VERBOSE)); } @Test |