diff options
| author | 2025-01-10 01:04:40 -0800 | |
|---|---|---|
| committer | 2025-01-10 03:16:53 -0800 | |
| commit | ed12eeed0048e52bb13f5dfbd288cff7b086af6e (patch) | |
| tree | 59edc201e447ccf44b0132a1fe11d785fe7e667e | |
| parent | b746bf0dcdcfb5fbe2d48ede3f0ed7826dfae09e (diff) | |
Add type annotation to the phase parameter.
This commit adds the `@LaunchParamsModifier.Phase` annotation to the
phase parameters. This prevents accidental passing of invalid phase
values and improves readability.
BUG: 387193964
Flag: EXEMPT refactor
Test: Local build
Change-Id: Ie6b3c3f4b75a813014e648e7c3daafc0241b113e
| -rw-r--r-- | services/core/java/com/android/server/wm/LaunchParamsController.java | 3 | ||||
| -rw-r--r-- | services/core/java/com/android/server/wm/TaskLaunchParamsModifier.java | 6 |
2 files changed, 6 insertions, 3 deletions
diff --git a/services/core/java/com/android/server/wm/LaunchParamsController.java b/services/core/java/com/android/server/wm/LaunchParamsController.java index d3c3d2834124..ba1401ab3978 100644 --- a/services/core/java/com/android/server/wm/LaunchParamsController.java +++ b/services/core/java/com/android/server/wm/LaunchParamsController.java @@ -79,7 +79,8 @@ class LaunchParamsController { * @param result The resulting params. */ void calculate(Task task, WindowLayout layout, ActivityRecord activity, ActivityRecord source, - ActivityOptions options, @Nullable Request request, int phase, LaunchParams result) { + ActivityOptions options, @Nullable Request request, + @LaunchParamsModifier.Phase int phase, LaunchParams result) { result.reset(); if (task != null || activity != null) { diff --git a/services/core/java/com/android/server/wm/TaskLaunchParamsModifier.java b/services/core/java/com/android/server/wm/TaskLaunchParamsModifier.java index c39671d76929..e3a5b66b83fd 100644 --- a/services/core/java/com/android/server/wm/TaskLaunchParamsModifier.java +++ b/services/core/java/com/android/server/wm/TaskLaunchParamsModifier.java @@ -96,9 +96,10 @@ class TaskLaunchParamsModifier implements LaunchParamsModifier { } @Override + @Result public int onCalculate(@Nullable Task task, @Nullable ActivityInfo.WindowLayout layout, @Nullable ActivityRecord activity, @Nullable ActivityRecord source, - @Nullable ActivityOptions options, @Nullable Request request, int phase, + @Nullable ActivityOptions options, @Nullable Request request, @Phase int phase, LaunchParams currentParams, LaunchParams outParams) { initLogBuilder(task, activity); final int result = calculate(task, layout, activity, source, options, request, phase, @@ -107,9 +108,10 @@ class TaskLaunchParamsModifier implements LaunchParamsModifier { return result; } + @Result private int calculate(@Nullable Task task, @Nullable ActivityInfo.WindowLayout layout, @Nullable ActivityRecord activity, @Nullable ActivityRecord source, - @Nullable ActivityOptions options, @Nullable Request request, int phase, + @Nullable ActivityOptions options, @Nullable Request request, @Phase int phase, LaunchParams currentParams, LaunchParams outParams) { final ActivityRecord root; if (task != null) { |