summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Chen Xu <fionaxu@google.com> 2022-01-12 00:04:55 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2022-01-12 00:04:55 +0000
commite503303146bb0f724558512977c0b29e32f9e0f3 (patch)
tree8aaf619c3ae45baac17b9ad5bc44e1b61b4a5393
parent5c233dfcaa67d8ac57064cb0a8a6b7a1d2d2a8d3 (diff)
parentc5e8f49ea9cb47e2f2e5dc4cf0983d94cfbff79e (diff)
Merge "[MEP] Reverting temporarily bypassed exception"
-rw-r--r--telephony/java/android/telephony/UiccCardInfo.java8
-rw-r--r--telephony/java/android/telephony/UiccSlotInfo.java16
2 files changed, 9 insertions, 15 deletions
diff --git a/telephony/java/android/telephony/UiccCardInfo.java b/telephony/java/android/telephony/UiccCardInfo.java
index 74f9c876cc40..464389b84945 100644
--- a/telephony/java/android/telephony/UiccCardInfo.java
+++ b/telephony/java/android/telephony/UiccCardInfo.java
@@ -156,11 +156,9 @@ public final class UiccCardInfo implements Parcelable {
@Nullable
@Deprecated
public String getIccId() {
- // Temporarily bypassing exception
- // TODO: add exception once refactoring completed.
- //if (mIccIdAccessRestricted) {
- // throw new UnsupportedOperationException("getIccId from UiccPortInfo");
- //}
+ if (mIccIdAccessRestricted) {
+ throw new UnsupportedOperationException("getIccId from UiccPortInfo");
+ }
//always return ICCID from first port.
return getPorts().stream().findFirst().get().getIccId();
}
diff --git a/telephony/java/android/telephony/UiccSlotInfo.java b/telephony/java/android/telephony/UiccSlotInfo.java
index a8668e7d77d4..2b1c8c863eb6 100644
--- a/telephony/java/android/telephony/UiccSlotInfo.java
+++ b/telephony/java/android/telephony/UiccSlotInfo.java
@@ -159,11 +159,9 @@ public class UiccSlotInfo implements Parcelable {
*/
@Deprecated
public boolean getIsActive() {
- // Temporarily bypassing exception
- // TODO: add exception once refactoring completed.
- //if (mLogicalSlotAccessRestricted) {
- // throw new UnsupportedOperationException("get port status from UiccPortInfo");
- //}
+ if (mLogicalSlotAccessRestricted) {
+ throw new UnsupportedOperationException("get port status from UiccPortInfo");
+ }
//always return status from first port.
return getPorts().stream().findFirst().get().isActive();
}
@@ -198,11 +196,9 @@ public class UiccSlotInfo implements Parcelable {
*/
@Deprecated
public int getLogicalSlotIdx() {
- // Temporarily bypassing exception
- // TODO: add exception once refactoring completed.
- //if (mLogicalSlotAccessRestricted) {
- // throw new UnsupportedOperationException("get logical slot index from UiccPortInfo");
- //}
+ if (mLogicalSlotAccessRestricted) {
+ throw new UnsupportedOperationException("get logical slot index from UiccPortInfo");
+ }
//always return logical slot index from first port.
//portList always have at least one element.
return getPorts().stream().findFirst().get().getLogicalSlotIndex();