summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Hyoungho Choi <hh46.choi@samsung.com> 2023-03-02 22:05:30 +0900
committer Ray Essick <essick@google.com> 2023-03-13 17:00:45 -0500
commite106aa909b2aafb12644a695cf4e1d36a8e1f60e (patch)
tree379b12fb751507c1f865208a8cc6aac4cdb10f86
parent627b64593d21973e09dd64a46fd7ecc902390e83 (diff)
Use a ExifInterface ctor with a file descriptor as a parameter
To avoid a binder circular dependency, ExifInterface is changed to use a file descriptor for getting HEIF attributes (when available). Bug: 199822700 Test: manual Change-Id: I1b0762fd91f89bfb739b47467a685149309dd157
-rw-r--r--media/java/android/media/ThumbnailUtils.java25
1 files changed, 14 insertions, 11 deletions
diff --git a/media/java/android/media/ThumbnailUtils.java b/media/java/android/media/ThumbnailUtils.java
index e6d95eb6d5a1..cf3ba872feb5 100644
--- a/media/java/android/media/ThumbnailUtils.java
+++ b/media/java/android/media/ThumbnailUtils.java
@@ -49,6 +49,7 @@ import com.android.internal.util.ArrayUtils;
import libcore.io.IoUtils;
import java.io.File;
+import java.io.FileInputStream;
import java.io.IOException;
import java.util.Arrays;
import java.util.Comparator;
@@ -255,17 +256,19 @@ public class ThumbnailUtils {
// get orientation
if (MediaFile.isExifMimeType(mimeType)) {
- exif = new ExifInterface(file);
- switch (exif.getAttributeInt(ExifInterface.TAG_ORIENTATION, 0)) {
- case ExifInterface.ORIENTATION_ROTATE_90:
- orientation = 90;
- break;
- case ExifInterface.ORIENTATION_ROTATE_180:
- orientation = 180;
- break;
- case ExifInterface.ORIENTATION_ROTATE_270:
- orientation = 270;
- break;
+ try (FileInputStream is = new FileInputStream(file)) {
+ exif = new ExifInterface(is.getFD());
+ switch (exif.getAttributeInt(ExifInterface.TAG_ORIENTATION, 0)) {
+ case ExifInterface.ORIENTATION_ROTATE_90:
+ orientation = 90;
+ break;
+ case ExifInterface.ORIENTATION_ROTATE_180:
+ orientation = 180;
+ break;
+ case ExifInterface.ORIENTATION_ROTATE_270:
+ orientation = 270;
+ break;
+ }
}
}