summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author TreeHugger Robot <treehugger-gerrit@google.com> 2020-11-05 20:12:26 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2020-11-05 20:12:26 +0000
commite0d7430c0ebf19008b53403b67e44dfd039eaebd (patch)
treee83980449ec8e0ffd4bbaaeb011cfe7d050c1659
parent8aeade4629840e5741761d3d834030aa9a411de8 (diff)
parent9ec3bf497e9683974db28f25477b4cc6e9f80d92 (diff)
Merge "RESTRICT AUTOMERGE Fix CDM package check" into qt-dev
-rw-r--r--services/companion/java/com/android/server/companion/CompanionDeviceManagerService.java6
1 files changed, 5 insertions, 1 deletions
diff --git a/services/companion/java/com/android/server/companion/CompanionDeviceManagerService.java b/services/companion/java/com/android/server/companion/CompanionDeviceManagerService.java
index 067becbf0c52..d7d457395798 100644
--- a/services/companion/java/com/android/server/companion/CompanionDeviceManagerService.java
+++ b/services/companion/java/com/android/server/companion/CompanionDeviceManagerService.java
@@ -25,6 +25,7 @@ import static com.android.internal.util.function.pooled.PooledLambda.obtainRunna
import android.annotation.CheckResult;
import android.annotation.Nullable;
+import android.app.AppOpsManager;
import android.app.PendingIntent;
import android.companion.AssociationRequest;
import android.companion.CompanionDeviceManager;
@@ -297,7 +298,10 @@ public class CompanionDeviceManagerService extends SystemService implements Bind
checkArgument(getCallingUserId() == userId,
"Must be called by either same user or system");
- mAppOpsManager.checkPackage(Binder.getCallingUid(), pkg);
+ int callingUid = Binder.getCallingUid();
+ if (mAppOpsManager.checkPackage(callingUid, pkg) != AppOpsManager.MODE_ALLOWED) {
+ throw new SecurityException(pkg + " doesn't belong to uid " + callingUid);
+ }
}
@Override