summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Jordan Demeulenaere <jdemeulenaere@google.com> 2025-02-03 11:43:53 +0100
committer Jordan Demeulenaere <jdemeulenaere@google.com> 2025-02-03 11:43:54 +0100
commitdebf1d0321025e7382efda6c397cf73a4e534ee3 (patch)
treeb6f99ea9d7377cd397400e0a578fdea883748fa4
parentdaca911006e814efdb55463ad3bd416c58b2791e (diff)
Remove Modifier.measureTracer {}
This CL removes Modifier.measureTracer {} given that it was unused and most importantly misleading. From adamp@: "The layout at the end returns an object that contains the placement code as a callback. Many layouts measure their children as part of placement, not container measurement, because the child's measured size cannot affect the measurement of the parent. This aids compose in skipping unnecessary layout up the hierarchy.There are many ways that a child of this modifier can be remeasured completely outside of this trace recording." Bug: 291071158 Test: N/A Flag: EXEMPT deleted unused code Change-Id: I9cc6a728e3aa90615dfd1fd7e0a700e52f3319a9
-rw-r--r--packages/SystemUI/compose/core/src/com/android/compose/modifiers/MeasureTracing.kt32
1 files changed, 0 insertions, 32 deletions
diff --git a/packages/SystemUI/compose/core/src/com/android/compose/modifiers/MeasureTracing.kt b/packages/SystemUI/compose/core/src/com/android/compose/modifiers/MeasureTracing.kt
deleted file mode 100644
index 9ce6cd11a2b0..000000000000
--- a/packages/SystemUI/compose/core/src/com/android/compose/modifiers/MeasureTracing.kt
+++ /dev/null
@@ -1,32 +0,0 @@
-/*
- * Copyright (C) 2024 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package com.android.compose.modifiers
-
-import androidx.compose.ui.Modifier
-import androidx.compose.ui.layout.layout
-import androidx.compose.ui.unit.IntOffset
-import com.android.app.tracing.traceSection
-
-/** Adds perfetto markers for the measure + layout stages. */
-inline fun Modifier.measureTracer(crossinline traceNameProducer: () -> String): Modifier {
- return layout { measurable, constraints ->
- traceSection(traceNameProducer) {
- val placeable = measurable.measure(constraints)
- layout(placeable.width, placeable.height) { placeable.placeRelative(IntOffset.Zero) }
- }
- }
-}