summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Adrian Roos <roosa@google.com> 2019-02-27 23:58:13 +0100
committer Adrian Roos <roosa@google.com> 2019-02-28 09:54:08 +0000
commitdeb0ff2bf4b7a3ffc7440fffc22772dbeca991ea (patch)
treed599c34b6b7a75cd0791d0bfde1d31726513f633
parenteee18bd546665b726d73769ee3ed5a2368c8c1f1 (diff)
Apilint: Enforce final builders
Test: run apilint Bug: 124883027 Change-Id: I7f2866e46bc40be60487846b2af9f8fd7edb7623
-rw-r--r--tools/apilint/apilint.py3
1 files changed, 3 insertions, 0 deletions
diff --git a/tools/apilint/apilint.py b/tools/apilint/apilint.py
index 4c02d94542d0..ef405e4b1343 100644
--- a/tools/apilint/apilint.py
+++ b/tools/apilint/apilint.py
@@ -1109,6 +1109,9 @@ def verify_builder(clazz):
if not has_build:
warn(clazz, None, None, "Missing build() method")
+ if "final" not in clazz.split:
+ error(clazz, None, None, "Builder should be final")
+
def verify_aidl(clazz):
"""Catch people exposing raw AIDL."""