summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author James Dong <jdong@google.com> 2011-10-18 22:29:20 -0700
committer James Dong <jdong@google.com> 2011-10-18 22:29:20 -0700
commitdc8bbe79b83c7f4a4cc7e557639079385097cc00 (patch)
tree3b45371ba1e005ffb092a4f88bfa7a9aab81fbbf
parent5264f6003bbcb8ca70df034379154914260cc322 (diff)
Check whether media recorder client exists before dumping.
Change-Id: I1f3a644a958975e4cf6c02099c53e30cc4d2fd82 related-to-bug: 5477177
-rw-r--r--media/libmediaplayerservice/MediaPlayerService.cpp12
1 files changed, 7 insertions, 5 deletions
diff --git a/media/libmediaplayerservice/MediaPlayerService.cpp b/media/libmediaplayerservice/MediaPlayerService.cpp
index b5eef94a4c00..3ebe98952ca5 100644
--- a/media/libmediaplayerservice/MediaPlayerService.cpp
+++ b/media/libmediaplayerservice/MediaPlayerService.cpp
@@ -374,11 +374,13 @@ status_t MediaPlayerService::dump(int fd, const Vector<String16>& args)
} else {
for (int i = 0, n = mMediaRecorderClients.size(); i < n; ++i) {
sp<MediaRecorderClient> c = mMediaRecorderClients[i].promote();
- snprintf(buffer, 255, " MediaRecorderClient pid(%d)\n", c->mPid);
- result.append(buffer);
- write(fd, result.string(), result.size());
- result = "\n";
- c->dump(fd, args);
+ if (c != 0) {
+ snprintf(buffer, 255, " MediaRecorderClient pid(%d)\n", c->mPid);
+ result.append(buffer);
+ write(fd, result.string(), result.size());
+ result = "\n";
+ c->dump(fd, args);
+ }
}
}