summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author TreeHugger Robot <treehugger-gerrit@google.com> 2017-03-30 19:17:18 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2017-03-30 19:17:24 +0000
commitdada7c0e7130763f95e18aa3118b3d91f7ab1bbf (patch)
tree2fb00f5dea2a1a107f87fe1daca66ec0d58610e6
parent760092526340ba230fdeb59bc2765239c63db57d (diff)
parentdf61b0328e21dd03ce6e0ef735e0fb32054659c9 (diff)
Merge "TextClassificationManager API updates." into oc-dev
-rw-r--r--api/current.txt3
-rw-r--r--api/removed.txt8
-rw-r--r--api/system-current.txt3
-rw-r--r--api/system-removed.txt8
-rw-r--r--api/test-current.txt3
-rw-r--r--api/test-removed.txt8
-rw-r--r--core/java/android/view/textclassifier/TextClassificationManager.java30
-rw-r--r--core/java/android/widget/TextView.java2
8 files changed, 55 insertions, 10 deletions
diff --git a/api/current.txt b/api/current.txt
index 92b6fd2790f6..e611b34a3177 100644
--- a/api/current.txt
+++ b/api/current.txt
@@ -48110,7 +48110,8 @@ package android.view.textclassifier {
public final class TextClassificationManager {
method public java.util.List<android.view.textclassifier.TextLanguage> detectLanguages(java.lang.CharSequence);
- method public android.view.textclassifier.TextClassifier getDefaultTextClassifier();
+ method public android.view.textclassifier.TextClassifier getTextClassifier();
+ method public void setTextClassifier(android.view.textclassifier.TextClassifier);
}
public final class TextClassificationResult {
diff --git a/api/removed.txt b/api/removed.txt
index 75da976d1b64..af429b85eb9b 100644
--- a/api/removed.txt
+++ b/api/removed.txt
@@ -380,6 +380,14 @@ package android.view {
}
+package android.view.textclassifier {
+
+ public final class TextClassificationManager {
+ method public android.view.textclassifier.TextClassifier getDefaultTextClassifier();
+ }
+
+}
+
package android.webkit {
public class WebViewClient {
diff --git a/api/system-current.txt b/api/system-current.txt
index 8829025502bc..060586d1ed6a 100644
--- a/api/system-current.txt
+++ b/api/system-current.txt
@@ -51569,7 +51569,8 @@ package android.view.textclassifier {
public final class TextClassificationManager {
method public java.util.List<android.view.textclassifier.TextLanguage> detectLanguages(java.lang.CharSequence);
- method public android.view.textclassifier.TextClassifier getDefaultTextClassifier();
+ method public android.view.textclassifier.TextClassifier getTextClassifier();
+ method public void setTextClassifier(android.view.textclassifier.TextClassifier);
}
public final class TextClassificationResult {
diff --git a/api/system-removed.txt b/api/system-removed.txt
index 3aa93982fc94..272ae772b2ee 100644
--- a/api/system-removed.txt
+++ b/api/system-removed.txt
@@ -374,6 +374,14 @@ package android.view {
}
+package android.view.textclassifier {
+
+ public final class TextClassificationManager {
+ method public android.view.textclassifier.TextClassifier getDefaultTextClassifier();
+ }
+
+}
+
package android.webkit {
public class WebViewClient {
diff --git a/api/test-current.txt b/api/test-current.txt
index 00ada6191738..b4942a69dc3e 100644
--- a/api/test-current.txt
+++ b/api/test-current.txt
@@ -48493,7 +48493,8 @@ package android.view.textclassifier {
public final class TextClassificationManager {
method public java.util.List<android.view.textclassifier.TextLanguage> detectLanguages(java.lang.CharSequence);
- method public android.view.textclassifier.TextClassifier getDefaultTextClassifier();
+ method public android.view.textclassifier.TextClassifier getTextClassifier();
+ method public void setTextClassifier(android.view.textclassifier.TextClassifier);
}
public final class TextClassificationResult {
diff --git a/api/test-removed.txt b/api/test-removed.txt
index 75da976d1b64..af429b85eb9b 100644
--- a/api/test-removed.txt
+++ b/api/test-removed.txt
@@ -380,6 +380,14 @@ package android.view {
}
+package android.view.textclassifier {
+
+ public final class TextClassificationManager {
+ method public android.view.textclassifier.TextClassifier getDefaultTextClassifier();
+ }
+
+}
+
package android.webkit {
public class WebViewClient {
diff --git a/core/java/android/view/textclassifier/TextClassificationManager.java b/core/java/android/view/textclassifier/TextClassificationManager.java
index 548796584dc8..0b6021ac7d03 100644
--- a/core/java/android/view/textclassifier/TextClassificationManager.java
+++ b/core/java/android/view/textclassifier/TextClassificationManager.java
@@ -17,6 +17,7 @@
package android.view.textclassifier;
import android.annotation.NonNull;
+import android.annotation.Nullable;
import android.content.Context;
import android.os.ParcelFileDescriptor;
import android.util.Log;
@@ -45,7 +46,7 @@ public final class TextClassificationManager {
private final Context mContext;
private ParcelFileDescriptor mLangIdFd;
- private TextClassifier mDefault;
+ private TextClassifier mTextClassifier;
private LangId mLangId;
/** @hide */
@@ -53,15 +54,32 @@ public final class TextClassificationManager {
mContext = Preconditions.checkNotNull(context);
}
+ // TODO: Remove.
+ /** @removed */
+ public TextClassifier getDefaultTextClassifier() {
+ return getTextClassifier();
+ }
+
/**
- * Returns the default text classifier.
+ * Returns the text classifier.
*/
- public TextClassifier getDefaultTextClassifier() {
+ public TextClassifier getTextClassifier() {
synchronized (mTextClassifierLock) {
- if (mDefault == null) {
- mDefault = new TextClassifierImpl(mContext);
+ if (mTextClassifier == null) {
+ mTextClassifier = new TextClassifierImpl(mContext);
}
- return mDefault;
+ return mTextClassifier;
+ }
+ }
+
+ /**
+ * Sets the text classifier.
+ * Set to null to use the system default text classifier.
+ * Set to {@link TextClassifier#NO_OP} to disable text classifier features.
+ */
+ public void setTextClassifier(@Nullable TextClassifier textClassifier) {
+ synchronized (mTextClassifierLock) {
+ mTextClassifier = textClassifier;
}
}
diff --git a/core/java/android/widget/TextView.java b/core/java/android/widget/TextView.java
index 02afee32153b..3d5e81bcae33 100644
--- a/core/java/android/widget/TextView.java
+++ b/core/java/android/widget/TextView.java
@@ -10765,7 +10765,7 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener
TextClassificationManager tcm =
mContext.getSystemService(TextClassificationManager.class);
if (tcm != null) {
- mTextClassifier = tcm.getDefaultTextClassifier();
+ mTextClassifier = tcm.getTextClassifier();
} else {
mTextClassifier = TextClassifier.NO_OP;
}