diff options
| author | 2024-01-08 20:02:25 +0000 | |
|---|---|---|
| committer | 2024-01-08 20:02:25 +0000 | |
| commit | d8da3a17b314a4aacc50e2334ee9dc2c2531c125 (patch) | |
| tree | dec4e0d88db4d8bf5506faa41c2da380dcfc22bb | |
| parent | a5813cbe2b4f6cd7a470d8aecd5cb66ee013f921 (diff) | |
| parent | 6f0e2b680d192bfcaca246f551818f9f54218639 (diff) | |
Merge "Address AnrTimer minor review comments" into main
| -rw-r--r-- | services/core/jni/com_android_server_utils_AnrTimer.cpp | 6 | ||||
| -rw-r--r-- | services/core/jni/onload.cpp | 4 |
2 files changed, 6 insertions, 4 deletions
diff --git a/services/core/jni/com_android_server_utils_AnrTimer.cpp b/services/core/jni/com_android_server_utils_AnrTimer.cpp index 97b18fac91f4..1e48aced0041 100644 --- a/services/core/jni/com_android_server_utils_AnrTimer.cpp +++ b/services/core/jni/com_android_server_utils_AnrTimer.cpp @@ -486,9 +486,11 @@ class AnrTimerService::Ticker { void remove(AnrTimerService const* service) { AutoMutex _l(lock_); timer_id_t front = headTimerId(); - for (auto i = running_.begin(); i != running_.end(); i++) { + for (auto i = running_.begin(); i != running_.end(); ) { if (i->service == service) { - running_.erase(i); + i = running_.erase(i); + } else { + i++; } } if (front != headTimerId()) restartLocked(); diff --git a/services/core/jni/onload.cpp b/services/core/jni/onload.cpp index 6fffdd010028..a4b1f841d3bc 100644 --- a/services/core/jni/onload.cpp +++ b/services/core/jni/onload.cpp @@ -52,10 +52,10 @@ int register_android_server_Watchdog(JNIEnv* env); int register_android_server_HardwarePropertiesManagerService(JNIEnv* env); int register_android_server_SyntheticPasswordManager(JNIEnv* env); int register_android_hardware_display_DisplayViewport(JNIEnv* env); -int register_android_server_utils_AnrTimer(JNIEnv *env); int register_android_server_am_OomConnection(JNIEnv* env); int register_android_server_am_CachedAppOptimizer(JNIEnv* env); int register_android_server_am_LowMemDetector(JNIEnv* env); +int register_android_server_utils_AnrTimer(JNIEnv *env); int register_com_android_server_soundtrigger_middleware_AudioSessionProviderImpl(JNIEnv* env); int register_com_android_server_soundtrigger_middleware_ExternalCaptureStateTracker(JNIEnv* env); int register_android_server_com_android_server_pm_PackageManagerShellCommandDataLoader(JNIEnv* env); @@ -115,10 +115,10 @@ extern "C" jint JNI_OnLoad(JavaVM* vm, void* /* reserved */) register_android_server_storage_AppFuse(env); register_android_server_SyntheticPasswordManager(env); register_android_hardware_display_DisplayViewport(env); - register_android_server_utils_AnrTimer(env); register_android_server_am_OomConnection(env); register_android_server_am_CachedAppOptimizer(env); register_android_server_am_LowMemDetector(env); + register_android_server_utils_AnrTimer(env); register_com_android_server_soundtrigger_middleware_AudioSessionProviderImpl(env); register_com_android_server_soundtrigger_middleware_ExternalCaptureStateTracker(env); register_android_server_com_android_server_pm_PackageManagerShellCommandDataLoader(env); |