summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author amehfooz <amehfooz@google.com> 2025-01-07 22:02:59 +0000
committer amehfooz <amehfooz@google.com> 2025-01-07 22:02:59 +0000
commitd5f9f6c85bc781621ec85a11f8473eea412a8e7d (patch)
tree532b4f6cecebe927e8b47c9fa673d579c29452f1
parente891c195e7708de48ac8f885a9e13c430b6cbd74 (diff)
Hide View based chips when StatusBarChipsModernization is enabled
Test: Manual, make sure no chips are shown in the status bar. Bug: b/372657935 Flag: com.android.systemui.status_bar_chips_modernization Change-Id: Ifc08dfeb1f66e66d20c59a7f77f8ad4ebe5bc38a
-rw-r--r--packages/SystemUI/src/com/android/systemui/statusbar/pipeline/shared/ui/binder/HomeStatusBarViewBinder.kt13
-rw-r--r--packages/SystemUI/src/com/android/systemui/statusbar/pipeline/shared/ui/composable/StatusBarRoot.kt10
2 files changed, 20 insertions, 3 deletions
diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/shared/ui/binder/HomeStatusBarViewBinder.kt b/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/shared/ui/binder/HomeStatusBarViewBinder.kt
index 7e06c35315f9..0dd7c8499861 100644
--- a/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/shared/ui/binder/HomeStatusBarViewBinder.kt
+++ b/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/shared/ui/binder/HomeStatusBarViewBinder.kt
@@ -41,6 +41,7 @@ import com.android.systemui.statusbar.events.shared.model.SystemEventAnimationSt
import com.android.systemui.statusbar.notification.icon.ui.viewbinder.ConnectedDisplaysStatusBarNotificationIconViewStore
import com.android.systemui.statusbar.notification.shared.NotificationsLiveDataStoreRefactor
import com.android.systemui.statusbar.phone.fragment.CollapsedStatusBarFragment
+import com.android.systemui.statusbar.phone.ongoingcall.StatusBarChipsModernization
import com.android.systemui.statusbar.pipeline.shared.ui.viewmodel.HomeStatusBarViewModel
import com.android.systemui.statusbar.pipeline.shared.ui.viewmodel.HomeStatusBarViewModel.VisibilityModel
import javax.inject.Inject
@@ -115,7 +116,11 @@ constructor(
}
}
- if (Flags.statusBarScreenSharingChips() && !StatusBarNotifChips.isEnabled) {
+ if (
+ Flags.statusBarScreenSharingChips() &&
+ !StatusBarNotifChips.isEnabled &&
+ !StatusBarChipsModernization.isEnabled
+ ) {
val primaryChipView: View =
view.requireViewById(R.id.ongoing_activity_chip_primary)
launch {
@@ -157,7 +162,11 @@ constructor(
}
}
- if (Flags.statusBarScreenSharingChips() && StatusBarNotifChips.isEnabled) {
+ if (
+ Flags.statusBarScreenSharingChips() &&
+ StatusBarNotifChips.isEnabled &&
+ !StatusBarChipsModernization.isEnabled
+ ) {
val primaryChipView: View =
view.requireViewById(R.id.ongoing_activity_chip_primary)
val secondaryChipView: View =
diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/shared/ui/composable/StatusBarRoot.kt b/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/shared/ui/composable/StatusBarRoot.kt
index 7243ba7def58..f286a1a148fa 100644
--- a/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/shared/ui/composable/StatusBarRoot.kt
+++ b/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/shared/ui/composable/StatusBarRoot.kt
@@ -164,11 +164,19 @@ fun StatusBarRoot(
statusBarViewModel.iconBlockList,
)
- if (!StatusBarChipsModernization.isEnabled) {
+ if (StatusBarChipsModernization.isEnabled) {
+ // Make sure the primary chip is hidden when StatusBarChipsModernization is
+ // enabled. OngoingActivityChips will be shown in a composable container
+ // when this flag is enabled.
+ phoneStatusBarView
+ .requireViewById<View>(R.id.ongoing_activity_chip_primary)
+ .visibility = View.GONE
+ } else {
ongoingCallController.setChipView(
phoneStatusBarView.requireViewById(R.id.ongoing_activity_chip_primary)
)
}
+
// For notifications, first inflate the [NotificationIconContainer]
val notificationIconArea =
phoneStatusBarView.requireViewById<ViewGroup>(R.id.notification_icon_area)