summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Chun-Ku Lin <chunkulin@google.com> 2023-08-23 19:24:56 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2023-08-23 19:24:56 +0000
commitd5862f45e7926e559f6577efc3d315e0ff3a901f (patch)
tree4493d85c3af5933cfeb541fac8ca15074c74c326
parent5572b86a057a86fa268a141fafb2d1403a26f99a (diff)
parent5c0996d5410b1f96dcc2024143e3eef6d704a7c5 (diff)
Merge "Use mAccessibilityManager everywhere in ViewRootImpl for consistency" into main
-rw-r--r--core/java/android/view/ViewRootImpl.java16
1 files changed, 10 insertions, 6 deletions
diff --git a/core/java/android/view/ViewRootImpl.java b/core/java/android/view/ViewRootImpl.java
index ddd3269925a4..e0fda7e51c33 100644
--- a/core/java/android/view/ViewRootImpl.java
+++ b/core/java/android/view/ViewRootImpl.java
@@ -4127,7 +4127,7 @@ public final class ViewRootImpl implements ViewParent,
}
private void fireAccessibilityFocusEventIfHasFocusedNode() {
- if (!AccessibilityManager.getInstance(mContext).isEnabled()) {
+ if (!mAccessibilityManager.isEnabled()) {
return;
}
final View focusedView = mView.findFocus();
@@ -5179,8 +5179,12 @@ public final class ViewRootImpl implements ViewParent,
}
private boolean getAccessibilityFocusedRect(Rect bounds) {
- final AccessibilityManager manager = AccessibilityManager.getInstance(mView.mContext);
- if (!manager.isEnabled() || !manager.isTouchExplorationEnabled()) {
+ if (mView == null) {
+ Slog.w(TAG, "calling getAccessibilityFocusedRect() while the mView is null");
+ return false;
+ }
+ if (!mAccessibilityManager.isEnabled()
+ || !mAccessibilityManager.isTouchExplorationEnabled()) {
return false;
}
@@ -7248,8 +7252,8 @@ public final class ViewRootImpl implements ViewParent,
&& action != MotionEvent.ACTION_HOVER_EXIT) {
return;
}
- AccessibilityManager manager = AccessibilityManager.getInstance(mContext);
- if (manager.isEnabled() && manager.isTouchExplorationEnabled()) {
+ if (mAccessibilityManager.isEnabled()
+ && mAccessibilityManager.isTouchExplorationEnabled()) {
return;
}
if (mView == null) {
@@ -11049,7 +11053,7 @@ public final class ViewRootImpl implements ViewParent,
return;
}
// The accessibility may be turned off while we were waiting so check again.
- if (AccessibilityManager.getInstance(mContext).isEnabled()) {
+ if (mAccessibilityManager.isEnabled()) {
mLastEventTimeMillis = SystemClock.uptimeMillis();
AccessibilityEvent event = AccessibilityEvent.obtain();
event.setEventType(AccessibilityEvent.TYPE_WINDOW_CONTENT_CHANGED);