summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Bill Lin <lbill@google.com> 2021-11-19 10:16:29 +0800
committer Bill Lin <lbill@google.com> 2021-11-19 02:33:01 +0000
commitd515f6724f48a8f809b1875c5bb4063d3934cdcb (patch)
treec10e19c9d2f65016fedf92648159c7056b6747bb
parent70ba2506df87a7f930cceaf757432cb225003536 (diff)
Fix ACTION_ONE_HANDED_SETTINGS breaks CTS IntentTest
The CTS test will check new added intent is expected android.signature.cts.intent.IntentTest#shouldNotFindUnexpectedIntents If the new added intent should belong to allow list, we should add it into cts/tests/signature/intent-check/DynamicConfig.xml However, in One handed mode case, I think it's make sense to define in settings provider frameworks/base/core/java/android/provider/Settings.java Test: atest android.signature.cts.intent.IntentTest Fixes: 206824091 Fixes: 206989400 Change-Id: Ibee10261a780737a83f5e5b3dff5c20bc31ceafe
-rw-r--r--core/java/android/content/Intent.java9
-rw-r--r--packages/SystemUI/src/com/android/systemui/qs/tiles/OneHandedModeTile.java3
2 files changed, 2 insertions, 10 deletions
diff --git a/core/java/android/content/Intent.java b/core/java/android/content/Intent.java
index fccb8a785166..3c9b1f81da8a 100644
--- a/core/java/android/content/Intent.java
+++ b/core/java/android/content/Intent.java
@@ -1564,15 +1564,6 @@ public class Intent implements Parcelable, Cloneable {
public static final String ACTION_POWER_USAGE_SUMMARY = "android.intent.action.POWER_USAGE_SUMMARY";
/**
- * Activity Action: Show one-handed mode settings to the user.
- * <p>Input: Nothing.
- * <p>Output: Nothing.
- * @hide
- */
- public static final String ACTION_ONE_HANDED_SETTINGS =
- "android.intent.action.ONE_HANDED_SETTINGS";
-
- /**
* Activity Action: Setup wizard action provided for OTA provisioning to determine if it needs
* to run.
* <p>Input: Nothing.
diff --git a/packages/SystemUI/src/com/android/systemui/qs/tiles/OneHandedModeTile.java b/packages/SystemUI/src/com/android/systemui/qs/tiles/OneHandedModeTile.java
index c8d2cdc1e478..d4525df38de3 100644
--- a/packages/SystemUI/src/com/android/systemui/qs/tiles/OneHandedModeTile.java
+++ b/packages/SystemUI/src/com/android/systemui/qs/tiles/OneHandedModeTile.java
@@ -105,7 +105,8 @@ public class OneHandedModeTile extends QSTileImpl<BooleanState> {
@Override
public Intent getLongClickIntent() {
- return new Intent(Intent.ACTION_ONE_HANDED_SETTINGS);
+ // TODO(b/201743873) define new intent action ACTION_ONE_HANDED_SETTINGS in Settings.
+ return null;
}
@Override