summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Abodunrinwa Toki <toki@google.com> 2017-07-12 19:38:54 +0100
committer Abodunrinwa Toki <toki@google.com> 2017-07-12 20:26:27 +0100
commitd44286f94240f79b26703cf1dcff94893135c93c (patch)
treefe7ce2d24e1aa0541ad0e549b143394308d8a8e4
parent3c3acf8bf1f48d5a1d33282ff24be5e1300d3298 (diff)
TextClassification.text is nullable
Removes the @NonNull requirement on TextClassification.text. e.g. TextClassifier.NO_OP doesn't classify text and thus returns TextClassification.EMPTY which doesn't set TextClassification.text. This is ideal as we need not make copies of this object when NO_OP was performed. Test: bit CtsViewTestCases:android.view.textclassifier.cts.TextClassificationManagerTest bit FrameworksCoreTests:android.widget.TextViewActivityTest bit CtsWidgetTestCases:android.widget.cts.TextViewTest Change-Id: I0b3ac5bf0027cbd67ba40d1110f1100280c8c3a2
-rw-r--r--core/java/android/view/textclassifier/TextClassification.java18
1 files changed, 9 insertions, 9 deletions
diff --git a/core/java/android/view/textclassifier/TextClassification.java b/core/java/android/view/textclassifier/TextClassification.java
index b6dd0b948739..d1e0ae5917f4 100644
--- a/core/java/android/view/textclassifier/TextClassification.java
+++ b/core/java/android/view/textclassifier/TextClassification.java
@@ -50,11 +50,11 @@ public final class TextClassification {
private int mLogType;
private TextClassification(
- @NonNull String text,
- Drawable icon,
- String label,
- Intent intent,
- OnClickListener onClickListener,
+ @Nullable String text,
+ @Nullable Drawable icon,
+ @Nullable String label,
+ @Nullable Intent intent,
+ @Nullable OnClickListener onClickListener,
@NonNull EntityConfidence<String> entityConfidence,
int logType) {
mText = text;
@@ -70,7 +70,7 @@ public final class TextClassification {
/**
* Gets the classified text.
*/
- @NonNull
+ @Nullable
public String getText() {
return mText;
}
@@ -183,8 +183,8 @@ public final class TextClassification {
/**
* Sets the classified text.
*/
- public Builder setText(@NonNull String text) {
- mText = Preconditions.checkNotNull(text);
+ public Builder setText(@Nullable String text) {
+ mText = text;
return this;
}
@@ -197,7 +197,7 @@ public final class TextClassification {
*/
public Builder setEntityType(
@NonNull @EntityType String type,
- @FloatRange(from = 0.0, to = 1.0)float confidenceScore) {
+ @FloatRange(from = 0.0, to = 1.0) float confidenceScore) {
mEntityConfidence.setEntityType(type, confidenceScore);
return this;
}