diff options
| author | 2023-08-31 19:26:35 +0000 | |
|---|---|---|
| committer | 2023-08-31 19:26:40 +0000 | |
| commit | d2cbfdc49c6c55bc64668f72faebddea8951b0e2 (patch) | |
| tree | dc7bc65a135022194579c812926771ebcfcb85b0 | |
| parent | 86da59b4d032b64d5db2a513602840cbb4861f7d (diff) | |
[pm] don't call onChanged at the end of commitPackageStateMutation
onChanged() is the trigger of snapshot building. During commitPackageStateMutation, it should already be called when the set* methods of PackageSetting or PackageUserStateImpl are called as part of the mutation. One exception is setLastPackageUsageTimeInMills, we intentionally don't want to call onChanged() because of its frequent updates. Having another onChanged in commitPackageStateMutation is unnecessary and can cause unwanted snapshotting, as shown in b/298096460. Removing it to avoid future misuses.
Change-Id: Iaf201c43c394059f71181308a2b89dd65ba68e8e
BUG: 298409017
Test: presubmit
| -rw-r--r-- | services/core/java/com/android/server/pm/PackageManagerService.java | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/services/core/java/com/android/server/pm/PackageManagerService.java b/services/core/java/com/android/server/pm/PackageManagerService.java index 8faadba759fa..7390bbe5cac9 100644 --- a/services/core/java/com/android/server/pm/PackageManagerService.java +++ b/services/core/java/com/android/server/pm/PackageManagerService.java @@ -7791,7 +7791,6 @@ public class PackageManagerService implements PackageSender, TestUtilityService consumer.accept(mPackageStateMutator); mPackageStateMutator.onFinished(); - onChanged(); } return PackageStateMutator.Result.SUCCESS; |