diff options
| author | 2024-01-22 13:48:12 +0000 | |
|---|---|---|
| committer | 2024-01-22 13:49:56 +0000 | |
| commit | d26f18a7d47432a03babf78ed433299014a8c971 (patch) | |
| tree | f43243fea3f0aeaa5ebb66a86df260eb60737862 | |
| parent | 54debd28a7e34b4ac8ab297d6b6473fb726c288b (diff) | |
Simplify MediaRouter2 stub unregistering logic
The change deduplicates logic I missed in ag/25932085.
This is a non-functional change.
Bug: 205124386
Test: Presubmit.
Change-Id: I881470dd39cb7327cbcb91dc7d5463878cb99d52
| -rw-r--r-- | media/java/android/media/MediaRouter2.java | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/media/java/android/media/MediaRouter2.java b/media/java/android/media/MediaRouter2.java index 17f25255fd4b..687feef6c58a 100644 --- a/media/java/android/media/MediaRouter2.java +++ b/media/java/android/media/MediaRouter2.java @@ -3109,9 +3109,8 @@ public final class MediaRouter2 { mStub, mDiscoveryPreference); } - if (mRouteCallbackRecords.isEmpty() && mNonSystemRoutingControllers.isEmpty()) { - unregisterRouterStubLocked(); - } + unregisterRouterStubIfNeededLocked(); + } catch (RemoteException ex) { Log.e(TAG, "unregisterRouteCallback: Unable to set discovery request.", ex); } @@ -3319,13 +3318,12 @@ public final class MediaRouter2 { obtainMessage(MediaRouter2::notifyStop, MediaRouter2.this, controller)); } - if (mRouteCallbackRecords.isEmpty() && mNonSystemRoutingControllers.isEmpty()) { - try { - unregisterRouterStubLocked(); - } catch (RemoteException ex) { - ex.rethrowFromSystemServer(); - } + try { + unregisterRouterStubIfNeededLocked(); + } catch (RemoteException ex) { + ex.rethrowFromSystemServer(); } + } } @@ -3339,8 +3337,10 @@ public final class MediaRouter2 { } @GuardedBy("mLock") - private void unregisterRouterStubLocked() throws RemoteException { - if (mStub != null) { + private void unregisterRouterStubIfNeededLocked() throws RemoteException { + if (mStub != null + && mRouteCallbackRecords.isEmpty() + && mNonSystemRoutingControllers.isEmpty()) { mMediaRouterService.unregisterRouter2(mStub); mStub = null; } |