diff options
| author | 2024-01-31 12:22:02 -0800 | |
|---|---|---|
| committer | 2024-02-01 10:53:10 -0800 | |
| commit | d0eaaa7983a7cd34650ff75d5ce32395e9b2a70a (patch) | |
| tree | 4df94fe2626b0930076617a9e796dbc5f4c621ba | |
| parent | 80094cc25a0f2a45228821a14d2b06bffb9e8c4c (diff) | |
Do not show UMO resumption state in the hub
This will also allow the MediaCarouselController to properly reset the
"settings cog" when transitioning to the hub.
Bug: 322551201
Fix: 322551201
Test: manually; see video in bug
Flag: ACONFIG com.android.systemui.communal_hub STAGING
Change-Id: Id5f29f70f81e30c24525bdbd86ab975c2de0cfe8
6 files changed, 17 insertions, 17 deletions
diff --git a/packages/SystemUI/multivalentTests/src/com/android/systemui/communal/data/repository/CommunalMediaRepositoryImplTest.kt b/packages/SystemUI/multivalentTests/src/com/android/systemui/communal/data/repository/CommunalMediaRepositoryImplTest.kt index 1642e527aa15..45f98be2ca12 100644 --- a/packages/SystemUI/multivalentTests/src/com/android/systemui/communal/data/repository/CommunalMediaRepositoryImplTest.kt +++ b/packages/SystemUI/multivalentTests/src/com/android/systemui/communal/data/repository/CommunalMediaRepositoryImplTest.kt @@ -72,7 +72,7 @@ class CommunalMediaRepositoryImplTest : SysuiTestCase() { testScope.runTest { val mediaModel = collectLastValue(underTest.mediaModel) runCurrent() - assertThat(mediaModel()?.hasAnyMediaOrRecommendation).isFalse() + assertThat(mediaModel()?.hasActiveMediaOrRecommendation).isFalse() } @Test @@ -84,16 +84,16 @@ class CommunalMediaRepositoryImplTest : SysuiTestCase() { // Initial value is false. val mediaModel = collectLastValue(underTest.mediaModel) runCurrent() - assertThat(mediaModel()?.hasAnyMediaOrRecommendation).isFalse() + assertThat(mediaModel()?.hasActiveMediaOrRecommendation).isFalse() // Change to media available and notify the listener. - whenever(mediaDataManager.hasAnyMediaOrRecommendation()).thenReturn(true) + whenever(mediaDataManager.hasActiveMediaOrRecommendation()).thenReturn(true) whenever(mediaData.createdTimestampMillis).thenReturn(1234L) mediaDataListenerCaptor.value.onMediaDataLoaded("key", null, mediaData) runCurrent() // Media active now returns true. - assertThat(mediaModel()?.hasAnyMediaOrRecommendation).isTrue() + assertThat(mediaModel()?.hasActiveMediaOrRecommendation).isTrue() assertThat(mediaModel()?.createdTimestampMillis).isEqualTo(1234L) } @@ -104,20 +104,20 @@ class CommunalMediaRepositoryImplTest : SysuiTestCase() { verify(mediaDataManager).addListener(mediaDataListenerCaptor.capture()) // Change to media available and notify the listener. - whenever(mediaDataManager.hasAnyMediaOrRecommendation()).thenReturn(true) + whenever(mediaDataManager.hasActiveMediaOrRecommendation()).thenReturn(true) mediaDataListenerCaptor.value.onMediaDataLoaded("key", null, mediaData) runCurrent() // Media active now returns true. val mediaModel = collectLastValue(underTest.mediaModel) - assertThat(mediaModel()?.hasAnyMediaOrRecommendation).isTrue() + assertThat(mediaModel()?.hasActiveMediaOrRecommendation).isTrue() // Change to media unavailable and notify the listener. - whenever(mediaDataManager.hasAnyMediaOrRecommendation()).thenReturn(false) + whenever(mediaDataManager.hasActiveMediaOrRecommendation()).thenReturn(false) mediaDataListenerCaptor.value.onMediaDataRemoved("key") runCurrent() // Media active now returns false. - assertThat(mediaModel()?.hasAnyMediaOrRecommendation).isFalse() + assertThat(mediaModel()?.hasActiveMediaOrRecommendation).isFalse() } } diff --git a/packages/SystemUI/src/com/android/systemui/communal/data/model/CommunalMediaModel.kt b/packages/SystemUI/src/com/android/systemui/communal/data/model/CommunalMediaModel.kt index c46f0d1cfcb6..33edb800756d 100644 --- a/packages/SystemUI/src/com/android/systemui/communal/data/model/CommunalMediaModel.kt +++ b/packages/SystemUI/src/com/android/systemui/communal/data/model/CommunalMediaModel.kt @@ -21,21 +21,21 @@ import com.android.systemui.log.table.TableRowLogger /** Data model of media on the communal hub. */ data class CommunalMediaModel( - val hasAnyMediaOrRecommendation: Boolean, + val hasActiveMediaOrRecommendation: Boolean, val createdTimestampMillis: Long = 0L, ) : Diffable<CommunalMediaModel> { companion object { val INACTIVE = CommunalMediaModel( - hasAnyMediaOrRecommendation = false, + hasActiveMediaOrRecommendation = false, ) } override fun logDiffs(prevVal: CommunalMediaModel, row: TableRowLogger) { - if (hasAnyMediaOrRecommendation != prevVal.hasAnyMediaOrRecommendation) { + if (hasActiveMediaOrRecommendation != prevVal.hasActiveMediaOrRecommendation) { row.logChange( columnName = "isMediaActive", - value = hasAnyMediaOrRecommendation, + value = hasActiveMediaOrRecommendation, ) } diff --git a/packages/SystemUI/src/com/android/systemui/communal/data/repository/CommunalMediaRepository.kt b/packages/SystemUI/src/com/android/systemui/communal/data/repository/CommunalMediaRepository.kt index 2b66491613ab..201be51b873c 100644 --- a/packages/SystemUI/src/com/android/systemui/communal/data/repository/CommunalMediaRepository.kt +++ b/packages/SystemUI/src/com/android/systemui/communal/data/repository/CommunalMediaRepository.kt @@ -73,10 +73,10 @@ constructor( ) private fun updateMediaModel(data: MediaData? = null) { - if (mediaDataManager.hasAnyMediaOrRecommendation()) { + if (mediaDataManager.hasActiveMediaOrRecommendation()) { _mediaModel.value = CommunalMediaModel( - hasAnyMediaOrRecommendation = true, + hasActiveMediaOrRecommendation = true, createdTimestampMillis = data?.createdTimestampMillis ?: 0L, ) } else { diff --git a/packages/SystemUI/src/com/android/systemui/communal/domain/interactor/CommunalInteractor.kt b/packages/SystemUI/src/com/android/systemui/communal/domain/interactor/CommunalInteractor.kt index 75a27a278116..950ac3c3aae6 100644 --- a/packages/SystemUI/src/com/android/systemui/communal/domain/interactor/CommunalInteractor.kt +++ b/packages/SystemUI/src/com/android/systemui/communal/domain/interactor/CommunalInteractor.kt @@ -318,7 +318,7 @@ constructor( ) // Add UMO - if (media.hasAnyMediaOrRecommendation) { + if (media.hasActiveMediaOrRecommendation) { ongoingContent.add( CommunalContentModel.Umo( createdTimestampMillis = media.createdTimestampMillis, diff --git a/packages/SystemUI/src/com/android/systemui/communal/ui/viewmodel/CommunalViewModel.kt b/packages/SystemUI/src/com/android/systemui/communal/ui/viewmodel/CommunalViewModel.kt index 0c12841aa42b..40d2d1656fbc 100644 --- a/packages/SystemUI/src/com/android/systemui/communal/ui/viewmodel/CommunalViewModel.kt +++ b/packages/SystemUI/src/com/android/systemui/communal/ui/viewmodel/CommunalViewModel.kt @@ -87,7 +87,7 @@ constructor( with(mediaHost) { expansion = MediaHostState.EXPANDED expandedMatchesParentHeight = true - showsOnlyActiveMedia = false + showsOnlyActiveMedia = true falsingProtectionNeeded = false init(MediaHierarchyManager.LOCATION_COMMUNAL_HUB) } diff --git a/packages/SystemUI/tests/utils/src/com/android/systemui/communal/data/repository/FakeCommunalMediaRepository.kt b/packages/SystemUI/tests/utils/src/com/android/systemui/communal/data/repository/FakeCommunalMediaRepository.kt index 3ea3ccfb2909..1884a3264ed6 100644 --- a/packages/SystemUI/tests/utils/src/com/android/systemui/communal/data/repository/FakeCommunalMediaRepository.kt +++ b/packages/SystemUI/tests/utils/src/com/android/systemui/communal/data/repository/FakeCommunalMediaRepository.kt @@ -28,7 +28,7 @@ class FakeCommunalMediaRepository : CommunalMediaRepository { fun mediaActive(timestamp: Long = 0L) { _mediaModel.value = CommunalMediaModel( - hasAnyMediaOrRecommendation = true, + hasActiveMediaOrRecommendation = true, createdTimestampMillis = timestamp, ) } |