diff options
| author | 2023-09-22 21:12:31 +0000 | |
|---|---|---|
| committer | 2023-09-25 19:58:51 +0000 | |
| commit | cf95e250abd0e66ec74e719d1866f3769da3d2fa (patch) | |
| tree | c52b65504233531aa9ac0b2c6fdab23c6083b569 | |
| parent | d74e3d74586862e53b7be6b178a4ce7f6a639679 (diff) | |
Use groove for volume dialog slider
Previously we had a track line that stopped below the max val, creating
the illusion that at ~90%, volume level is full. It looked misaligned
next to a 100% slider.
Bug: b/289814874
Test: Manual. Groove height should match progress button at 100%.
Change-Id: Ifd2d7acdac7b6a154728536b096ac0dbd1d40b3d
| -rw-r--r-- | packages/SystemUI/res/drawable/volume_row_seekbar.xml | 15 | ||||
| -rw-r--r-- | packages/SystemUI/res/values/dimens.xml | 2 |
2 files changed, 7 insertions, 10 deletions
diff --git a/packages/SystemUI/res/drawable/volume_row_seekbar.xml b/packages/SystemUI/res/drawable/volume_row_seekbar.xml index 7ce1ba3be7f6..d7d75d4304d0 100644 --- a/packages/SystemUI/res/drawable/volume_row_seekbar.xml +++ b/packages/SystemUI/res/drawable/volume_row_seekbar.xml @@ -20,17 +20,14 @@ <layer-list xmlns:android="http://schemas.android.com/apk/res/android" xmlns:androidprv="http://schemas.android.com/apk/prv/res/android" android:paddingMode="stack" > + <!-- The groove used for indicating max volume !--> <item android:id="@android:id/background" android:gravity="center_vertical|fill_horizontal"> - <inset - android:insetLeft="@dimen/rounded_slider_track_inset" - android:insetRight="@dimen/rounded_slider_track_inset" > - <shape> - <size android:height="@dimen/volume_dialog_track_width" /> - <corners android:radius="@dimen/volume_dialog_track_corner_radius" /> - <solid android:color="?androidprv:attr/colorAccentSecondaryVariant" /> - </shape> - </inset> + <shape> + <size android:height="@dimen/volume_dialog_track_width" /> + <corners android:radius="@dimen/volume_dialog_panel_width_half" /> + <solid android:color="?androidprv:attr/materialColorOutlineVariant" /> + </shape> </item> <item android:id="@android:id/progress" android:gravity="center_vertical|fill_horizontal"> diff --git a/packages/SystemUI/res/values/dimens.xml b/packages/SystemUI/res/values/dimens.xml index 88726af39c25..d5658dcf0f8e 100644 --- a/packages/SystemUI/res/values/dimens.xml +++ b/packages/SystemUI/res/values/dimens.xml @@ -545,7 +545,7 @@ <!-- (volume_dialog_panel_width - rounded_slider_icon_size) / 2 --> <dimen name="volume_slider_icon_inset">11dp</dimen> - <dimen name="volume_dialog_track_width">4dp</dimen> + <dimen name="volume_dialog_track_width">40dp</dimen> <dimen name="volume_dialog_track_corner_radius">2dp</dimen> |