summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Felipe Leme <felipeal@google.com> 2017-08-16 23:25:07 +0000
committer Felipe Leme <felipeal@google.com> 2017-08-16 23:34:06 +0000
commitcf1ff6ca3dbf90fe9c9a5e161094046394a4004d (patch)
tree23119885de0e84291c12461992c6ea1996f26a6a
parent05ea98a3f95a2f5179c01a5bfd4901835a0c1bd8 (diff)
Revert "Dismiss Autofill Save UI when a new Activity is launched."
This reverts commit 05ea98a3f95a2f5179c01a5bfd4901835a0c1bd8. Bug: 64693551 Change-Id: I8e7a7b2c5f575cee28f977ae7f3c10752a15d49c
-rw-r--r--core/java/android/app/Activity.java5
-rw-r--r--core/java/android/view/autofill/AutofillManager.java19
-rw-r--r--core/java/android/view/autofill/IAutoFillManager.aidl1
-rw-r--r--services/autofill/java/com/android/server/autofill/AutofillManagerService.java13
-rw-r--r--services/autofill/java/com/android/server/autofill/AutofillManagerServiceImpl.java7
5 files changed, 1 insertions, 44 deletions
diff --git a/core/java/android/app/Activity.java b/core/java/android/app/Activity.java
index 1c8a37606ffe..adb3152d4ae7 100644
--- a/core/java/android/app/Activity.java
+++ b/core/java/android/app/Activity.java
@@ -1006,11 +1006,6 @@ public class Activity extends ContextThemeWrapper
Parcelable p = savedInstanceState.getParcelable(FRAGMENTS_TAG);
mFragments.restoreAllState(p, mLastNonConfigurationInstances != null
? mLastNonConfigurationInstances.fragments : null);
- } else {
- AutofillManager afm = getAutofillManager();
- if (afm != null) {
- afm.dismissUi();
- }
}
mFragments.dispatchCreate();
getApplication().dispatchActivityCreated(this, savedInstanceState);
diff --git a/core/java/android/view/autofill/AutofillManager.java b/core/java/android/view/autofill/AutofillManager.java
index a0d909949db2..29e5523ceb7c 100644
--- a/core/java/android/view/autofill/AutofillManager.java
+++ b/core/java/android/view/autofill/AutofillManager.java
@@ -1339,25 +1339,6 @@ public final class AutofillManager {
}
/**
- * Dismiss the Autofill UI, even if associated with other sessions.
- *
- * <p>Typically called when a new activity starts so it can hide the existing Save UI (if any).
- *
- * @hide
- */
- public void dismissUi() {
- if (sVerbose) Log.v(TAG, "dismissUi()");
-
- if (mService == null) return;
-
- try {
- mService.dismissUi();
- } catch (RemoteException e) {
- e.rethrowFromSystemServer();
- }
- }
-
- /**
* View tracking information. Once all tracked views become invisible the session is finished.
*/
private class TrackedViews {
diff --git a/core/java/android/view/autofill/IAutoFillManager.aidl b/core/java/android/view/autofill/IAutoFillManager.aidl
index aa8e19a8ceb2..627afa7f8364 100644
--- a/core/java/android/view/autofill/IAutoFillManager.aidl
+++ b/core/java/android/view/autofill/IAutoFillManager.aidl
@@ -49,5 +49,4 @@ interface IAutoFillManager {
void disableOwnedAutofillServices(int userId);
boolean isServiceSupported(int userId);
boolean isServiceEnabled(int userId, String packageName);
- void dismissUi();
}
diff --git a/services/autofill/java/com/android/server/autofill/AutofillManagerService.java b/services/autofill/java/com/android/server/autofill/AutofillManagerService.java
index e85407961f36..71f699c8da54 100644
--- a/services/autofill/java/com/android/server/autofill/AutofillManagerService.java
+++ b/services/autofill/java/com/android/server/autofill/AutofillManagerService.java
@@ -655,19 +655,6 @@ public final class AutofillManagerService extends SystemService {
}
@Override
- public void dismissUi() {
- final UserHandle user = getCallingUserHandle();
-
- synchronized (mLock) {
- final AutofillManagerServiceImpl service = peekServiceForUserLocked(
- user.getIdentifier());
- if (service != null) {
- service.dismissUi();
- }
- }
- }
-
- @Override
public void dump(FileDescriptor fd, PrintWriter pw, String[] args) {
if (!DumpUtils.checkDumpPermission(mContext, TAG, pw)) return;
diff --git a/services/autofill/java/com/android/server/autofill/AutofillManagerServiceImpl.java b/services/autofill/java/com/android/server/autofill/AutofillManagerServiceImpl.java
index 841b1a52f403..751c0547afd6 100644
--- a/services/autofill/java/com/android/server/autofill/AutofillManagerServiceImpl.java
+++ b/services/autofill/java/com/android/server/autofill/AutofillManagerServiceImpl.java
@@ -41,6 +41,7 @@ import android.os.IBinder;
import android.os.Looper;
import android.os.RemoteCallbackList;
import android.os.RemoteException;
+import android.os.UserHandle;
import android.os.UserManager;
import android.provider.Settings;
import android.service.autofill.AutofillService;
@@ -634,12 +635,6 @@ final class AutofillManagerServiceImpl {
}
}
- void dismissUi() {
- if (sVerbose) Slog.v(TAG, "dismissUi()");
-
- mUi.hideAll(null);
- }
-
private void sendStateToClients(boolean resetClient) {
final RemoteCallbackList<IAutoFillManagerClient> clients;
final int userClientCount;