diff options
| author | 2019-02-21 11:11:59 -0800 | |
|---|---|---|
| committer | 2019-02-21 11:56:26 -0800 | |
| commit | cf1a62e830010090dc5774900300182ae09c35f6 (patch) | |
| tree | 1c127dea31b92910b1915f12fd7a3f2e39d2f350 | |
| parent | 7f7ec2f2448ae7d88e387a76fea9ca875cbf78a2 (diff) | |
Fix SyntheticPasswordTests
Move the biometric check to the injector so it can be ignored for tests
Test: atest SyntheticPasswordTests
Change-Id: I261edac299bbda5205b0759670def073a46dc49a
| -rw-r--r-- | services/core/java/com/android/server/locksettings/LockSettingsService.java | 6 | ||||
| -rw-r--r-- | services/tests/servicestests/src/com/android/server/locksettings/LockSettingsServiceTestable.java | 5 |
2 files changed, 10 insertions, 1 deletions
diff --git a/services/core/java/com/android/server/locksettings/LockSettingsService.java b/services/core/java/com/android/server/locksettings/LockSettingsService.java index 4b4788cd4a16..7f8275bae88f 100644 --- a/services/core/java/com/android/server/locksettings/LockSettingsService.java +++ b/services/core/java/com/android/server/locksettings/LockSettingsService.java @@ -405,6 +405,10 @@ public class LockSettingsService extends ILockSettings.Stub { return new SyntheticPasswordManager(getContext(), storage, getUserManager()); } + public boolean hasBiometrics() { + return BiometricManager.hasBiometrics(mContext); + } + public int binderGetCallingUid() { return Binder.getCallingUid(); } @@ -2423,7 +2427,7 @@ public class LockSettingsService extends ILockSettings.Stub { notifyActivePasswordMetricsAvailable(userCredential, userId); unlockKeystore(authResult.authToken.deriveKeyStorePassword(), userId); // Reset lockout - if (BiometricManager.hasBiometrics(mContext)) { + if (mInjector.hasBiometrics()) { BiometricManager bm = mContext.getSystemService(BiometricManager.class); Slog.i(TAG, "Resetting lockout, length: " + authResult.gkResponse.getPayload().length); diff --git a/services/tests/servicestests/src/com/android/server/locksettings/LockSettingsServiceTestable.java b/services/tests/servicestests/src/com/android/server/locksettings/LockSettingsServiceTestable.java index fe683abe7e1b..d53850d9a5df 100644 --- a/services/tests/servicestests/src/com/android/server/locksettings/LockSettingsServiceTestable.java +++ b/services/tests/servicestests/src/com/android/server/locksettings/LockSettingsServiceTestable.java @@ -104,6 +104,11 @@ public class LockSettingsServiceTestable extends LockSettingsService { } @Override + public boolean hasBiometrics() { + return false; + } + + @Override public int binderGetCallingUid() { return Process.SYSTEM_UID; } |