summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Ján Sebechlebský <jsebechlebsky@google.com> 2023-07-26 09:21:10 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2023-07-26 09:21:10 +0000
commitcd59ed7653e92ca697b42fc818cdf339c34b9b4f (patch)
treee523ac67deb812be03c0990f77178afe38a8b10d
parentc62afc4f8ab4abf200767f550cebfc5de1f25c7a (diff)
parent502f572905173661c0901ac036aec146b22bcbcd (diff)
Merge "Make onVirtualDisplayRemoved callback idempotent." into main
-rw-r--r--services/companion/java/com/android/server/companion/virtual/VirtualDeviceImpl.java5
-rw-r--r--services/tests/servicestests/src/com/android/server/companion/virtual/VirtualDeviceManagerServiceTest.java7
2 files changed, 3 insertions, 9 deletions
diff --git a/services/companion/java/com/android/server/companion/virtual/VirtualDeviceImpl.java b/services/companion/java/com/android/server/companion/virtual/VirtualDeviceImpl.java
index 51acfd362677..402fbb812812 100644
--- a/services/companion/java/com/android/server/companion/virtual/VirtualDeviceImpl.java
+++ b/services/companion/java/com/android/server/companion/virtual/VirtualDeviceImpl.java
@@ -927,8 +927,9 @@ final class VirtualDeviceImpl extends IVirtualDevice.Stub
}
if (virtualDisplayWrapper == null) {
- throw new IllegalStateException(
- "Virtual device doesn't have a virtual display with ID " + displayId);
+ Slog.w(TAG, "Virtual device " + mDeviceId + " doesn't have a virtual display with ID "
+ + displayId);
+ return;
}
final long ident = Binder.clearCallingIdentity();
diff --git a/services/tests/servicestests/src/com/android/server/companion/virtual/VirtualDeviceManagerServiceTest.java b/services/tests/servicestests/src/com/android/server/companion/virtual/VirtualDeviceManagerServiceTest.java
index e6b12693c5e4..4512cc025bf0 100644
--- a/services/tests/servicestests/src/com/android/server/companion/virtual/VirtualDeviceManagerServiceTest.java
+++ b/services/tests/servicestests/src/com/android/server/companion/virtual/VirtualDeviceManagerServiceTest.java
@@ -790,13 +790,6 @@ public class VirtualDeviceManagerServiceTest {
}
@Test
- public void onVirtualDisplayRemovedLocked_unknownDisplayId_throwsException() {
- final int unknownDisplayId = 999;
- assertThrows(IllegalStateException.class,
- () -> mDeviceImpl.onVirtualDisplayRemoved(unknownDisplayId));
- }
-
- @Test
public void onVirtualDisplayRemovedLocked_wakeLockIsReleased() throws RemoteException {
addVirtualDisplay(mDeviceImpl, DISPLAY_ID_1);
ArgumentCaptor<IBinder> wakeLockCaptor = ArgumentCaptor.forClass(IBinder.class);