diff options
| author | 2015-03-30 20:40:15 +0000 | |
|---|---|---|
| committer | 2015-03-30 20:42:10 +0000 | |
| commit | cc6855fc7f22e404fb79482ab9765d9922db588d (patch) | |
| tree | 53d3071404f24fb771dd064137873b6d0df1f6b5 | |
| parent | 7298d1f079a139b2cf076c4852df9ca01adab7de (diff) | |
| parent | 7d5dda4dcaab3bc27e3f90a2f958cf066acc350e (diff) | |
Merge "Revert "Avoid throwing ISE in Canvas#restore underflow""
| -rw-r--r-- | core/jni/android_graphics_Canvas.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/core/jni/android_graphics_Canvas.cpp b/core/jni/android_graphics_Canvas.cpp index 49ee6c528f6c..4c08b4b056fe 100644 --- a/core/jni/android_graphics_Canvas.cpp +++ b/core/jni/android_graphics_Canvas.cpp @@ -89,7 +89,7 @@ static jint saveLayerAlpha(JNIEnv* env, jobject, jlong canvasHandle, jfloat l, j static void restore(JNIEnv* env, jobject, jlong canvasHandle) { Canvas* canvas = get_canvas(canvasHandle); if (canvas->getSaveCount() <= 1) { // cannot restore anymore - // fail silently on underflow, so as not to break existing apps that miscount + doThrowISE(env, "Underflow in restore - more restores than saves"); return; } canvas->restore(); @@ -98,7 +98,7 @@ static void restore(JNIEnv* env, jobject, jlong canvasHandle) { static void restoreToCount(JNIEnv* env, jobject, jlong canvasHandle, jint restoreCount) { Canvas* canvas = get_canvas(canvasHandle); if (restoreCount < 1 || restoreCount > canvas->getSaveCount()) { - // fail silently on underflow, so as not to break existing apps that miscount + doThrowIAE(env, "Underflow in restoreToCount - more restores than saves"); return; } canvas->restoreToCount(restoreCount); |