summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Yi Kong <yikong@google.com> 2024-06-07 02:45:43 +0000
committer Yi Kong <yikong@google.com> 2024-06-07 02:45:43 +0000
commitcad7d7fb4ca68b7bf6d7e73fa859497243f1ca4f (patch)
tree8512dd14624a9871029233ba5c3158d0c0ac874b
parentb6c0fa01335a176bf1cce986cfaadfc1b3667d53 (diff)
profcollect: Use postDelayed instead of starting a thread and sleep
Addresses follow-up comments from https://r.android.com/3115077. Change-Id: I6abaee35a4797c4e0d43daffaf2ab49d650cd9cc Test: presubmit Bug: 319394981
-rw-r--r--services/profcollect/src/com/android/server/profcollect/ProfcollectForwardingService.java19
1 files changed, 8 insertions, 11 deletions
diff --git a/services/profcollect/src/com/android/server/profcollect/ProfcollectForwardingService.java b/services/profcollect/src/com/android/server/profcollect/ProfcollectForwardingService.java
index c0259135132b..cd70ed23a824 100644
--- a/services/profcollect/src/com/android/server/profcollect/ProfcollectForwardingService.java
+++ b/services/profcollect/src/com/android/server/profcollect/ProfcollectForwardingService.java
@@ -323,16 +323,14 @@ public final class ProfcollectForwardingService extends SystemService {
"dex2oat_trace_freq", 25);
int randomNum = ThreadLocalRandom.current().nextInt(100);
if (randomNum < traceFrequency) {
- BackgroundThread.get().getThreadHandler().post(() -> {
+ // Dex2oat could take a while before it starts. Add a short delay before start tracing.
+ BackgroundThread.get().getThreadHandler().postDelayed(() -> {
try {
- // Dex2oat could take a while before it starts. Add a short delay before start
- // tracing.
- Thread.sleep(1000);
mIProfcollect.trace_once("dex2oat");
- } catch (RemoteException | InterruptedException e) {
+ } catch (RemoteException e) {
Log.e(LOG_TAG, "Failed to initiate trace: " + e.getMessage());
}
- });
+ }, 1000);
}
}
@@ -394,15 +392,14 @@ public final class ProfcollectForwardingService extends SystemService {
if (randomNum >= traceFrequency) {
return;
}
- BackgroundThread.get().getThreadHandler().post(() -> {
+ // Wait for 1s before starting tracing.
+ BackgroundThread.get().getThreadHandler().postDelayed(() -> {
try {
- // Wait for a short time before starting tracing.
- Thread.sleep(1000);
mIProfcollect.trace_once("camera");
- } catch (RemoteException | InterruptedException e) {
+ } catch (RemoteException e) {
Log.e(LOG_TAG, "Failed to initiate trace: " + e.getMessage());
}
- });
+ }, 1000);
}
}, null);
}