summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author TreeHugger Robot <treehugger-gerrit@google.com> 2020-06-26 00:17:13 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2020-06-26 00:17:13 +0000
commitc96085f111159308b16a538a42c10847e9fc339a (patch)
tree0a6e4c32a320ca44c6cdd702e58a44f086ed9591
parent1c1e1161171f375eaf01e28498a1d7638a77090c (diff)
parentb68025b80e426bd898ae844d23160b0729e4ccf3 (diff)
Merge "SoundEffectsHelper: Fix NPE when calling into SoundPool" into rvc-dev
-rw-r--r--services/core/java/com/android/server/audio/SoundEffectsHelper.java6
1 files changed, 4 insertions, 2 deletions
diff --git a/services/core/java/com/android/server/audio/SoundEffectsHelper.java b/services/core/java/com/android/server/audio/SoundEffectsHelper.java
index cf5bc8d88c73..6d29b0e0078c 100644
--- a/services/core/java/com/android/server/audio/SoundEffectsHelper.java
+++ b/services/core/java/com/android/server/audio/SoundEffectsHelper.java
@@ -247,7 +247,7 @@ class SoundEffectsHelper {
}
Resource res = mResources.get(mEffects[effect]);
- if (res.mSampleId != EFFECT_NOT_IN_SOUND_POOL && res.mLoaded) {
+ if (mSoundPool != null && res.mSampleId != EFFECT_NOT_IN_SOUND_POOL && res.mLoaded) {
mSoundPool.play(res.mSampleId, volFloat, volFloat, 0, 0, 1.0f);
} else {
MediaPlayer mediaPlayer = new MediaPlayer();
@@ -511,7 +511,9 @@ class SoundEffectsHelper {
}
void onComplete(boolean success) {
- mSoundPool.setOnLoadCompleteListener(null);
+ if (mSoundPool != null) {
+ mSoundPool.setOnLoadCompleteListener(null);
+ }
for (OnEffectsLoadCompleteHandler handler : mLoadCompleteHandlers) {
handler.run(success);
}