summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Kevin <kevhan@google.com> 2018-09-26 16:28:57 -0700
committer Kevin <kevhan@google.com> 2018-09-26 16:28:57 -0700
commitc87a66b1cc21a09b4a0f549df2a63ebcca3a2a0e (patch)
tree43f3ef5d42fb01682589f9894b58321f7d16d123
parentc3c71728cee2d4054a165e2e664302e6d99bab5e (diff)
Fix test failure in NonPhoneDependencyTest.java.
The recent change to NotificationGroupManager to use HeadsUpManager.isAlerting over the row causes a NPE to occasionally surface if NonPhoneDependencyTest runs long enough. When it sets up the listener, it eventually gets a callback that adds a notification and calls into NotificationGroupManager even though it hasn't had its dependencies properly set up. This CL fixes that by setting its HeadsUpManager to the mock. Test: ensure in all tests that NotificationGroupManager has its dependencies set when NotificationEntryManager adds a notification Fixes: 116495228 Change-Id: I7b82eedbf46fde5c8709dd03fdd36059041ef911
-rw-r--r--packages/SystemUI/tests/src/com/android/systemui/statusbar/NonPhoneDependencyTest.java5
1 files changed, 3 insertions, 2 deletions
diff --git a/packages/SystemUI/tests/src/com/android/systemui/statusbar/NonPhoneDependencyTest.java b/packages/SystemUI/tests/src/com/android/systemui/statusbar/NonPhoneDependencyTest.java
index 09c19319429b..da59450af4df 100644
--- a/packages/SystemUI/tests/src/com/android/systemui/statusbar/NonPhoneDependencyTest.java
+++ b/packages/SystemUI/tests/src/com/android/systemui/statusbar/NonPhoneDependencyTest.java
@@ -79,13 +79,14 @@ public class NonPhoneDependencyTest extends SysuiTestCase {
Dependency.get(NotificationLockscreenUserManager.class);
NotificationViewHierarchyManager viewHierarchyManager =
Dependency.get(NotificationViewHierarchyManager.class);
+ NotificationGroupManager groupManager = Dependency.get(NotificationGroupManager.class);
when(mPresenter.getNotificationLockscreenUserManager()).thenReturn(lockscreenUserManager);
- when(mPresenter.getGroupManager()).thenReturn(
- Dependency.get(NotificationGroupManager.class));
+ when(mPresenter.getGroupManager()).thenReturn(groupManager);
entryManager.setUpWithPresenter(mPresenter, mListContainer, mEntryManagerCallback,
mHeadsUpManager);
+ groupManager.setHeadsUpManager(mHeadsUpManager);
gutsManager.setUpWithPresenter(mPresenter, mListContainer, mCheckSaveListener,
mOnClickListener);
notificationLogger.setUpWithEntryManager(entryManager, mListContainer);