summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author TreeHugger Robot <treehugger-gerrit@google.com> 2022-10-06 04:20:51 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2022-10-06 04:20:51 +0000
commitc71eed077a24d70a143875cf7be8e32e1d39dbd5 (patch)
tree111e90fab35d5459927612952aba1e8b17bbc129
parent6370af8d0c65aaec826c77a166cb8ef1c0a369c4 (diff)
parente7d0682b9ec37a973930ed54abc52c9309f593f8 (diff)
Merge "Stop relying on IActivityManager#getCurrentUser() in IMMS"
-rw-r--r--services/core/java/com/android/server/inputmethod/InputMethodManagerService.java11
1 files changed, 4 insertions, 7 deletions
diff --git a/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java b/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java
index d479f573e22f..c567a891270c 100644
--- a/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java
+++ b/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java
@@ -295,6 +295,7 @@ public final class InputMethodManagerService extends IInputMethodManager.Stub
private final SparseBooleanArray mLoggedDeniedGetInputMethodWindowVisibleHeightForUid =
new SparseBooleanArray(0);
final WindowManagerInternal mWindowManagerInternal;
+ private final ActivityManagerInternal mActivityManagerInternal;
final PackageManagerInternal mPackageManagerInternal;
final InputManagerInternal mInputManagerInternal;
final ImePlatformCompatUtils mImePlatformCompatUtils;
@@ -1719,6 +1720,7 @@ public final class InputMethodManagerService extends IInputMethodManager.Stub
mIWindowManager = IWindowManager.Stub.asInterface(
ServiceManager.getService(Context.WINDOW_SERVICE));
mWindowManagerInternal = LocalServices.getService(WindowManagerInternal.class);
+ mActivityManagerInternal = LocalServices.getService(ActivityManagerInternal.class);
mPackageManagerInternal = LocalServices.getService(PackageManagerInternal.class);
mInputManagerInternal = LocalServices.getService(InputManagerInternal.class);
mImePlatformCompatUtils = new ImePlatformCompatUtils();
@@ -1751,12 +1753,7 @@ public final class InputMethodManagerService extends IInputMethodManager.Stub
mShowOngoingImeSwitcherForPhones = false;
mNotificationShown = false;
- int userId = 0;
- try {
- userId = ActivityManager.getService().getCurrentUser().id;
- } catch (RemoteException e) {
- Slog.w(TAG, "Couldn't get current user ID; guessing it's 0", e);
- }
+ final int userId = mActivityManagerInternal.getCurrentUserId();
mLastSwitchUserId = userId;
@@ -3311,7 +3308,7 @@ public final class InputMethodManagerService extends IInputMethodManager.Stub
// setSelectedInputMethodAndSubtypeLocked().
setSelectedMethodIdLocked(id);
- if (LocalServices.getService(ActivityManagerInternal.class).isSystemReady()) {
+ if (mActivityManagerInternal.isSystemReady()) {
Intent intent = new Intent(Intent.ACTION_INPUT_METHOD_CHANGED);
intent.addFlags(Intent.FLAG_RECEIVER_REPLACE_PENDING);
intent.putExtra("input_method_id", id);