summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Winson Chiu <chiuwinson@google.com> 2022-03-05 01:03:35 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2022-03-05 01:03:35 +0000
commitc4ab817595d338d3eadd329459e439c08e12502d (patch)
treeb35f0253d067af65477aee90c31e569957caba9d
parentd00d9c2bde2d2926d1fd075871e6d396bfe32b77 (diff)
parenta3a06ac2314bd23626b4172a861215702307e7fe (diff)
Merge changes from topics "presubmit-am-a8421206bd26452e95f6cad042b4b6bc", "presubmit-am-db10d76a65b5494fb2108722543f3813" into tm-dev
* changes: Rename ACTION_SHOW_SUGGESTSIONS TO ACTION_SHOW_TEXT_SUGGESTIONS Revert 'Adding definitions for AccessibilityAction directional swipes.'
-rw-r--r--core/api/current.txt12
-rw-r--r--core/java/android/view/accessibility/AccessibilityNodeInfo.java32
-rw-r--r--core/java/android/widget/TextView.java5
-rw-r--r--core/res/res/values/ids.xml16
-rw-r--r--core/res/res/values/public.xml10
5 files changed, 16 insertions, 59 deletions
diff --git a/core/api/current.txt b/core/api/current.txt
index f0b86df676e1..2cbc536edbbf 100644
--- a/core/api/current.txt
+++ b/core/api/current.txt
@@ -2094,12 +2094,8 @@ package android {
field public static final int accessibilityActionScrollUp = 16908344; // 0x1020038
field public static final int accessibilityActionSetProgress = 16908349; // 0x102003d
field public static final int accessibilityActionShowOnScreen = 16908342; // 0x1020036
- field public static final int accessibilityActionShowSuggestions;
+ field public static final int accessibilityActionShowTextSuggestions;
field public static final int accessibilityActionShowTooltip = 16908356; // 0x1020044
- field public static final int accessibilityActionSwipeDown;
- field public static final int accessibilityActionSwipeLeft;
- field public static final int accessibilityActionSwipeRight;
- field public static final int accessibilityActionSwipeUp;
field public static final int accessibilitySystemActionBack = 16908363; // 0x102004b
field public static final int accessibilitySystemActionHome = 16908364; // 0x102004c
field public static final int accessibilitySystemActionLockScreen = 16908370; // 0x1020052
@@ -51931,12 +51927,8 @@ package android.view.accessibility {
field public static final android.view.accessibility.AccessibilityNodeInfo.AccessibilityAction ACTION_SET_SELECTION;
field public static final android.view.accessibility.AccessibilityNodeInfo.AccessibilityAction ACTION_SET_TEXT;
field public static final android.view.accessibility.AccessibilityNodeInfo.AccessibilityAction ACTION_SHOW_ON_SCREEN;
- field @NonNull public static final android.view.accessibility.AccessibilityNodeInfo.AccessibilityAction ACTION_SHOW_SUGGESTIONS;
+ field @NonNull public static final android.view.accessibility.AccessibilityNodeInfo.AccessibilityAction ACTION_SHOW_TEXT_SUGGESTIONS;
field public static final android.view.accessibility.AccessibilityNodeInfo.AccessibilityAction ACTION_SHOW_TOOLTIP;
- field @NonNull public static final android.view.accessibility.AccessibilityNodeInfo.AccessibilityAction ACTION_SWIPE_DOWN;
- field @NonNull public static final android.view.accessibility.AccessibilityNodeInfo.AccessibilityAction ACTION_SWIPE_LEFT;
- field @NonNull public static final android.view.accessibility.AccessibilityNodeInfo.AccessibilityAction ACTION_SWIPE_RIGHT;
- field @NonNull public static final android.view.accessibility.AccessibilityNodeInfo.AccessibilityAction ACTION_SWIPE_UP;
field @NonNull public static final android.os.Parcelable.Creator<android.view.accessibility.AccessibilityNodeInfo.AccessibilityAction> CREATOR;
}
diff --git a/core/java/android/view/accessibility/AccessibilityNodeInfo.java b/core/java/android/view/accessibility/AccessibilityNodeInfo.java
index aeef76c3d048..0008aa64efa4 100644
--- a/core/java/android/view/accessibility/AccessibilityNodeInfo.java
+++ b/core/java/android/view/accessibility/AccessibilityNodeInfo.java
@@ -4487,8 +4487,8 @@ public class AccessibilityNodeInfo implements Parcelable {
case R.id.accessibilityActionDragDrop:
return "ACTION_DROP";
default: {
- if (action == R.id.accessibilityActionShowSuggestions) {
- return "ACTION_SHOW_SUGGESTIONS";
+ if (action == R.id.accessibilityActionShowTextSuggestions) {
+ return "ACTION_SHOW_TEXT_SUGGESTIONS";
}
return "ACTION_UNKNOWN";
}
@@ -5189,34 +5189,10 @@ public class AccessibilityNodeInfo implements Parcelable {
new AccessibilityAction(R.id.accessibilityActionDragCancel);
/**
- * Action to perform a left swipe.
- */
- @NonNull public static final AccessibilityAction ACTION_SWIPE_LEFT =
- new AccessibilityAction(R.id.accessibilityActionSwipeLeft);
-
- /**
- * Action to perform a right swipe.
- */
- @NonNull public static final AccessibilityAction ACTION_SWIPE_RIGHT =
- new AccessibilityAction(R.id.accessibilityActionSwipeRight);
-
- /**
- * Action to perform an up swipe.
- */
- @NonNull public static final AccessibilityAction ACTION_SWIPE_UP =
- new AccessibilityAction(R.id.accessibilityActionSwipeUp);
-
- /**
- * Action to perform a down swipe.
- */
- @NonNull public static final AccessibilityAction ACTION_SWIPE_DOWN =
- new AccessibilityAction(R.id.accessibilityActionSwipeDown);
-
- /**
* Action to show suggestions for editable text.
*/
- @NonNull public static final AccessibilityAction ACTION_SHOW_SUGGESTIONS =
- new AccessibilityAction(R.id.accessibilityActionShowSuggestions);
+ @NonNull public static final AccessibilityAction ACTION_SHOW_TEXT_SUGGESTIONS =
+ new AccessibilityAction(R.id.accessibilityActionShowTextSuggestions);
private final int mActionId;
private final CharSequence mLabel;
diff --git a/core/java/android/widget/TextView.java b/core/java/android/widget/TextView.java
index c207af53fab7..b076d399d44a 100644
--- a/core/java/android/widget/TextView.java
+++ b/core/java/android/widget/TextView.java
@@ -12313,7 +12313,8 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener
info.addAction(AccessibilityNodeInfo.ACTION_CUT);
}
if (canReplace()) {
- info.addAction(AccessibilityNodeInfo.AccessibilityAction.ACTION_SHOW_SUGGESTIONS);
+ info.addAction(
+ AccessibilityNodeInfo.AccessibilityAction.ACTION_SHOW_TEXT_SUGGESTIONS);
}
if (canShare()) {
info.addAction(new AccessibilityNodeInfo.AccessibilityAction(
@@ -12634,7 +12635,7 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener
default: {
// New ids have static blocks to assign values, so they can't be used in a case
// block.
- if (action == R.id.accessibilityActionShowSuggestions) {
+ if (action == R.id.accessibilityActionShowTextSuggestions) {
return isFocused() && canReplace() && onTextContextMenuItem(ID_REPLACE);
}
return super.performAccessibilityActionInternal(action, arguments);
diff --git a/core/res/res/values/ids.xml b/core/res/res/values/ids.xml
index 29eb0c0365b3..082acbe3443a 100644
--- a/core/res/res/values/ids.xml
+++ b/core/res/res/values/ids.xml
@@ -270,20 +270,8 @@
<!-- Accessibility action identifier for {@link android.view.accessibility.AccessibilityNodeInfo.AccessibilityAction#ACTION_DRAG_CANCEL}. -->
<item type="id" name="accessibilityActionDragCancel" />
- <!-- Accessibility action identifier for {@link android.view.accessibility.AccessibilityNodeInfo.AccessibilityAction#ACTION_SWIPE_LEFT}. -->
- <item type="id" name="accessibilityActionSwipeLeft" />
-
- <!-- Accessibility action identifier for {@link android.view.accessibility.AccessibilityNodeInfo.AccessibilityAction#ACTION_SWIPE_RIGHT}. -->
- <item type="id" name="accessibilityActionSwipeRight" />
-
- <!-- Accessibility action identifier for {@link android.view.accessibility.AccessibilityNodeInfo.AccessibilityAction#ACTION_SWIPE_UP}. -->
- <item type="id" name="accessibilityActionSwipeUp" />
-
- <!-- Accessibility action identifier for {@link android.view.accessibility.AccessibilityNodeInfo.AccessibilityAction#ACTION_SWIPE_DOWN}. -->
- <item type="id" name="accessibilityActionSwipeDown" />
-
- <!-- Accessibility action identifier for {@link android.view.accessibility.AccessibilityNodeInfo.AccessibilityAction#ACTION_SHOW_SUGGESTIONS}. -->
- <item type="id" name="accessibilityActionShowSuggestions" />
+ <!-- Accessibility action identifier for {@link android.view.accessibility.AccessibilityNodeInfo.AccessibilityAction#ACTION_SHOW_TEXT_SUGGESTIONS}. -->
+ <item type="id" name="accessibilityActionShowTextSuggestions" />
<!-- View tag for remote views to store the index of the next child when adding nested remote views dynamically. -->
<item type="id" name="remote_views_next_child" />
diff --git a/core/res/res/values/public.xml b/core/res/res/values/public.xml
index 3467e1b40470..aed1b0d04c8b 100644
--- a/core/res/res/values/public.xml
+++ b/core/res/res/values/public.xml
@@ -3284,11 +3284,11 @@
</staging-public-group>
<staging-public-group type="id" first-id="0x01de0000">
- <public name="accessibilityActionSwipeLeft" />
- <public name="accessibilityActionSwipeRight" />
- <public name="accessibilityActionSwipeUp" />
- <public name="accessibilityActionSwipeDown" />
- <public name="accessibilityActionShowSuggestions" />
+ <public name="removed_accessibilityActionSwipeLeft" />
+ <public name="removed_accessibilityActionSwipeRight" />
+ <public name="removed_accessibilityActionSwipeUp" />
+ <public name="removed_accessibilityActionSwipeDown" />
+ <public name="accessibilityActionShowTextSuggestions" />
<public name="inputExtractAction" />
<public name="inputExtractAccessories" />
</staging-public-group>