summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Amit Mahajan <amitmahajan@google.com> 2019-08-28 17:11:44 -0700
committer android-build-merger <android-build-merger@google.com> 2019-08-28 17:11:44 -0700
commitc0f522c3ec4e01127430e39de72422eab38de436 (patch)
tree2e59c36763593fc7e433c7c70f7375bd068fa813
parentf4d962c2429812ed0741a0d666e988fc96dd62cc (diff)
parent66460139d216e78826bf2964b75c5e71bafd34f1 (diff)
Merge "Fix invalid padding bits for 7-bit ASCII encoding" am: 2c8d3c56f2 am: c302ce55ab am: 1a9034d44e
am: 66460139d2 Change-Id: Idac3364a23d0e10b5b93097eddcbbeb7718755ec
-rw-r--r--telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java14
1 files changed, 7 insertions, 7 deletions
diff --git a/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java b/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
index 9e6f19f9243d..dab14369d79c 100644
--- a/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
+++ b/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
@@ -764,13 +764,13 @@ public final class BearerData {
" > " + SmsConstants.MAX_USER_DATA_BYTES + " bytes)");
}
- /*
- * TODO(cleanup): figure out what the right answer is WRT paddingBits field
- *
- * userData.paddingBits = (userData.payload.length * 8) - (userData.numFields * 7);
- * userData.paddingBits = 0; // XXX this seems better, but why?
- *
- */
+ if (bData.userData.msgEncoding == UserData.ENCODING_7BIT_ASCII) {
+ bData.userData.paddingBits =
+ (bData.userData.payload.length * 8) - (bData.userData.numFields * 7);
+ } else {
+ bData.userData.paddingBits = 0;
+ }
+
int dataBits = (bData.userData.payload.length * 8) - bData.userData.paddingBits;
int paramBits = dataBits + 13;
if ((bData.userData.msgEncoding == UserData.ENCODING_IS91_EXTENDED_PROTOCOL) ||