summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Fyodor Kupolov <fkupolov@google.com> 2017-03-30 19:12:44 +0000
committer android-build-merger <android-build-merger@google.com> 2017-03-30 19:12:44 +0000
commitbf01a9d14fa7620ccfc04a5db84d9cd8f03df906 (patch)
tree20bfaad8fa0fd20bd49ffc0ba7492a85f922a2e0
parentf44cb65679aada3b5975d8822cf938313ffbdda0 (diff)
parentb70a2225022751fbf93dbb2cd595673a48982bcb (diff)
Merge "Do not hold locks when calling getAccounts" into oc-dev am: 6a841cb88b
am: b70a222502 Change-Id: I8e4231b1ff62ddff7460f2b731bf1ffe7fca0849
-rw-r--r--services/core/java/com/android/server/accounts/AccountManagerService.java16
1 files changed, 5 insertions, 11 deletions
diff --git a/services/core/java/com/android/server/accounts/AccountManagerService.java b/services/core/java/com/android/server/accounts/AccountManagerService.java
index 0ccaf8e914b8..625e4a5d9b20 100644
--- a/services/core/java/com/android/server/accounts/AccountManagerService.java
+++ b/services/core/java/com/android/server/accounts/AccountManagerService.java
@@ -1597,17 +1597,11 @@ public class AccountManagerService
@Override
public void run() throws RemoteException {
// Confirm that the owner's account still exists before this step.
- UserAccounts owner = getUserAccounts(parentUserId);
- synchronized (owner.dbLock) {
- synchronized (owner.cacheLock) {
- for (Account acc : getAccounts(parentUserId,
- mContext.getOpPackageName())) {
- if (acc.equals(account)) {
- mAuthenticator.addAccountFromCredentials(
- this, account, accountCredentials);
- break;
- }
- }
+ for (Account acc : getAccounts(parentUserId, mContext.getOpPackageName())) {
+ if (acc.equals(account)) {
+ mAuthenticator.addAccountFromCredentials(
+ this, account, accountCredentials);
+ break;
}
}
}