summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Prabir Pradhan <prabirmsp@google.com> 2024-01-23 18:08:28 +0000
committer Prabir Pradhan <prabirmsp@google.com> 2024-01-23 18:08:28 +0000
commitbdf936984acca93aea3ef94fdbd42830a697ca58 (patch)
treee41c5dfdbde5f8436d73d6b9d5b36d0b7ce92736
parent37c1b992d923106d79f4b299b2661a5fde0892cc (diff)
PointerController: Simplify display info listener registration
Bug: 313033164 Test: Presubmit Change-Id: I71e4943d36e0e3b5b0c9eaaaef7c8d04a82ba90d
-rw-r--r--libs/input/PointerController.cpp4
-rw-r--r--libs/input/PointerController.h5
-rw-r--r--libs/input/tests/PointerController_test.cpp3
3 files changed, 5 insertions, 7 deletions
diff --git a/libs/input/PointerController.cpp b/libs/input/PointerController.cpp
index 1604ba2968db..f84107e8792c 100644
--- a/libs/input/PointerController.cpp
+++ b/libs/input/PointerController.cpp
@@ -115,7 +115,7 @@ PointerController::PointerController(const sp<PointerControllerPolicyInterface>&
std::vector<android::gui::DisplayInfo>{});
SurfaceComposerClient::getDefault()->addWindowInfosListener(listener,
&initialInfo);
- return initialInfo;
+ return initialInfo.second;
},
[](const sp<android::gui::WindowInfosListener>& listener) {
SurfaceComposerClient::getDefault()->removeWindowInfosListener(listener);
@@ -133,7 +133,7 @@ PointerController::PointerController(const sp<PointerControllerPolicyInterface>&
mUnregisterWindowInfosListener(std::move(unregisterListener)) {
std::scoped_lock lock(getLock());
mLocked.presentation = Presentation::SPOT;
- const auto& [_, initialDisplayInfos] = registerListener(mDisplayInfoListener);
+ const auto& initialDisplayInfos = registerListener(mDisplayInfoListener);
onDisplayInfosChangedLocked(initialDisplayInfos);
}
diff --git a/libs/input/PointerController.h b/libs/input/PointerController.h
index 8daa3a33dea4..6ee5707622ca 100644
--- a/libs/input/PointerController.h
+++ b/libs/input/PointerController.h
@@ -79,9 +79,8 @@ public:
std::string dump() override;
protected:
- using WindowListenerRegisterConsumer =
- std::function<std::pair<std::vector<gui::WindowInfo>, std::vector<gui::DisplayInfo>>(
- const sp<android::gui::WindowInfosListener>&)>;
+ using WindowListenerRegisterConsumer = std::function<std::vector<gui::DisplayInfo>(
+ const sp<android::gui::WindowInfosListener>&)>;
using WindowListenerUnregisterConsumer =
std::function<void(const sp<android::gui::WindowInfosListener>&)>;
diff --git a/libs/input/tests/PointerController_test.cpp b/libs/input/tests/PointerController_test.cpp
index 45b426bf5c5e..a1bb5b3f1cc4 100644
--- a/libs/input/tests/PointerController_test.cpp
+++ b/libs/input/tests/PointerController_test.cpp
@@ -161,8 +161,7 @@ public:
policy, looper, spriteController,
/*enabled=*/true,
[&registeredListener](const sp<android::gui::WindowInfosListener>& listener)
- -> std::pair<std::vector<gui::WindowInfo>,
- std::vector<gui::DisplayInfo>> {
+ -> std::vector<gui::DisplayInfo> {
// Register listener
registeredListener = listener;
return {};