diff options
| author | 2020-02-09 12:06:56 -0800 | |
|---|---|---|
| committer | 2020-02-10 20:36:51 -0800 | |
| commit | b9f28bc805e69cbb7943c1ef45d462f3d231372f (patch) | |
| tree | 80c61934ea5536ad63088d49ce3387662068bb6c | |
| parent | eb1ae5b6bc9748be5666c5ec04b83540046d66b2 (diff) | |
[WIFICOND] Rename to nl80211
per API council feedback.
Bug: 149105833
Bug: 148680192
Test: atest android.net.wifi
Test: atest com.android.server.wifi
Change-Id: I1d6bbd126ae0eb06068ff962573021fdec590735
| -rwxr-xr-x | api/system-current.txt | 34 | ||||
| -rw-r--r-- | api/system-lint-baseline.txt | 2 | ||||
| -rw-r--r-- | core/java/android/app/SystemServiceRegistry.java | 10 | ||||
| -rw-r--r-- | core/java/android/content/Context.java | 8 | ||||
| -rw-r--r-- | wifi/java/android/net/wifi/wificond/WifiNl80211Manager.java (renamed from wifi/java/android/net/wifi/wificond/WifiCondManager.java) | 19 | ||||
| -rw-r--r-- | wifi/tests/src/android/net/wifi/wificond/WifiNl80211ManagerTest.java (renamed from wifi/tests/src/android/net/wifi/wificond/WifiCondManagerTest.java) | 62 |
6 files changed, 69 insertions, 66 deletions
diff --git a/api/system-current.txt b/api/system-current.txt index a722db95fdd6..f29777ec1b38 100755 --- a/api/system-current.txt +++ b/api/system-current.txt @@ -1806,7 +1806,7 @@ package android.content { field public static final String TELEPHONY_REGISTRY_SERVICE = "telephony_registry"; field public static final String TETHERING_SERVICE = "tethering"; field public static final String VR_SERVICE = "vrmanager"; - field public static final String WIFI_COND_SERVICE = "wificond"; + field public static final String WIFI_NL80211_SERVICE = "wifinl80211"; field @Deprecated public static final String WIFI_RTT_SERVICE = "rttmanager"; field public static final String WIFI_SCANNING_SERVICE = "wifiscanner"; } @@ -8316,21 +8316,21 @@ package android.net.wifi.wificond { field @NonNull public static final android.os.Parcelable.Creator<android.net.wifi.wificond.RadioChainInfo> CREATOR; } - public class WifiCondManager { + public class WifiNl80211Manager { method public void abortScan(@NonNull String); method public void enableVerboseLogging(boolean); method @NonNull public int[] getChannelsMhzForBand(int); method @Nullable public android.net.wifi.wificond.DeviceWiphyCapabilities getDeviceWiphyCapabilities(@NonNull String); method @NonNull public java.util.List<android.net.wifi.wificond.NativeScanResult> getScanResults(@NonNull String, int); - method @Nullable public android.net.wifi.wificond.WifiCondManager.TxPacketCounters getTxPacketCounters(@NonNull String); - method @Nullable public static android.net.wifi.wificond.WifiCondManager.OemSecurityType parseOemSecurityTypeElement(int, int, @NonNull byte[]); - method public boolean registerApCallback(@NonNull String, @NonNull java.util.concurrent.Executor, @NonNull android.net.wifi.wificond.WifiCondManager.SoftApCallback); - method public void sendMgmtFrame(@NonNull String, @NonNull byte[], int, @NonNull java.util.concurrent.Executor, @NonNull android.net.wifi.wificond.WifiCondManager.SendMgmtFrameCallback); + method @Nullable public android.net.wifi.wificond.WifiNl80211Manager.TxPacketCounters getTxPacketCounters(@NonNull String); + method @Nullable public static android.net.wifi.wificond.WifiNl80211Manager.OemSecurityType parseOemSecurityTypeElement(int, int, @NonNull byte[]); + method public boolean registerApCallback(@NonNull String, @NonNull java.util.concurrent.Executor, @NonNull android.net.wifi.wificond.WifiNl80211Manager.SoftApCallback); + method public void sendMgmtFrame(@NonNull String, @NonNull byte[], int, @NonNull java.util.concurrent.Executor, @NonNull android.net.wifi.wificond.WifiNl80211Manager.SendMgmtFrameCallback); method public void setOnServiceDeadCallback(@NonNull Runnable); - method public boolean setupInterfaceForClientMode(@NonNull String, @NonNull java.util.concurrent.Executor, @NonNull android.net.wifi.wificond.WifiCondManager.ScanEventCallback, @NonNull android.net.wifi.wificond.WifiCondManager.ScanEventCallback); + method public boolean setupInterfaceForClientMode(@NonNull String, @NonNull java.util.concurrent.Executor, @NonNull android.net.wifi.wificond.WifiNl80211Manager.ScanEventCallback, @NonNull android.net.wifi.wificond.WifiNl80211Manager.ScanEventCallback); method public boolean setupInterfaceForSoftApMode(@NonNull String); - method @Nullable public android.net.wifi.wificond.WifiCondManager.SignalPollResult signalPoll(@NonNull String); - method public boolean startPnoScan(@NonNull String, @NonNull android.net.wifi.wificond.PnoSettings, @NonNull java.util.concurrent.Executor, @NonNull android.net.wifi.wificond.WifiCondManager.PnoScanRequestCallback); + method @Nullable public android.net.wifi.wificond.WifiNl80211Manager.SignalPollResult signalPoll(@NonNull String); + method public boolean startPnoScan(@NonNull String, @NonNull android.net.wifi.wificond.PnoSettings, @NonNull java.util.concurrent.Executor, @NonNull android.net.wifi.wificond.WifiNl80211Manager.PnoScanRequestCallback); method public boolean startScan(@NonNull String, int, @Nullable java.util.Set<java.lang.Integer>, @Nullable java.util.List<byte[]>); method public boolean stopPnoScan(@NonNull String); method public boolean tearDownClientInterface(@NonNull String); @@ -8345,43 +8345,43 @@ package android.net.wifi.wificond { field public static final int SEND_MGMT_FRAME_ERROR_UNKNOWN = 1; // 0x1 } - public static class WifiCondManager.OemSecurityType { - ctor public WifiCondManager.OemSecurityType(int, @NonNull java.util.List<java.lang.Integer>, @NonNull java.util.List<java.lang.Integer>, int); + public static class WifiNl80211Manager.OemSecurityType { + ctor public WifiNl80211Manager.OemSecurityType(int, @NonNull java.util.List<java.lang.Integer>, @NonNull java.util.List<java.lang.Integer>, int); field public final int groupCipher; field @NonNull public final java.util.List<java.lang.Integer> keyManagement; field @NonNull public final java.util.List<java.lang.Integer> pairwiseCipher; field public final int protocol; } - public static interface WifiCondManager.PnoScanRequestCallback { + public static interface WifiNl80211Manager.PnoScanRequestCallback { method public void onPnoRequestFailed(); method public void onPnoRequestSucceeded(); } - public static interface WifiCondManager.ScanEventCallback { + public static interface WifiNl80211Manager.ScanEventCallback { method public void onScanFailed(); method public void onScanResultReady(); } - public static interface WifiCondManager.SendMgmtFrameCallback { + public static interface WifiNl80211Manager.SendMgmtFrameCallback { method public void onAck(int); method public void onFailure(int); } - public static class WifiCondManager.SignalPollResult { + public static class WifiNl80211Manager.SignalPollResult { field public final int associationFrequencyMHz; field public final int currentRssiDbm; field public final int rxBitrateMbps; field public final int txBitrateMbps; } - public static interface WifiCondManager.SoftApCallback { + public static interface WifiNl80211Manager.SoftApCallback { method public void onConnectedClientsChanged(@NonNull android.net.wifi.wificond.NativeWifiClient, boolean); method public void onFailure(); method public void onSoftApChannelSwitched(int, int); } - public static class WifiCondManager.TxPacketCounters { + public static class WifiNl80211Manager.TxPacketCounters { field public final int txPacketFailed; field public final int txPacketSucceeded; } diff --git a/api/system-lint-baseline.txt b/api/system-lint-baseline.txt index 0caee6bebbda..dfb0d7460ca4 100644 --- a/api/system-lint-baseline.txt +++ b/api/system-lint-baseline.txt @@ -234,7 +234,7 @@ OnNameExpected: android.content.ContentProvider#checkUriPermission(android.net.U If implemented by developer, should follow the on<Something> style; otherwise consider marking final -PairedRegistration: android.net.wifi.wificond.WifiCondManager#registerApCallback(String, java.util.concurrent.Executor, android.net.wifi.wificond.WifiCondManager.SoftApCallback): +PairedRegistration: android.net.wifi.wificond.WifiNl80211Manager#registerApCallback(String, java.util.concurrent.Executor, android.net.wifi.wificond.WifiNl80211Manager.SoftApCallback): diff --git a/core/java/android/app/SystemServiceRegistry.java b/core/java/android/app/SystemServiceRegistry.java index 50b9d6b47e02..6cfd9446c8bc 100644 --- a/core/java/android/app/SystemServiceRegistry.java +++ b/core/java/android/app/SystemServiceRegistry.java @@ -130,7 +130,7 @@ import android.net.lowpan.LowpanManager; import android.net.nsd.INsdManager; import android.net.nsd.NsdManager; import android.net.wifi.WifiFrameworkInitializer; -import android.net.wifi.wificond.WifiCondManager; +import android.net.wifi.wificond.WifiNl80211Manager; import android.nfc.NfcManager; import android.os.BatteryManager; import android.os.BatteryStats; @@ -759,11 +759,11 @@ public final class SystemServiceRegistry { return new EthernetManager(ctx.getOuterContext(), service); }}); - registerService(Context.WIFI_COND_SERVICE, WifiCondManager.class, - new CachedServiceFetcher<WifiCondManager>() { + registerService(Context.WIFI_NL80211_SERVICE, WifiNl80211Manager.class, + new CachedServiceFetcher<WifiNl80211Manager>() { @Override - public WifiCondManager createService(ContextImpl ctx) { - return new WifiCondManager(ctx.getOuterContext()); + public WifiNl80211Manager createService(ContextImpl ctx) { + return new WifiNl80211Manager(ctx.getOuterContext()); } }); diff --git a/core/java/android/content/Context.java b/core/java/android/content/Context.java index 249e58244870..f0f9bc890a8c 100644 --- a/core/java/android/content/Context.java +++ b/core/java/android/content/Context.java @@ -4063,16 +4063,16 @@ public abstract class Context { /** * Use with {@link #getSystemService(String)} to retrieve a - * {@link android.net.wifi.WifiCondManager} for handling management of the Wi-Fi control - * daemon. + * {@link android.net.wifi.wificond.WifiNl80211Manager} for handling management of the + * Wi-Fi nl802.11 daemon (wificond). * * @see #getSystemService(String) - * @see android.net.wifi.WifiCondManager + * @see android.net.wifi.wificond.WifiNl80211Manager * @hide */ @SystemApi @SuppressLint("ServiceName") - public static final String WIFI_COND_SERVICE = "wificond"; + public static final String WIFI_NL80211_SERVICE = "wifinl80211"; /** * Use with {@link #getSystemService(String)} to retrieve a {@link diff --git a/wifi/java/android/net/wifi/wificond/WifiCondManager.java b/wifi/java/android/net/wifi/wificond/WifiNl80211Manager.java index 61f18e0b7191..89f642fdbb66 100644 --- a/wifi/java/android/net/wifi/wificond/WifiCondManager.java +++ b/wifi/java/android/net/wifi/wificond/WifiNl80211Manager.java @@ -49,15 +49,16 @@ import java.util.concurrent.Executor; import java.util.concurrent.atomic.AtomicBoolean; /** - * This class encapsulates the interface the wificond daemon presents to the Wi-Fi framework. The + * This class encapsulates the interface the wificond daemon presents to the Wi-Fi framework - used + * to encapsulate the Wi-Fi 80211nl management interface. The * interface is only for use by the Wi-Fi framework and access is protected by SELinux permissions. * * @hide */ @SystemApi -@SystemService(Context.WIFI_COND_SERVICE) -public class WifiCondManager { - private static final String TAG = "WifiCondManager"; +@SystemService(Context.WIFI_NL80211_SERVICE) +public class WifiNl80211Manager { + private static final String TAG = "WifiNl80211Manager"; private boolean mVerboseLoggingEnabled = false; /** @@ -316,14 +317,14 @@ public class WifiCondManager { public static final int SEND_MGMT_FRAME_ERROR_ALREADY_STARTED = 5; /** @hide */ - public WifiCondManager(Context context) { + public WifiNl80211Manager(Context context) { mAlarmManager = context.getSystemService(AlarmManager.class); mEventHandler = new Handler(context.getMainLooper()); } /** @hide */ @VisibleForTesting - public WifiCondManager(Context context, IWificond wificond) { + public WifiNl80211Manager(Context context, IWificond wificond) { this(context); mWificond = wificond; } @@ -485,7 +486,7 @@ public class WifiCondManager { } /** - * Enable or disable verbose logging of the WifiCondManager module. + * Enable or disable verbose logging of the WifiNl80211Manager module. * @param enable True to enable verbose logging. False to disable verbose logging. */ public void enableVerboseLogging(boolean enable) { @@ -493,7 +494,7 @@ public class WifiCondManager { } /** - * Register a death notification for the WifiCondManager which acts as a proxy for the + * Register a death notification for the WifiNl80211Manager which acts as a proxy for the * wificond daemon (i.e. the death listener will be called when and if the wificond daemon * dies). * @@ -518,7 +519,7 @@ public class WifiCondManager { // We already have a wificond handle. return true; } - IBinder binder = ServiceManager.getService(Context.WIFI_COND_SERVICE); + IBinder binder = ServiceManager.getService(Context.WIFI_NL80211_SERVICE); mWificond = IWificond.Stub.asInterface(binder); if (mWificond == null) { Log.e(TAG, "Failed to get reference to wificond"); diff --git a/wifi/tests/src/android/net/wifi/wificond/WifiCondManagerTest.java b/wifi/tests/src/android/net/wifi/wificond/WifiNl80211ManagerTest.java index b745a341b459..a8184068ff5a 100644 --- a/wifi/tests/src/android/net/wifi/wificond/WifiCondManagerTest.java +++ b/wifi/tests/src/android/net/wifi/wificond/WifiNl80211ManagerTest.java @@ -71,10 +71,10 @@ import java.util.List; import java.util.Set; /** - * Unit tests for {@link android.net.wifi.WifiCondManager}. + * Unit tests for {@link android.net.wifi.wificond.WifiNl80211Manager}. */ @SmallTest -public class WifiCondManagerTest { +public class WifiNl80211ManagerTest { @Mock private IWificond mWificond; @Mock @@ -86,21 +86,21 @@ public class WifiCondManagerTest { @Mock private IApInterface mApInterface; @Mock - private WifiCondManager.SoftApCallback mSoftApListener; + private WifiNl80211Manager.SoftApCallback mSoftApListener; @Mock - private WifiCondManager.SendMgmtFrameCallback mSendMgmtFrameCallback; + private WifiNl80211Manager.SendMgmtFrameCallback mSendMgmtFrameCallback; @Mock - private WifiCondManager.ScanEventCallback mNormalScanCallback; + private WifiNl80211Manager.ScanEventCallback mNormalScanCallback; @Mock - private WifiCondManager.ScanEventCallback mPnoScanCallback; + private WifiNl80211Manager.ScanEventCallback mPnoScanCallback; @Mock - private WifiCondManager.PnoScanRequestCallback mPnoScanRequestCallback; + private WifiNl80211Manager.PnoScanRequestCallback mPnoScanRequestCallback; @Mock private Context mContext; private TestLooper mLooper; private TestAlarmManager mTestAlarmManager; private AlarmManager mAlarmManager; - private WifiCondManager mWificondControl; + private WifiNl80211Manager mWificondControl; private static final String TEST_INTERFACE_NAME = "test_wlan_if"; private static final String TEST_INTERFACE_NAME1 = "test_wlan_if1"; private static final String TEST_INVALID_INTERFACE_NAME = "asdf"; @@ -180,7 +180,7 @@ public class WifiCondManagerTest { when(mWificond.tearDownApInterface(any())).thenReturn(true); when(mClientInterface.getWifiScannerImpl()).thenReturn(mWifiScannerImpl); when(mClientInterface.getInterfaceName()).thenReturn(TEST_INTERFACE_NAME); - mWificondControl = new WifiCondManager(mContext, mWificond); + mWificondControl = new WifiNl80211Manager(mContext, mWificond); assertEquals(true, mWificondControl.setupInterfaceForClientMode(TEST_INTERFACE_NAME, Runnable::run, mNormalScanCallback, mPnoScanCallback)); @@ -492,7 +492,7 @@ public class WifiCondManagerTest { // getScanResults should fail. assertEquals(0, mWificondControl.getScanResults(TEST_INTERFACE_NAME, - WifiCondManager.SCAN_TYPE_SINGLE_SCAN).size()); + WifiNl80211Manager.SCAN_TYPE_SINGLE_SCAN).size()); } /** @@ -786,10 +786,10 @@ public class WifiCondManagerTest { */ @Test public void testSendMgmtFrameCalledTwiceBeforeFinished() throws Exception { - WifiCondManager.SendMgmtFrameCallback cb1 = mock( - WifiCondManager.SendMgmtFrameCallback.class); - WifiCondManager.SendMgmtFrameCallback cb2 = mock( - WifiCondManager.SendMgmtFrameCallback.class); + WifiNl80211Manager.SendMgmtFrameCallback cb1 = mock( + WifiNl80211Manager.SendMgmtFrameCallback.class); + WifiNl80211Manager.SendMgmtFrameCallback cb2 = mock( + WifiNl80211Manager.SendMgmtFrameCallback.class); mWificondControl.sendMgmtFrame(TEST_INTERFACE_NAME, TEST_PROBE_FRAME, TEST_MCS_RATE, Runnable::run, cb1); @@ -800,7 +800,7 @@ public class WifiCondManagerTest { mWificondControl.sendMgmtFrame(TEST_INTERFACE_NAME, TEST_PROBE_FRAME, TEST_MCS_RATE, Runnable::run, cb2); - verify(cb2).onFailure(WifiCondManager.SEND_MGMT_FRAME_ERROR_ALREADY_STARTED); + verify(cb2).onFailure(WifiNl80211Manager.SEND_MGMT_FRAME_ERROR_ALREADY_STARTED); // verify SendMgmtFrame() still was only called once i.e. not called again verify(mClientInterface, times(1)) .SendMgmtFrame(any(), any(), anyInt()); @@ -811,8 +811,8 @@ public class WifiCondManagerTest { */ @Test public void testSendMgmtFrameThrowsException() throws Exception { - WifiCondManager.SendMgmtFrameCallback cb = mock( - WifiCondManager.SendMgmtFrameCallback.class); + WifiNl80211Manager.SendMgmtFrameCallback cb = mock( + WifiNl80211Manager.SendMgmtFrameCallback.class); final ArgumentCaptor<ISendMgmtFrameEvent> sendMgmtFrameEventCaptor = ArgumentCaptor.forClass(ISendMgmtFrameEvent.class); @@ -834,7 +834,7 @@ public class WifiCondManagerTest { verify(mAlarmManager).cancel(eq(alarmListenerCaptor.getValue())); sendMgmtFrameEventCaptor.getValue().OnFailure( - WifiCondManager.SEND_MGMT_FRAME_ERROR_UNKNOWN); + WifiNl80211Manager.SEND_MGMT_FRAME_ERROR_UNKNOWN); mLooper.dispatchAll(); handlerCaptor.getValue().post(() -> alarmListenerCaptor.getValue().onAlarm()); @@ -848,8 +848,8 @@ public class WifiCondManagerTest { */ @Test public void testSendMgmtFrameSuccess() throws Exception { - WifiCondManager.SendMgmtFrameCallback cb = mock( - WifiCondManager.SendMgmtFrameCallback.class); + WifiNl80211Manager.SendMgmtFrameCallback cb = mock( + WifiNl80211Manager.SendMgmtFrameCallback.class); final ArgumentCaptor<ISendMgmtFrameEvent> sendMgmtFrameEventCaptor = ArgumentCaptor.forClass(ISendMgmtFrameEvent.class); @@ -882,8 +882,8 @@ public class WifiCondManagerTest { */ @Test public void testSendMgmtFrameFailure() throws Exception { - WifiCondManager.SendMgmtFrameCallback cb = mock( - WifiCondManager.SendMgmtFrameCallback.class); + WifiNl80211Manager.SendMgmtFrameCallback cb = mock( + WifiNl80211Manager.SendMgmtFrameCallback.class); final ArgumentCaptor<ISendMgmtFrameEvent> sendMgmtFrameEventCaptor = ArgumentCaptor.forClass(ISendMgmtFrameEvent.class); @@ -898,10 +898,10 @@ public class WifiCondManagerTest { Runnable::run, cb); sendMgmtFrameEventCaptor.getValue().OnFailure( - WifiCondManager.SEND_MGMT_FRAME_ERROR_UNKNOWN); + WifiNl80211Manager.SEND_MGMT_FRAME_ERROR_UNKNOWN); mLooper.dispatchAll(); verify(cb, never()).onAck(anyInt()); - verify(cb).onFailure(WifiCondManager.SEND_MGMT_FRAME_ERROR_UNKNOWN); + verify(cb).onFailure(WifiNl80211Manager.SEND_MGMT_FRAME_ERROR_UNKNOWN); verify(mAlarmManager).cancel(eq(alarmListenerCaptor.getValue())); // verify that even if timeout is triggered afterwards, SendMgmtFrameCallback is not @@ -917,8 +917,8 @@ public class WifiCondManagerTest { */ @Test public void testSendMgmtFrameTimeout() throws Exception { - WifiCondManager.SendMgmtFrameCallback cb = mock( - WifiCondManager.SendMgmtFrameCallback.class); + WifiNl80211Manager.SendMgmtFrameCallback cb = mock( + WifiNl80211Manager.SendMgmtFrameCallback.class); final ArgumentCaptor<ISendMgmtFrameEvent> sendMgmtFrameEventCaptor = ArgumentCaptor.forClass(ISendMgmtFrameEvent.class); @@ -935,7 +935,7 @@ public class WifiCondManagerTest { handlerCaptor.getValue().post(() -> alarmListenerCaptor.getValue().onAlarm()); mLooper.dispatchAll(); verify(cb, never()).onAck(anyInt()); - verify(cb).onFailure(WifiCondManager.SEND_MGMT_FRAME_ERROR_TIMEOUT); + verify(cb).onFailure(WifiNl80211Manager.SEND_MGMT_FRAME_ERROR_TIMEOUT); // verify that even if onAck() callback is triggered after timeout, // SendMgmtFrameCallback is not triggered again @@ -1006,7 +1006,8 @@ public class WifiCondManagerTest { sendMgmtFrameEventCaptor.getValue().OnAck(TEST_SEND_MGMT_FRAME_ELAPSED_TIME_MS); mLooper.dispatchAll(); verify(mSendMgmtFrameCallback, never()).onAck(anyInt()); - verify(mSendMgmtFrameCallback).onFailure(WifiCondManager.SEND_MGMT_FRAME_ERROR_TIMEOUT); + verify(mSendMgmtFrameCallback).onFailure( + WifiNl80211Manager.SEND_MGMT_FRAME_ERROR_TIMEOUT); } /** @@ -1032,9 +1033,10 @@ public class WifiCondManagerTest { handlerCaptor.getValue().post(() -> alarmListenerCaptor.getValue().onAlarm()); // OnFailure posts to the handler sendMgmtFrameEventCaptor.getValue().OnFailure( - WifiCondManager.SEND_MGMT_FRAME_ERROR_UNKNOWN); + WifiNl80211Manager.SEND_MGMT_FRAME_ERROR_UNKNOWN); mLooper.dispatchAll(); - verify(mSendMgmtFrameCallback).onFailure(WifiCondManager.SEND_MGMT_FRAME_ERROR_TIMEOUT); + verify(mSendMgmtFrameCallback).onFailure( + WifiNl80211Manager.SEND_MGMT_FRAME_ERROR_TIMEOUT); } /** |