diff options
| author | 2024-07-18 14:12:57 +0800 | |
|---|---|---|
| committer | 2024-07-18 10:15:20 +0000 | |
| commit | b980fda58aabd708d2ebff4a5808524c749bdafa (patch) | |
| tree | 2cfdd109bf1a6410cf3c76515f3ad832ff1a1d11 | |
| parent | b9aa61dd0478bd8a1a846ea2df3351dac3947d8c (diff) | |
[Audiosharing] Use @Binds because the generated impl likely to be more efficient
Test: atest
Bug: 336716411
Flag: com.android.settingslib.flags.volume_dialog_audio_sharing_fix
Change-Id: I678e0a390b4678f722896d85ecc7a2cccf18ea32
2 files changed, 4 insertions, 9 deletions
diff --git a/packages/SystemUI/src/com/android/systemui/volume/dagger/AudioSharingEmptyImplModule.kt b/packages/SystemUI/src/com/android/systemui/volume/dagger/AudioSharingEmptyImplModule.kt index 29040923a2cc..cf80263b4d14 100644 --- a/packages/SystemUI/src/com/android/systemui/volume/dagger/AudioSharingEmptyImplModule.kt +++ b/packages/SystemUI/src/com/android/systemui/volume/dagger/AudioSharingEmptyImplModule.kt @@ -16,20 +16,15 @@ package com.android.systemui.volume.dagger -import com.android.systemui.dagger.SysUISingleton import com.android.systemui.volume.domain.interactor.AudioSharingInteractor import com.android.systemui.volume.domain.interactor.AudioSharingInteractorEmptyImpl +import dagger.Binds import dagger.Module -import dagger.Provides /** Dagger module for empty audio sharing impl for unnecessary volume overlay */ @Module interface AudioSharingEmptyImplModule { - companion object { - @Provides - @SysUISingleton - fun provideAudioSharingInteractor(): AudioSharingInteractor = - AudioSharingInteractorEmptyImpl() - } + @Binds + fun bindsAudioSharingInteractor(impl: AudioSharingInteractorEmptyImpl): AudioSharingInteractor } diff --git a/packages/SystemUI/src/com/android/systemui/volume/domain/interactor/AudioSharingInteractor.kt b/packages/SystemUI/src/com/android/systemui/volume/domain/interactor/AudioSharingInteractor.kt index 4d29788edf68..aba3015a6b7d 100644 --- a/packages/SystemUI/src/com/android/systemui/volume/domain/interactor/AudioSharingInteractor.kt +++ b/packages/SystemUI/src/com/android/systemui/volume/domain/interactor/AudioSharingInteractor.kt @@ -77,7 +77,7 @@ constructor( } @SysUISingleton -class AudioSharingInteractorEmptyImpl : AudioSharingInteractor { +class AudioSharingInteractorEmptyImpl @Inject constructor() : AudioSharingInteractor { override val volume: Flow<Int?> = emptyFlow() override val volumeMin: Int = EMPTY_VOLUME override val volumeMax: Int = EMPTY_VOLUME |