diff options
| author | 2020-02-18 10:12:42 -0500 | |
|---|---|---|
| committer | 2020-02-18 10:12:42 -0500 | |
| commit | b65171956c846031517c709ec0726c99a2bc5962 (patch) | |
| tree | 3089bc71a8c519b902a8e81a9f66e7b7511b52bb | |
| parent | 6fb74aeefcf8c9298d165ff200ba6a1d5dec8f89 (diff) | |
Update GraphicsStats proto definition
Follow ProtoBestPractices and comments suggested by cl/295218381.
Changing proto definition, should be fine, because these are
fields added after the last Android release.
Move PipelineType enum inside GraphicsStats and add a default
UNKNOWN state.
Rename start_millis and end_millis in GraphicsStats atom.
Fields in GraphicsStatsProto cannot be renamed as these were
part of previous Android releases.
Test: Ran "adb shell cmd stats pull-source 10068"
Test: Ran "statsd_testdrive 10068" and it looks OK
Bug: 149646555
Change-Id: Idc326eb2a7eb9ff0be39026e6fec544491b7d8a6
| -rw-r--r-- | cmds/statsd/src/atoms.proto | 19 | ||||
| -rw-r--r-- | core/proto/android/service/graphicsstats.proto | 5 | ||||
| -rw-r--r-- | libs/hwui/protos/graphicsstats.proto | 5 |
3 files changed, 15 insertions, 14 deletions
diff --git a/cmds/statsd/src/atoms.proto b/cmds/statsd/src/atoms.proto index 23a4437910f7..f215d7745b7a 100644 --- a/cmds/statsd/src/atoms.proto +++ b/cmds/statsd/src/atoms.proto @@ -8204,14 +8204,6 @@ message DangerousPermissionStateSampled { } /** - * HWUI renders pipeline type: GL (0) or Vulkan (1). - */ -enum PipelineType { - GL = 0; - VULKAN = 1; -} - -/** * HWUI stats for a given app. */ message GraphicsStats { @@ -8224,9 +8216,16 @@ message GraphicsStats { // The start & end timestamps in UTC as // milliseconds since January 1, 1970 // Compatible with java.util.Date#setTime() - optional int64 stats_start = 3; + optional int64 start_millis = 3; - optional int64 stats_end = 4; + optional int64 end_millis = 4; + + // HWUI renders pipeline type: GL (1) or Vulkan (2). + enum PipelineType { + UNKNOWN = 0; + GL = 1; + VULKAN = 2; + } // HWUI renders pipeline type: GL or Vulkan. optional PipelineType pipeline = 5; diff --git a/core/proto/android/service/graphicsstats.proto b/core/proto/android/service/graphicsstats.proto index 2de5b7fd45f6..bb654f05b02d 100644 --- a/core/proto/android/service/graphicsstats.proto +++ b/core/proto/android/service/graphicsstats.proto @@ -33,8 +33,9 @@ message GraphicsStatsServiceDumpProto { message GraphicsStatsProto { enum PipelineType { - GL = 0; - VULKAN = 1; + UNKNOWN = 0; + GL = 1; + VULKAN = 2; } option (android.msg_privacy).dest = DEST_AUTOMATIC; diff --git a/libs/hwui/protos/graphicsstats.proto b/libs/hwui/protos/graphicsstats.proto index dd5676c9c961..745393ce1a3d 100644 --- a/libs/hwui/protos/graphicsstats.proto +++ b/libs/hwui/protos/graphicsstats.proto @@ -30,8 +30,9 @@ message GraphicsStatsServiceDumpProto { message GraphicsStatsProto { enum PipelineType { - GL = 0; - VULKAN = 1; + UNKNOWN = 0; + GL = 1; + VULKAN = 2; } // The package name of the app |