summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author TreeHugger Robot <treehugger-gerrit@google.com> 2021-03-19 15:35:08 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2021-03-19 15:35:08 +0000
commitb61ef5342c3c0b9b22709a25a8b69f245d010d07 (patch)
treeba3e9d426b6338ef634536dc730e680bed081059
parent177d8e36f546cfed613960aadccd93298d63be49 (diff)
parent1bb3f75b0547cf992a39cef3f4fe9b6a6d74eeb3 (diff)
Merge "Remove reference of getActiveLinkproperties" into sc-dev
-rw-r--r--services/core/java/com/android/server/VpnManagerService.java5
1 files changed, 4 insertions, 1 deletions
diff --git a/services/core/java/com/android/server/VpnManagerService.java b/services/core/java/com/android/server/VpnManagerService.java
index 56aabc208027..d756c1ffd00f 100644
--- a/services/core/java/com/android/server/VpnManagerService.java
+++ b/services/core/java/com/android/server/VpnManagerService.java
@@ -352,7 +352,10 @@ public class VpnManagerService extends IVpnManager.Stub {
@Override
public void startLegacyVpn(VpnProfile profile) {
int user = UserHandle.getUserId(mDeps.getCallingUid());
- final LinkProperties egress = mCm.getActiveLinkProperties();
+ // Note that if the caller is not system (uid >= Process.FIRST_APPLICATION_UID),
+ // the code might not work well since getActiveNetwork might return null if the uid is
+ // blocked by NetworkPolicyManagerService.
+ final LinkProperties egress = mCm.getLinkProperties(mCm.getActiveNetwork());
if (egress == null) {
throw new IllegalStateException("Missing active network connection");
}