diff options
| author | 2025-02-12 11:55:17 -0800 | |
|---|---|---|
| committer | 2025-02-12 11:55:17 -0800 | |
| commit | b3a7a167b41836072dbedfa870d6db10b76d5bec (patch) | |
| tree | 76bd01e29b96a0866fb093ca7c112ab1beb86c24 | |
| parent | 1012c5fd248136ee05d7b76d9df7ee672dd3853c (diff) | |
| parent | e31d5f3f482c2c4778e6bf318a25a9742aa43075 (diff) | |
Merge "[RON] Fix LargeIcon alignment for RONs" into main
4 files changed, 54 insertions, 8 deletions
diff --git a/core/res/res/layout/notification_2025_template_header.xml b/core/res/res/layout/notification_2025_template_header.xml index 72b3798e0780..5aae67802af9 100644 --- a/core/res/res/layout/notification_2025_template_header.xml +++ b/core/res/res/layout/notification_2025_template_header.xml @@ -59,7 +59,7 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_alignParentStart="true" - android:layout_toStartOf="@id/expand_button" + android:layout_toStartOf="@id/expand_button_container" android:layout_alignWithParentIfMissing="true" android:layout_marginVertical="@dimen/notification_2025_margin" android:clipChildren="false" @@ -81,12 +81,30 @@ android:focusable="false" /> - <include layout="@layout/notification_2025_expand_button" + + <LinearLayout + android:id="@+id/expand_button_container" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:layout_gravity="top|end" - android:layout_alignParentEnd="true" /> + android:layout_alignParentEnd="true" + android:orientation="vertical" + > + <FrameLayout + android:id="@+id/expand_button_spacer" + android:layout_width="@dimen/notification_2025_expand_button_pill_width" + android:layout_height="@dimen/notification_2025_expand_button_pill_height" + android:layout_centerVertical="true" + android:layout_alignParentEnd="true" + android:layout_margin="@dimen/notification_2025_margin" + android:visibility="gone" /> + + <include layout="@layout/notification_2025_expand_button" + android:layout_width="wrap_content" + android:layout_height="wrap_content" + android:layout_gravity="top|end" + android:layout_alignParentEnd="true" /> + </LinearLayout> <include layout="@layout/notification_close_button" android:id="@+id/close_button" android:layout_width="@dimen/notification_close_button_size" diff --git a/core/res/res/layout/notification_template_header.xml b/core/res/res/layout/notification_template_header.xml index 57959361bd48..b7fd737a4e39 100644 --- a/core/res/res/layout/notification_template_header.xml +++ b/core/res/res/layout/notification_template_header.xml @@ -62,7 +62,7 @@ android:layout_height="match_parent" android:layout_alignParentStart="true" android:layout_centerVertical="true" - android:layout_toStartOf="@id/expand_button" + android:layout_toStartOf="@id/expand_button_container" android:layout_alignWithParentIfMissing="true" android:clipChildren="false" android:gravity="center_vertical" @@ -83,12 +83,28 @@ android:focusable="false" /> - <include layout="@layout/notification_expand_button" + <LinearLayout + android:id="@+id/expand_button_container" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:layout_centerVertical="true" - android:layout_alignParentEnd="true" /> + android:layout_alignParentEnd="true" + android:orientation="vertical" + > + <FrameLayout + android:id="@+id/expand_button_spacer" + android:layout_width="@dimen/notification_expand_button_pill_height" + android:layout_height="@dimen/notification_header_height" + android:layout_centerVertical="true" + android:layout_alignParentEnd="true" + android:layout_marginHorizontal="16dp" + android:visibility="gone" /> + <include layout="@layout/notification_expand_button" + android:layout_width="wrap_content" + android:layout_height="wrap_content" + android:layout_centerVertical="true" + android:layout_alignParentEnd="true" /> + </LinearLayout> <include layout="@layout/notification_close_button" android:id="@+id/close_button" android:layout_width="@dimen/notification_close_button_size" diff --git a/core/res/res/values/symbols.xml b/core/res/res/values/symbols.xml index da6fb3b58f21..63db28683b2b 100644 --- a/core/res/res/values/symbols.xml +++ b/core/res/res/values/symbols.xml @@ -3235,6 +3235,8 @@ <java-symbol type="id" name="header_text" /> <java-symbol type="id" name="header_text_secondary" /> <java-symbol type="id" name="expand_button" /> + <java-symbol type="id" name="expand_button_spacer" /> + <java-symbol type="id" name="expand_button_container" /> <java-symbol type="id" name="expand_button_pill" /> <java-symbol type="id" name="expand_button_pill_colorized_layer" /> <java-symbol type="id" name="expand_button_number" /> diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/notification/row/wrapper/NotificationHeaderViewWrapper.java b/packages/SystemUI/src/com/android/systemui/statusbar/notification/row/wrapper/NotificationHeaderViewWrapper.java index e9eecdd8a26f..e8affaa4b60f 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/notification/row/wrapper/NotificationHeaderViewWrapper.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/notification/row/wrapper/NotificationHeaderViewWrapper.java @@ -31,6 +31,7 @@ import android.view.ViewGroup; import android.view.animation.Interpolator; import android.view.animation.PathInterpolator; import android.widget.DateTimeView; +import android.widget.FrameLayout; import android.widget.ImageButton; import android.widget.ImageView; import android.widget.TextView; @@ -41,6 +42,7 @@ import com.android.app.animation.Interpolators; import com.android.internal.widget.CachingIconView; import com.android.internal.widget.NotificationCloseButton; import com.android.internal.widget.NotificationExpandButton; +import com.android.systemui.Flags; import com.android.systemui.res.R; import com.android.systemui.statusbar.TransformableView; import com.android.systemui.statusbar.ViewTransformationHelper; @@ -67,6 +69,7 @@ public class NotificationHeaderViewWrapper extends NotificationViewWrapper imple private CachingIconView mIcon; private NotificationCloseButton mCloseButton; private NotificationExpandButton mExpandButton; + private FrameLayout mExpandButtonSpacer; private View mAltExpandTarget; private View mIconContainer; protected NotificationHeaderView mNotificationHeader; @@ -154,6 +157,10 @@ public class NotificationHeaderViewWrapper extends NotificationViewWrapper imple mHeaderText = mView.findViewById(com.android.internal.R.id.header_text); mAppNameText = mView.findViewById(com.android.internal.R.id.app_name_text); mExpandButton = mView.findViewById(com.android.internal.R.id.expand_button); + if (Flags.uiRichOngoingForceExpanded()) { + mExpandButtonSpacer = + mView.findViewById(com.android.internal.R.id.expand_button_spacer); + } mAltExpandTarget = mView.findViewById(com.android.internal.R.id.alternate_expand_target); mIconContainer = mView.findViewById(com.android.internal.R.id.conversation_icon_container); mWorkProfileImage = mView.findViewById(com.android.internal.R.id.profile_badge); @@ -295,6 +302,9 @@ public class NotificationHeaderViewWrapper extends NotificationViewWrapper imple boolean expandable, View.OnClickListener onClickListener, boolean requestLayout) { + if (Flags.uiRichOngoingForceExpanded() && mExpandButtonSpacer != null) { + mExpandButtonSpacer.setVisibility(expandable ? GONE : VISIBLE); + } mExpandButton.setVisibility(expandable ? VISIBLE : GONE); mExpandButton.setOnClickListener(expandable ? onClickListener : null); if (mAltExpandTarget != null) { |