summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Elliott Hughes <enh@google.com> 2017-06-23 21:38:59 +0000
committer android-build-merger <android-build-merger@google.com> 2017-06-23 21:38:59 +0000
commitb2f8a670126920b632ef02ad0610a38a67b3ed67 (patch)
tree8a9b34b658826a87df0a8c5331a87b2fb20e0d47
parent90700b82815c6f78698004aaa43026257c95ff07 (diff)
parent7bb95c55c0dd1d6514ccca10eefa8828972fe4a7 (diff)
Merge "Replace MallocHelper with std::unique_ptr." am: 8330d5212d am: 6dfb0ca3d5
am: 7bb95c55c0 Change-Id: I3e78c1732189a07e2ff17b046f71c7db435d9e3c
-rw-r--r--core/jni/android/opengl/util.cpp29
1 files changed, 3 insertions, 26 deletions
diff --git a/core/jni/android/opengl/util.cpp b/core/jni/android/opengl/util.cpp
index 1370e610398d..7c1ca8142c7f 100644
--- a/core/jni/android/opengl/util.cpp
+++ b/core/jni/android/opengl/util.cpp
@@ -49,27 +49,6 @@ void mx4transform(float x, float y, float z, float w, const float* pM, float* pD
pDest[3] = pM[3 + 4 * 0] * x + pM[3 + 4 * 1] * y + pM[3 + 4 * 2] * z + pM[3 + 4 * 3] * w;
}
-class MallocHelper {
-public:
- MallocHelper() {
- mData = 0;
- }
-
- ~MallocHelper() {
- if (mData != 0) {
- free(mData);
- }
- }
-
- void* alloc(size_t size) {
- mData = malloc(size);
- return mData;
- }
-
-private:
- void* mData;
-};
-
#if 0
static
void
@@ -85,10 +64,7 @@ print_poly(const char* label, Poly* pPoly) {
static
int visibilityTest(float* pWS, float* pPositions, int positionsLength,
unsigned short* pIndices, int indexCount) {
- MallocHelper mallocHelper;
int result = POLY_CLIP_OUT;
- float* pTransformed = 0;
- int transformedIndexCount = 0;
if ( indexCount < 3 ) {
return POLY_CLIP_OUT;
@@ -116,8 +92,9 @@ int visibilityTest(float* pWS, float* pPositions, int positionsLength,
return -1;
}
- transformedIndexCount = maxIndex - minIndex + 1;
- pTransformed = (float*) mallocHelper.alloc(transformedIndexCount * 4 * sizeof(float));
+ int transformedIndexCount = maxIndex - minIndex + 1;
+ std::unique_ptr<float[]> holder{new float[transformedIndexCount * 4]};
+ float* pTransformed = holder.get();
if (pTransformed == 0 ) {
return -2;