summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author TreeHugger Robot <treehugger-gerrit@google.com> 2021-03-08 20:08:48 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2021-03-08 20:08:48 +0000
commitb28ad521cfb9b40126f11dc58207a18d0c2b764e (patch)
tree720ae4fa9e2e6c3e39c78b071343998ab95352b2
parent8923066718b8ac6c904152353fa76e9827025798 (diff)
parent7e34869ebd3df187a31f7240fb527a0f466945f0 (diff)
Merge "Avoid unnecessary smaps logic during app compaction" into sc-dev
-rw-r--r--services/core/jni/com_android_server_am_CachedAppOptimizer.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/services/core/jni/com_android_server_am_CachedAppOptimizer.cpp b/services/core/jni/com_android_server_am_CachedAppOptimizer.cpp
index 8c6d084fba99..a4a74af8a1d9 100644
--- a/services/core/jni/com_android_server_am_CachedAppOptimizer.cpp
+++ b/services/core/jni/com_android_server_am_CachedAppOptimizer.cpp
@@ -135,7 +135,7 @@ static int getAnyPageAdvice(const Vma& vma) {
static int compactProcess(int pid, VmaToAdviseFunc vmaToAdviseFunc) {
ProcMemInfo meminfo(pid);
std::vector<Vma> pageoutVmas, coldVmas;
- auto vmaCollectorCb = [&](Vma vma) {
+ auto vmaCollectorCb = [&coldVmas,&pageoutVmas,&vmaToAdviseFunc](const Vma& vma) {
int advice = vmaToAdviseFunc(vma);
switch (advice) {
case MADV_COLD:
@@ -146,7 +146,7 @@ static int compactProcess(int pid, VmaToAdviseFunc vmaToAdviseFunc) {
break;
}
};
- meminfo.ForEachVma(vmaCollectorCb);
+ meminfo.ForEachVmaFromMaps(vmaCollectorCb);
int err = compactMemory(pageoutVmas, pid, MADV_PAGEOUT);
if (!err) {