diff options
author | 2019-02-26 11:54:40 +0100 | |
---|---|---|
committer | 2019-02-26 11:54:40 +0100 | |
commit | b1faa0bf5b5bef39886a2ac2b10ca78eea24a006 (patch) | |
tree | 0ccf0c22ffb6a8a4e70ab211aa51f800b4a63e80 | |
parent | 87c1081c4222e490364422a1f21dbec9a35c6791 (diff) |
apilint: Correctly parse packages with annotations
Test: python apilint_test.py
Change-Id: Ifce9fe3836b2bb46b0d0a255b912fd8bf0195621
-rw-r--r-- | tools/apilint/apilint.py | 5 | ||||
-rw-r--r-- | tools/apilint/apilint_test.py | 16 |
2 files changed, 19 insertions, 2 deletions
diff --git a/tools/apilint/apilint.py b/tools/apilint/apilint.py index 75c3eba7765b..9937ee32c4a6 100644 --- a/tools/apilint/apilint.py +++ b/tools/apilint/apilint.py @@ -208,13 +208,14 @@ class Class(): class Package(): + NAME = re.compile("package(?: .*)? ([A-Za-z.]+)") + def __init__(self, line, raw, blame): self.line = line self.raw = raw.strip(" {;") self.blame = blame - raw = raw.split() - self.name = raw[raw.index("package")+1] + self.name = Package.NAME.match(raw).group(1) self.name_path = self.name.split(".") def __repr__(self): diff --git a/tools/apilint/apilint_test.py b/tools/apilint/apilint_test.py index 9c261d506dac..c0bf811e9754 100644 --- a/tools/apilint/apilint_test.py +++ b/tools/apilint/apilint_test.py @@ -352,5 +352,21 @@ class V2ParserTests(unittest.TestCase): m = self._method('method @NonNull public @NonNull String @NonNull [] split(@NonNull String, int);') self.assertEquals('java.lang.String[]', m.typ) +class PackageTests(unittest.TestCase): + def _package(self, raw): + return apilint.Package(123, raw, "blame") + + def test_regular_package(self): + p = self._package("package an.pref.int {") + self.assertEquals('an.pref.int', p.name) + + def test_annotation_package(self): + p = self._package("package @RestrictTo(a.b.C) an.pref.int {") + self.assertEquals('an.pref.int', p.name) + + def test_multi_annotation_package(self): + p = self._package("package @Rt(a.b.L_G_P) @RestrictTo(a.b.C) an.pref.int {") + self.assertEquals('an.pref.int', p.name) + if __name__ == "__main__": unittest.main() |