summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Chiachang Wang <chiachangwang@google.com> 2019-12-10 10:07:12 +0800
committer Chiachang Wang <chiachangwang@google.com> 2019-12-10 10:07:12 +0800
commitafd43e48c69ccd0b27049939c8c53ecdcbc7f5af (patch)
tree704fb88eb9bb21f17d3724bd4db86ca6e04b8b42
parent932dda858a13a2b7bc8fe2f20fad1d451d37e3f6 (diff)
Add TetherConfigParcel to improve startTetheringWithConfiguration
In order to support extensibility, update the interface between netd to take a configuration parcel, instead of fixed parameters. Bug: 145777247 Test: atest FrameworksNetTests Test: build, flash, on/off tethering Change-Id: I3dbccc46ce4ddccfb6d518de240e4604b7f95eed
-rw-r--r--services/core/java/com/android/server/NetworkManagementService.java6
1 files changed, 5 insertions, 1 deletions
diff --git a/services/core/java/com/android/server/NetworkManagementService.java b/services/core/java/com/android/server/NetworkManagementService.java
index 9efaad848ccc..8fa0d7e94222 100644
--- a/services/core/java/com/android/server/NetworkManagementService.java
+++ b/services/core/java/com/android/server/NetworkManagementService.java
@@ -57,6 +57,7 @@ import android.net.NetworkPolicyManager;
import android.net.NetworkStats;
import android.net.NetworkUtils;
import android.net.RouteInfo;
+import android.net.TetherConfigParcel;
import android.net.TetherStatsParcel;
import android.net.UidRange;
import android.net.UidRangeParcel;
@@ -1016,7 +1017,10 @@ public class NetworkManagementService extends INetworkManagementService.Stub {
mContext.enforceCallingOrSelfPermission(CONNECTIVITY_INTERNAL, TAG);
// an odd number of addrs will fail
try {
- mNetdService.tetherStartWithConfiguration(usingLegacyDnsProxy, dhcpRange);
+ final TetherConfigParcel config = new TetherConfigParcel();
+ config.usingLegacyDnsProxy = usingLegacyDnsProxy;
+ config.dhcpRanges = dhcpRange;
+ mNetdService.tetherStartWithConfiguration(config);
} catch (RemoteException | ServiceSpecificException e) {
throw new IllegalStateException(e);
}