diff options
| author | 2024-09-05 16:08:48 +0000 | |
|---|---|---|
| committer | 2024-09-05 16:10:16 +0000 | |
| commit | ae8b2ea9df6932dfd1ec27681e4e873fb80db047 (patch) | |
| tree | f1d898591d100f454004fb2b2d0df60e242ebe2b | |
| parent | f33f1b91c9218cfd04ba78476f040feef320995b (diff) | |
[SB][Wifi] Remove unused networkId from WifiNetworkModel classes.
The network ID is no longer used anywhere now that we've moved to
WifiTrackerLib, so this CL removes it from WifiNetworkModel.Active and
WifiNetworkModel.CarrierMerged.
Bug: 292534484
Flag: EXEMPT refactor
Test: atest WifiRepositoryImplTest WifiInteractorImplTest
Test: smoke test of the wifi icon and Internet tile
Change-Id: I0261a9883d5baec2c5e797b42f9bb36e91ff2b92
16 files changed, 36 insertions, 169 deletions
diff --git a/packages/SystemUI/multivalentTests/src/com/android/systemui/qs/tiles/impl/internet/domain/interactor/InternetTileDataInteractorTest.kt b/packages/SystemUI/multivalentTests/src/com/android/systemui/qs/tiles/impl/internet/domain/interactor/InternetTileDataInteractorTest.kt index 1ea8abc9b3b3..8e61c849179d 100644 --- a/packages/SystemUI/multivalentTests/src/com/android/systemui/qs/tiles/impl/internet/domain/interactor/InternetTileDataInteractorTest.kt +++ b/packages/SystemUI/multivalentTests/src/com/android/systemui/qs/tiles/impl/internet/domain/interactor/InternetTileDataInteractorTest.kt @@ -185,7 +185,6 @@ class InternetTileDataInteractorTest : SysuiTestCase() { val networkModel = WifiNetworkModel.Active( - networkId = 1, level = 4, ssid = "test ssid", ) @@ -221,7 +220,6 @@ class InternetTileDataInteractorTest : SysuiTestCase() { val networkModel = WifiNetworkModel.Active( - networkId = 1, level = 4, ssid = "test ssid", hotspotDeviceType = WifiNetworkModel.HotspotDeviceType.NONE, @@ -546,7 +544,6 @@ class InternetTileDataInteractorTest : SysuiTestCase() { private fun setWifiNetworkWithHotspot(hotspot: WifiNetworkModel.HotspotDeviceType) { val networkModel = WifiNetworkModel.Active( - networkId = 1, level = 4, ssid = "test ssid", hotspotDeviceType = hotspot, diff --git a/packages/SystemUI/multivalentTests/src/com/android/systemui/statusbar/pipeline/wifi/domain/interactor/WifiInteractorImplTest.kt b/packages/SystemUI/multivalentTests/src/com/android/systemui/statusbar/pipeline/wifi/domain/interactor/WifiInteractorImplTest.kt index 8cf9b0f9bb47..b9ca8fc2d181 100644 --- a/packages/SystemUI/multivalentTests/src/com/android/systemui/statusbar/pipeline/wifi/domain/interactor/WifiInteractorImplTest.kt +++ b/packages/SystemUI/multivalentTests/src/com/android/systemui/statusbar/pipeline/wifi/domain/interactor/WifiInteractorImplTest.kt @@ -93,7 +93,7 @@ class WifiInteractorImplTest : SysuiTestCase() { fun ssid_carrierMergedNetwork_outputsNull() = testScope.runTest { wifiRepository.setWifiNetwork( - WifiNetworkModel.CarrierMerged(networkId = 1, subscriptionId = 2, level = 1) + WifiNetworkModel.CarrierMerged(subscriptionId = 2, level = 1) ) var latest: String? = "default" @@ -110,7 +110,6 @@ class WifiInteractorImplTest : SysuiTestCase() { testScope.runTest { wifiRepository.setWifiNetwork( WifiNetworkModel.Active( - networkId = 1, level = 1, ssid = WifiManager.UNKNOWN_SSID, ) @@ -130,7 +129,6 @@ class WifiInteractorImplTest : SysuiTestCase() { testScope.runTest { wifiRepository.setWifiNetwork( WifiNetworkModel.Active( - networkId = 1, level = 1, ssid = "MyAwesomeWifiNetwork", ) @@ -192,7 +190,6 @@ class WifiInteractorImplTest : SysuiTestCase() { testScope.runTest { val wifiNetwork = WifiNetworkModel.Active( - networkId = 45, isValidated = true, level = 3, ssid = "AB", @@ -303,7 +300,6 @@ class WifiInteractorImplTest : SysuiTestCase() { wifiRepository.setWifiNetwork( WifiNetworkModel.Active( ssid = "ssid 2", - networkId = 1, level = 2, ) ) @@ -324,7 +320,6 @@ class WifiInteractorImplTest : SysuiTestCase() { wifiRepository.setWifiNetwork( WifiNetworkModel.Active( ssid = "ssid 2", - networkId = 1, level = 2, ) ) diff --git a/packages/SystemUI/multivalentTests/src/com/android/systemui/statusbar/pipeline/wifi/ui/viewmodel/WifiViewModelTest.kt b/packages/SystemUI/multivalentTests/src/com/android/systemui/statusbar/pipeline/wifi/ui/viewmodel/WifiViewModelTest.kt index 123734742820..43b9531c6086 100644 --- a/packages/SystemUI/multivalentTests/src/com/android/systemui/statusbar/pipeline/wifi/ui/viewmodel/WifiViewModelTest.kt +++ b/packages/SystemUI/multivalentTests/src/com/android/systemui/statusbar/pipeline/wifi/ui/viewmodel/WifiViewModelTest.kt @@ -113,9 +113,7 @@ class WifiViewModelTest : SysuiTestCase() { val latestKeyguard by collectLastValue(keyguard.wifiIcon) val latestQs by collectLastValue(qs.wifiIcon) - wifiRepository.setWifiNetwork( - WifiNetworkModel.Active(NETWORK_ID, isValidated = true, level = 1) - ) + wifiRepository.setWifiNetwork(WifiNetworkModel.Active(isValidated = true, level = 1)) assertThat(latestHome).isInstanceOf(WifiIcon.Visible::class.java) assertThat(latestHome).isEqualTo(latestKeyguard) @@ -130,7 +128,6 @@ class WifiViewModelTest : SysuiTestCase() { // Even WHEN the network has a valid hotspot type wifiRepository.setWifiNetwork( WifiNetworkModel.Active( - NETWORK_ID, isValidated = true, level = 1, hotspotDeviceType = WifiNetworkModel.HotspotDeviceType.LAPTOP, @@ -192,9 +189,7 @@ class WifiViewModelTest : SysuiTestCase() { whenever(connectivityConstants.shouldShowActivityConfig).thenReturn(true) createAndSetViewModel() - wifiRepository.setWifiNetwork( - WifiNetworkModel.Active(NETWORK_ID, ssid = null, level = 1) - ) + wifiRepository.setWifiNetwork(WifiNetworkModel.Active(ssid = null, level = 1)) val activityIn by collectLastValue(underTest.isActivityInViewVisible) val activityOut by collectLastValue(underTest.isActivityOutViewVisible) @@ -217,9 +212,7 @@ class WifiViewModelTest : SysuiTestCase() { whenever(connectivityConstants.shouldShowActivityConfig).thenReturn(true) createAndSetViewModel() - wifiRepository.setWifiNetwork( - WifiNetworkModel.Active(NETWORK_ID, ssid = null, level = 1) - ) + wifiRepository.setWifiNetwork(WifiNetworkModel.Active(ssid = null, level = 1)) val activityIn by collectLastValue(underTest.isActivityInViewVisible) val activityOut by collectLastValue(underTest.isActivityOutViewVisible) @@ -468,8 +461,6 @@ class WifiViewModelTest : SysuiTestCase() { } companion object { - private const val NETWORK_ID = 2 - private val ACTIVE_VALID_WIFI_NETWORK = - WifiNetworkModel.Active(NETWORK_ID, ssid = "AB", level = 1) + private val ACTIVE_VALID_WIFI_NETWORK = WifiNetworkModel.Active(ssid = "AB", level = 1) } } diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/wifi/data/repository/demo/DemoWifiRepository.kt b/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/wifi/data/repository/demo/DemoWifiRepository.kt index d1ac3e92abc2..7163e67eaa5d 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/wifi/data/repository/demo/DemoWifiRepository.kt +++ b/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/wifi/data/repository/demo/DemoWifiRepository.kt @@ -101,7 +101,6 @@ constructor( private fun FakeWifiEventModel.Wifi.toWifiNetworkModel(): WifiNetworkModel = WifiNetworkModel.Active( - networkId = DEMO_NET_ID, isValidated = validated ?: true, level = level ?: 0, ssid = ssid ?: DEMO_NET_SSID, @@ -110,14 +109,12 @@ constructor( private fun FakeWifiEventModel.CarrierMerged.toCarrierMergedModel(): WifiNetworkModel = WifiNetworkModel.CarrierMerged( - networkId = DEMO_NET_ID, subscriptionId = subscriptionId, level = level, numberOfLevels = numberOfLevels, ) companion object { - private const val DEMO_NET_ID = 1234 private const val DEMO_NET_SSID = "Demo SSID" } } diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/wifi/data/repository/prod/WifiRepositoryImpl.kt b/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/wifi/data/repository/prod/WifiRepositoryImpl.kt index 20c76681e11f..b23ab3a8a897 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/wifi/data/repository/prod/WifiRepositoryImpl.kt +++ b/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/wifi/data/repository/prod/WifiRepositoryImpl.kt @@ -260,7 +260,6 @@ constructor( WifiNetworkModel.Invalid(CARRIER_MERGED_INVALID_SUB_ID_REASON) } else { WifiNetworkModel.CarrierMerged( - networkId = NETWORK_ID, subscriptionId = this.subscriptionId, level = this.level, // WifiManager APIs to calculate the signal level start from 0, so @@ -295,7 +294,6 @@ constructor( } return WifiNetworkModel.Active( - networkId = NETWORK_ID, isValidated = this.hasInternetAccess(), level = currentLevel, ssid = this.title, @@ -442,19 +440,5 @@ constructor( val ACTIVITY_DEFAULT = DataActivityModel(hasActivityIn = false, hasActivityOut = false) private const val TAG = "WifiTrackerLibInputLog" - - /** - * [WifiNetworkModel.Active.networkId] is only used at the repository layer. It's used by - * [WifiRepositoryImpl], which tracks the ID in order to correctly apply the framework - * callbacks within the repository. - * - * Since this class does not need to manually apply framework callbacks and since the - * network ID is not used beyond the repository, it's safe to use an invalid ID in this - * repository. - * - * The [WifiNetworkModel.Active.networkId] field should be deleted once we've fully migrated - * to [WifiRepositoryImpl]. - */ - private const val NETWORK_ID = -1 } } diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/wifi/shared/model/WifiNetworkModel.kt b/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/wifi/shared/model/WifiNetworkModel.kt index 834a6db83ab2..39842fb39e24 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/wifi/shared/model/WifiNetworkModel.kt +++ b/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/wifi/shared/model/WifiNetworkModel.kt @@ -50,7 +50,6 @@ sealed class WifiNetworkModel : Diffable<WifiNetworkModel> { override fun logFull(row: TableRowLogger) { row.logChange(COL_NETWORK_TYPE, TYPE_UNAVAILABLE) - row.logChange(COL_NETWORK_ID, NETWORK_ID_DEFAULT) row.logChange(COL_SUB_ID, SUB_ID_DEFAULT) row.logChange(COL_VALIDATED, false) row.logChange(COL_LEVEL, LEVEL_DEFAULT) @@ -80,7 +79,6 @@ sealed class WifiNetworkModel : Diffable<WifiNetworkModel> { override fun logFull(row: TableRowLogger) { row.logChange(COL_NETWORK_TYPE, "$TYPE_UNAVAILABLE $invalidReason") - row.logChange(COL_NETWORK_ID, NETWORK_ID_DEFAULT) row.logChange(COL_SUB_ID, SUB_ID_DEFAULT) row.logChange(COL_VALIDATED, false) row.logChange(COL_LEVEL, LEVEL_DEFAULT) @@ -105,7 +103,6 @@ sealed class WifiNetworkModel : Diffable<WifiNetworkModel> { override fun logFull(row: TableRowLogger) { row.logChange(COL_NETWORK_TYPE, TYPE_INACTIVE) - row.logChange(COL_NETWORK_ID, NETWORK_ID_DEFAULT) row.logChange(COL_SUB_ID, SUB_ID_DEFAULT) row.logChange(COL_VALIDATED, false) row.logChange(COL_LEVEL, LEVEL_DEFAULT) @@ -123,14 +120,6 @@ sealed class WifiNetworkModel : Diffable<WifiNetworkModel> { */ data class CarrierMerged( /** - * The [android.net.Network.netId] we received from - * [android.net.ConnectivityManager.NetworkCallback] in association with this wifi network. - * - * Importantly, **not** [android.net.wifi.WifiInfo.getNetworkId]. - */ - val networkId: Int, - - /** * The subscription ID that this connection represents. * * Comes from [android.net.wifi.WifiInfo.getSubscriptionId]. @@ -162,9 +151,6 @@ sealed class WifiNetworkModel : Diffable<WifiNetworkModel> { return } - if (prevVal.networkId != networkId) { - row.logChange(COL_NETWORK_ID, networkId) - } if (prevVal.subscriptionId != subscriptionId) { row.logChange(COL_SUB_ID, subscriptionId) } @@ -178,7 +164,6 @@ sealed class WifiNetworkModel : Diffable<WifiNetworkModel> { override fun logFull(row: TableRowLogger) { row.logChange(COL_NETWORK_TYPE, TYPE_CARRIER_MERGED) - row.logChange(COL_NETWORK_ID, networkId) row.logChange(COL_SUB_ID, subscriptionId) row.logChange(COL_VALIDATED, true) row.logChange(COL_LEVEL, level) @@ -190,14 +175,6 @@ sealed class WifiNetworkModel : Diffable<WifiNetworkModel> { /** Provides information about an active wifi network. */ data class Active( - /** - * The [android.net.Network.netId] we received from - * [android.net.ConnectivityManager.NetworkCallback] in association with this wifi network. - * - * Importantly, **not** [android.net.wifi.WifiInfo.getNetworkId]. - */ - val networkId: Int, - /** See [android.net.NetworkCapabilities.NET_CAPABILITY_VALIDATED]. */ val isValidated: Boolean = false, @@ -231,9 +208,6 @@ sealed class WifiNetworkModel : Diffable<WifiNetworkModel> { return } - if (prevVal.networkId != networkId) { - row.logChange(COL_NETWORK_ID, networkId) - } if (prevVal.isValidated != isValidated) { row.logChange(COL_VALIDATED, isValidated) } @@ -250,7 +224,6 @@ sealed class WifiNetworkModel : Diffable<WifiNetworkModel> { override fun logFull(row: TableRowLogger) { row.logChange(COL_NETWORK_TYPE, TYPE_ACTIVE) - row.logChange(COL_NETWORK_ID, networkId) row.logChange(COL_SUB_ID, null) row.logChange(COL_VALIDATED, isValidated) row.logChange(COL_LEVEL, level) @@ -309,7 +282,6 @@ const val TYPE_INACTIVE = "Inactive" const val TYPE_ACTIVE = "Active" const val COL_NETWORK_TYPE = "type" -const val COL_NETWORK_ID = "networkId" const val COL_SUB_ID = "subscriptionId" const val COL_VALIDATED = "isValidated" const val COL_LEVEL = "level" @@ -319,5 +291,4 @@ const val COL_HOTSPOT = "hotspot" val LEVEL_DEFAULT: String? = null val NUM_LEVELS_DEFAULT: String? = null -val NETWORK_ID_DEFAULT: String? = null val SUB_ID_DEFAULT: String? = null diff --git a/packages/SystemUI/tests/src/com/android/keyguard/CarrierTextManagerTest.java b/packages/SystemUI/tests/src/com/android/keyguard/CarrierTextManagerTest.java index 4c872d8eec15..d85b77413338 100644 --- a/packages/SystemUI/tests/src/com/android/keyguard/CarrierTextManagerTest.java +++ b/packages/SystemUI/tests/src/com/android/keyguard/CarrierTextManagerTest.java @@ -446,7 +446,6 @@ public class CarrierTextManagerTest extends SysuiTestCase { assertFalse(mWifiRepository.isWifiConnectedWithValidSsid()); mWifiRepository.setWifiNetwork( new WifiNetworkModel.Active( - /* networkId= */ 0, /* isValidated= */ false, /* level= */ 0, /* ssid= */ "", diff --git a/packages/SystemUI/tests/src/com/android/systemui/qs/tiles/InternetTileNewImplTest.kt b/packages/SystemUI/tests/src/com/android/systemui/qs/tiles/InternetTileNewImplTest.kt index 828c7b2dbc69..e6ec07e97d17 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/qs/tiles/InternetTileNewImplTest.kt +++ b/packages/SystemUI/tests/src/com/android/systemui/qs/tiles/InternetTileNewImplTest.kt @@ -259,7 +259,6 @@ class InternetTileNewImplTest : SysuiTestCase() { const val WIFI_SSID = "test ssid" val ACTIVE_WIFI = WifiNetworkModel.Active( - networkId = 1, isValidated = true, level = 4, ssid = WIFI_SSID, diff --git a/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/mobile/data/repository/prod/CarrierMergedConnectionRepositoryTest.kt b/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/mobile/data/repository/prod/CarrierMergedConnectionRepositoryTest.kt index 237aabccfbd9..b6e23c1f42ee 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/mobile/data/repository/prod/CarrierMergedConnectionRepositoryTest.kt +++ b/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/mobile/data/repository/prod/CarrierMergedConnectionRepositoryTest.kt @@ -104,7 +104,7 @@ class CarrierMergedConnectionRepositoryTest : SysuiTestCase() { underTest.dataConnectionState.onEach { latestConnState = it }.launchIn(this) val netJob = underTest.resolvedNetworkType.onEach { latestNetType = it }.launchIn(this) - wifiRepository.setWifiNetwork(WifiNetworkModel.Active(networkId = NET_ID, level = 1)) + wifiRepository.setWifiNetwork(WifiNetworkModel.Active(level = 1)) assertThat(latestConnState).isEqualTo(DataConnectionState.Disconnected) assertThat(latestNetType).isNotEqualTo(ResolvedNetworkType.CarrierMergedNetworkType) @@ -124,7 +124,6 @@ class CarrierMergedConnectionRepositoryTest : SysuiTestCase() { wifiRepository.setWifiNetwork( WifiNetworkModel.CarrierMerged( - networkId = NET_ID, subscriptionId = SUB_ID, level = 3, ) @@ -145,7 +144,6 @@ class CarrierMergedConnectionRepositoryTest : SysuiTestCase() { wifiRepository.setIsWifiDefault(true) wifiRepository.setWifiNetwork( WifiNetworkModel.CarrierMerged( - networkId = NET_ID, subscriptionId = SUB_ID, level = 3, ) @@ -183,7 +181,6 @@ class CarrierMergedConnectionRepositoryTest : SysuiTestCase() { wifiRepository.setWifiNetwork( WifiNetworkModel.CarrierMerged( - networkId = NET_ID, subscriptionId = SUB_ID + 10, level = 3, ) @@ -205,7 +202,6 @@ class CarrierMergedConnectionRepositoryTest : SysuiTestCase() { wifiRepository.setWifiNetwork( WifiNetworkModel.CarrierMerged( - networkId = NET_ID, subscriptionId = SUB_ID, level = 3, ) @@ -226,7 +222,6 @@ class CarrierMergedConnectionRepositoryTest : SysuiTestCase() { wifiRepository.setWifiNetwork( WifiNetworkModel.CarrierMerged( - networkId = NET_ID, subscriptionId = SUB_ID, level = 3, ) @@ -246,7 +241,6 @@ class CarrierMergedConnectionRepositoryTest : SysuiTestCase() { wifiRepository.setWifiNetwork( WifiNetworkModel.CarrierMerged( - networkId = NET_ID, subscriptionId = SUB_ID, level = 1, numberOfLevels = 6, @@ -310,7 +304,6 @@ class CarrierMergedConnectionRepositoryTest : SysuiTestCase() { whenever(telephonyManager.simOperatorName).thenReturn("New SIM name") wifiRepository.setWifiNetwork( WifiNetworkModel.CarrierMerged( - networkId = NET_ID, subscriptionId = SUB_ID, level = 3, ) @@ -331,6 +324,5 @@ class CarrierMergedConnectionRepositoryTest : SysuiTestCase() { private companion object { const val SUB_ID = 123 - const val NET_ID = 456 } } diff --git a/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/mobile/data/repository/prod/FullMobileConnectionRepositoryTest.kt b/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/mobile/data/repository/prod/FullMobileConnectionRepositoryTest.kt index fd4c3702a666..035a05ff3db9 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/mobile/data/repository/prod/FullMobileConnectionRepositoryTest.kt +++ b/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/mobile/data/repository/prod/FullMobileConnectionRepositoryTest.kt @@ -512,10 +512,8 @@ class FullMobileConnectionRepositoryTest : SysuiTestCase() { val job = underTest.primaryLevel.launchIn(this) // WHEN we set up carrier merged info - val networkId = 2 wifiRepository.setWifiNetwork( WifiNetworkModel.CarrierMerged( - networkId, SUB_ID, level = 3, ) @@ -527,7 +525,6 @@ class FullMobileConnectionRepositoryTest : SysuiTestCase() { // WHEN we update the info wifiRepository.setWifiNetwork( WifiNetworkModel.CarrierMerged( - networkId, SUB_ID, level = 1, ) @@ -565,10 +562,8 @@ class FullMobileConnectionRepositoryTest : SysuiTestCase() { assertThat(dumpBuffer()).contains("$COL_PRIMARY_LEVEL${BUFFER_SEPARATOR}1") // WHEN isCarrierMerged is set to true - val networkId = 2 wifiRepository.setWifiNetwork( WifiNetworkModel.CarrierMerged( - networkId, SUB_ID, level = 3, ) @@ -581,7 +576,6 @@ class FullMobileConnectionRepositoryTest : SysuiTestCase() { // WHEN the carrier merge network is updated wifiRepository.setWifiNetwork( WifiNetworkModel.CarrierMerged( - networkId, SUB_ID, level = 4, ) @@ -632,10 +626,8 @@ class FullMobileConnectionRepositoryTest : SysuiTestCase() { .onSignalStrengthsChanged(signalStrength) // THEN updates to the carrier merged level aren't logged - val networkId = 2 wifiRepository.setWifiNetwork( WifiNetworkModel.CarrierMerged( - networkId, SUB_ID, level = 4, ) @@ -644,7 +636,6 @@ class FullMobileConnectionRepositoryTest : SysuiTestCase() { wifiRepository.setWifiNetwork( WifiNetworkModel.CarrierMerged( - networkId, SUB_ID, level = 3, ) diff --git a/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/satellite/domain/interactor/DeviceBasedSatelliteInteractorTest.kt b/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/satellite/domain/interactor/DeviceBasedSatelliteInteractorTest.kt index dbb77d5ba76b..a1cb29b8e95c 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/satellite/domain/interactor/DeviceBasedSatelliteInteractorTest.kt +++ b/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/satellite/domain/interactor/DeviceBasedSatelliteInteractorTest.kt @@ -574,7 +574,7 @@ class DeviceBasedSatelliteInteractorTest : SysuiTestCase() { val latest by collectLastValue(underTest.isWifiActive) // WHEN wifi is active - wifiRepository.setWifiNetwork(WifiNetworkModel.Active(networkId = 0, level = 1)) + wifiRepository.setWifiNetwork(WifiNetworkModel.Active(level = 1)) // THEN the interactor returns true due to the wifi network being active assertThat(latest).isTrue() diff --git a/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/satellite/ui/viewmodel/DeviceBasedSatelliteViewModelTest.kt b/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/satellite/ui/viewmodel/DeviceBasedSatelliteViewModelTest.kt index bf31f1e6d569..c1abf9826ea3 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/satellite/ui/viewmodel/DeviceBasedSatelliteViewModelTest.kt +++ b/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/satellite/ui/viewmodel/DeviceBasedSatelliteViewModelTest.kt @@ -375,7 +375,7 @@ class DeviceBasedSatelliteViewModelTest : SysuiTestCase() { repo.isSatelliteProvisioned.value = true // GIVEN wifi network is active - wifiRepository.setWifiNetwork(WifiNetworkModel.Active(networkId = 0, level = 1)) + wifiRepository.setWifiNetwork(WifiNetworkModel.Active(level = 1)) // THEN icon is null because the device is connected to wifi assertThat(latest).isNull() @@ -573,7 +573,7 @@ class DeviceBasedSatelliteViewModelTest : SysuiTestCase() { repo.isSatelliteProvisioned.value = true // GIVEN wifi network is active - wifiRepository.setWifiNetwork(WifiNetworkModel.Active(networkId = 0, level = 1)) + wifiRepository.setWifiNetwork(WifiNetworkModel.Active(level = 1)) // THEN carrier text is null because the device is connected to wifi assertThat(latest).isNull() diff --git a/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/shared/ui/viewmodel/InternetTileViewModelTest.kt b/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/shared/ui/viewmodel/InternetTileViewModelTest.kt index 2238bff8eb93..ccbed7cd66ec 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/shared/ui/viewmodel/InternetTileViewModelTest.kt +++ b/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/shared/ui/viewmodel/InternetTileViewModelTest.kt @@ -152,7 +152,6 @@ class InternetTileViewModelTest : SysuiTestCase() { val networkModel = WifiNetworkModel.Active( - networkId = 1, level = 4, ssid = "test ssid", ) @@ -182,7 +181,6 @@ class InternetTileViewModelTest : SysuiTestCase() { val networkModel = WifiNetworkModel.Active( - networkId = 1, level = 4, ssid = "test ssid", hotspotDeviceType = WifiNetworkModel.HotspotDeviceType.NONE, @@ -390,7 +388,6 @@ class InternetTileViewModelTest : SysuiTestCase() { private fun setWifiNetworkWithHotspot(hotspot: WifiNetworkModel.HotspotDeviceType) { val networkModel = WifiNetworkModel.Active( - networkId = 1, level = 4, ssid = "test ssid", hotspotDeviceType = hotspot, diff --git a/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/wifi/shared/model/WifiNetworkModelTest.kt b/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/wifi/shared/model/WifiNetworkModelTest.kt index eb6b068ca8a4..92860efc0c35 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/wifi/shared/model/WifiNetworkModelTest.kt +++ b/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/wifi/shared/model/WifiNetworkModelTest.kt @@ -34,31 +34,30 @@ class WifiNetworkModelTest : SysuiTestCase() { @Test fun active_levelsInValidRange_noException() { (MIN_VALID_LEVEL..MAX_VALID_LEVEL).forEach { level -> - WifiNetworkModel.Active(NETWORK_ID, level = level) + WifiNetworkModel.Active(level = level) // No assert, just need no crash } } @Test(expected = IllegalArgumentException::class) fun active_levelNegative_exceptionThrown() { - WifiNetworkModel.Active(NETWORK_ID, level = MIN_VALID_LEVEL - 1) + WifiNetworkModel.Active(level = MIN_VALID_LEVEL - 1) } @Test(expected = IllegalArgumentException::class) fun active_levelTooHigh_exceptionThrown() { - WifiNetworkModel.Active(NETWORK_ID, level = MAX_VALID_LEVEL + 1) + WifiNetworkModel.Active(level = MAX_VALID_LEVEL + 1) } @Test(expected = IllegalArgumentException::class) fun carrierMerged_invalidSubId_exceptionThrown() { - WifiNetworkModel.CarrierMerged(NETWORK_ID, INVALID_SUBSCRIPTION_ID, 1) + WifiNetworkModel.CarrierMerged(INVALID_SUBSCRIPTION_ID, 1) } @Test fun active_hasValidSsid_nullSsid_false() { val network = WifiNetworkModel.Active( - NETWORK_ID, level = MAX_VALID_LEVEL, ssid = null, ) @@ -70,7 +69,6 @@ class WifiNetworkModelTest : SysuiTestCase() { fun active_hasValidSsid_unknownSsid_false() { val network = WifiNetworkModel.Active( - NETWORK_ID, level = MAX_VALID_LEVEL, ssid = UNKNOWN_SSID, ) @@ -82,7 +80,6 @@ class WifiNetworkModelTest : SysuiTestCase() { fun active_hasValidSsid_validSsid_true() { val network = WifiNetworkModel.Active( - NETWORK_ID, level = MAX_VALID_LEVEL, ssid = "FakeSsid", ) @@ -97,7 +94,6 @@ class WifiNetworkModelTest : SysuiTestCase() { val logger = TestLogger() val prevVal = WifiNetworkModel.CarrierMerged( - networkId = 5, subscriptionId = 3, level = 1, ) @@ -105,7 +101,6 @@ class WifiNetworkModelTest : SysuiTestCase() { WifiNetworkModel.Inactive.logDiffs(prevVal, logger) assertThat(logger.changes).contains(Pair(COL_NETWORK_TYPE, TYPE_INACTIVE)) - assertThat(logger.changes).contains(Pair(COL_NETWORK_ID, NETWORK_ID_DEFAULT.toString())) assertThat(logger.changes).contains(Pair(COL_VALIDATED, "false")) assertThat(logger.changes).contains(Pair(COL_LEVEL, LEVEL_DEFAULT.toString())) assertThat(logger.changes).contains(Pair(COL_SSID, "null")) @@ -116,7 +111,6 @@ class WifiNetworkModelTest : SysuiTestCase() { val logger = TestLogger() val carrierMerged = WifiNetworkModel.CarrierMerged( - networkId = 6, subscriptionId = 3, level = 2, ) @@ -124,7 +118,6 @@ class WifiNetworkModelTest : SysuiTestCase() { carrierMerged.logDiffs(prevVal = WifiNetworkModel.Inactive, logger) assertThat(logger.changes).contains(Pair(COL_NETWORK_TYPE, TYPE_CARRIER_MERGED)) - assertThat(logger.changes).contains(Pair(COL_NETWORK_ID, "6")) assertThat(logger.changes).contains(Pair(COL_SUB_ID, "3")) assertThat(logger.changes).contains(Pair(COL_VALIDATED, "true")) assertThat(logger.changes).contains(Pair(COL_LEVEL, "2")) @@ -136,7 +129,6 @@ class WifiNetworkModelTest : SysuiTestCase() { val logger = TestLogger() val activeNetwork = WifiNetworkModel.Active( - networkId = 5, isValidated = true, level = 3, ssid = "Test SSID", @@ -146,27 +138,21 @@ class WifiNetworkModelTest : SysuiTestCase() { activeNetwork.logDiffs(prevVal = WifiNetworkModel.Inactive, logger) assertThat(logger.changes).contains(Pair(COL_NETWORK_TYPE, TYPE_ACTIVE)) - assertThat(logger.changes).contains(Pair(COL_NETWORK_ID, "5")) assertThat(logger.changes).contains(Pair(COL_VALIDATED, "true")) assertThat(logger.changes).contains(Pair(COL_LEVEL, "3")) assertThat(logger.changes).contains(Pair(COL_SSID, "Test SSID")) assertThat(logger.changes).contains(Pair(COL_HOTSPOT, "LAPTOP")) } + @Test fun logDiffs_activeToInactive_resetsAllActiveFields() { val logger = TestLogger() val activeNetwork = - WifiNetworkModel.Active( - networkId = 5, - isValidated = true, - level = 3, - ssid = "Test SSID" - ) + WifiNetworkModel.Active(isValidated = true, level = 3, ssid = "Test SSID") WifiNetworkModel.Inactive.logDiffs(prevVal = activeNetwork, logger) assertThat(logger.changes).contains(Pair(COL_NETWORK_TYPE, TYPE_INACTIVE)) - assertThat(logger.changes).contains(Pair(COL_NETWORK_ID, NETWORK_ID_DEFAULT.toString())) assertThat(logger.changes).contains(Pair(COL_VALIDATED, "false")) assertThat(logger.changes).contains(Pair(COL_LEVEL, LEVEL_DEFAULT.toString())) assertThat(logger.changes).contains(Pair(COL_SSID, "null")) @@ -178,7 +164,6 @@ class WifiNetworkModelTest : SysuiTestCase() { val logger = TestLogger() val activeNetwork = WifiNetworkModel.Active( - networkId = 5, isValidated = true, level = 3, ssid = "Test SSID", @@ -186,7 +171,6 @@ class WifiNetworkModelTest : SysuiTestCase() { ) val prevVal = WifiNetworkModel.CarrierMerged( - networkId = 5, subscriptionId = 3, level = 1, ) @@ -194,25 +178,19 @@ class WifiNetworkModelTest : SysuiTestCase() { activeNetwork.logDiffs(prevVal, logger) assertThat(logger.changes).contains(Pair(COL_NETWORK_TYPE, TYPE_ACTIVE)) - assertThat(logger.changes).contains(Pair(COL_NETWORK_ID, "5")) assertThat(logger.changes).contains(Pair(COL_VALIDATED, "true")) assertThat(logger.changes).contains(Pair(COL_LEVEL, "3")) assertThat(logger.changes).contains(Pair(COL_SSID, "Test SSID")) assertThat(logger.changes).contains(Pair(COL_HOTSPOT, "AUTO")) } + @Test fun logDiffs_activeToCarrierMerged_logsAllFields() { val logger = TestLogger() val activeNetwork = - WifiNetworkModel.Active( - networkId = 5, - isValidated = true, - level = 3, - ssid = "Test SSID" - ) + WifiNetworkModel.Active(isValidated = true, level = 3, ssid = "Test SSID") val carrierMerged = WifiNetworkModel.CarrierMerged( - networkId = 6, subscriptionId = 3, level = 2, ) @@ -220,7 +198,6 @@ class WifiNetworkModelTest : SysuiTestCase() { carrierMerged.logDiffs(prevVal = activeNetwork, logger) assertThat(logger.changes).contains(Pair(COL_NETWORK_TYPE, TYPE_CARRIER_MERGED)) - assertThat(logger.changes).contains(Pair(COL_NETWORK_ID, "6")) assertThat(logger.changes).contains(Pair(COL_SUB_ID, "3")) assertThat(logger.changes).contains(Pair(COL_VALIDATED, "true")) assertThat(logger.changes).contains(Pair(COL_LEVEL, "2")) @@ -231,19 +208,9 @@ class WifiNetworkModelTest : SysuiTestCase() { fun logDiffs_activeChangesLevel_onlyLevelLogged() { val logger = TestLogger() val prevActiveNetwork = - WifiNetworkModel.Active( - networkId = 5, - isValidated = true, - level = 3, - ssid = "Test SSID" - ) + WifiNetworkModel.Active(isValidated = true, level = 3, ssid = "Test SSID") val newActiveNetwork = - WifiNetworkModel.Active( - networkId = 5, - isValidated = true, - level = 2, - ssid = "Test SSID" - ) + WifiNetworkModel.Active(isValidated = true, level = 2, ssid = "Test SSID") newActiveNetwork.logDiffs(prevActiveNetwork, logger) @@ -265,8 +232,4 @@ class WifiNetworkModelTest : SysuiTestCase() { changes.add(Pair(columnName, value.toString())) } } - - companion object { - private const val NETWORK_ID = 2 - } } diff --git a/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/wifi/ui/view/ModernStatusBarWifiViewTest.kt b/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/wifi/ui/view/ModernStatusBarWifiViewTest.kt index 80b10c06d696..31ffa5df4dba 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/wifi/ui/view/ModernStatusBarWifiViewTest.kt +++ b/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/wifi/ui/view/ModernStatusBarWifiViewTest.kt @@ -193,9 +193,7 @@ class ModernStatusBarWifiViewTest : SysuiTestCase() { @Test fun isIconVisible_notEnabled_outputsFalse() { wifiRepository.setIsWifiEnabled(false) - wifiRepository.setWifiNetwork( - WifiNetworkModel.Active(NETWORK_ID, isValidated = true, level = 2) - ) + wifiRepository.setWifiNetwork(WifiNetworkModel.Active(isValidated = true, level = 2)) val view = ModernStatusBarWifiView.constructAndBind(context, SLOT_NAME, viewModel) @@ -210,9 +208,7 @@ class ModernStatusBarWifiViewTest : SysuiTestCase() { @Test fun isIconVisible_enabled_outputsTrue() { wifiRepository.setIsWifiEnabled(true) - wifiRepository.setWifiNetwork( - WifiNetworkModel.Active(NETWORK_ID, isValidated = true, level = 2) - ) + wifiRepository.setWifiNetwork(WifiNetworkModel.Active(isValidated = true, level = 2)) val view = ModernStatusBarWifiView.constructAndBind(context, SLOT_NAME, viewModel) @@ -270,4 +266,3 @@ class ModernStatusBarWifiViewTest : SysuiTestCase() { } private const val SLOT_NAME = "TestSlotName" -private const val NETWORK_ID = 200 diff --git a/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/wifi/ui/viewmodel/WifiViewModelIconParameterizedTest.kt b/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/wifi/ui/viewmodel/WifiViewModelIconParameterizedTest.kt index 489319e4352f..43fee78ce220 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/wifi/ui/viewmodel/WifiViewModelIconParameterizedTest.kt +++ b/packages/SystemUI/tests/src/com/android/systemui/statusbar/pipeline/wifi/ui/viewmodel/WifiViewModelIconParameterizedTest.kt @@ -204,8 +204,7 @@ internal class WifiViewModelIconParameterizedTest(private val testCase: TestCase // Enabled = false => no networks shown TestCase( enabled = false, - network = - WifiNetworkModel.CarrierMerged(NETWORK_ID, subscriptionId = 1, level = 1), + network = WifiNetworkModel.CarrierMerged(subscriptionId = 1, level = 1), expected = null, ), TestCase( @@ -215,20 +214,19 @@ internal class WifiViewModelIconParameterizedTest(private val testCase: TestCase ), TestCase( enabled = false, - network = WifiNetworkModel.Active(NETWORK_ID, isValidated = false, level = 1), + network = WifiNetworkModel.Active(isValidated = false, level = 1), expected = null, ), TestCase( enabled = false, - network = WifiNetworkModel.Active(NETWORK_ID, isValidated = true, level = 3), + network = WifiNetworkModel.Active(isValidated = true, level = 3), expected = null, ), // forceHidden = true => no networks shown TestCase( forceHidden = true, - network = - WifiNetworkModel.CarrierMerged(NETWORK_ID, subscriptionId = 1, level = 1), + network = WifiNetworkModel.CarrierMerged(subscriptionId = 1, level = 1), expected = null, ), TestCase( @@ -238,12 +236,12 @@ internal class WifiViewModelIconParameterizedTest(private val testCase: TestCase ), TestCase( enabled = false, - network = WifiNetworkModel.Active(NETWORK_ID, isValidated = false, level = 2), + network = WifiNetworkModel.Active(isValidated = false, level = 2), expected = null, ), TestCase( forceHidden = true, - network = WifiNetworkModel.Active(NETWORK_ID, isValidated = true, level = 1), + network = WifiNetworkModel.Active(isValidated = true, level = 1), expected = null, ), @@ -263,7 +261,7 @@ internal class WifiViewModelIconParameterizedTest(private val testCase: TestCase ), TestCase( alwaysShowIconWhenEnabled = true, - network = WifiNetworkModel.Active(NETWORK_ID, isValidated = false, level = 4), + network = WifiNetworkModel.Active(isValidated = false, level = 4), expected = Expected( iconResource = WIFI_NO_INTERNET_ICONS[4], @@ -276,7 +274,7 @@ internal class WifiViewModelIconParameterizedTest(private val testCase: TestCase ), TestCase( alwaysShowIconWhenEnabled = true, - network = WifiNetworkModel.Active(NETWORK_ID, isValidated = true, level = 2), + network = WifiNetworkModel.Active(isValidated = true, level = 2), expected = Expected( iconResource = WIFI_FULL_ICONS[2], @@ -303,7 +301,7 @@ internal class WifiViewModelIconParameterizedTest(private val testCase: TestCase ), TestCase( hasDataCapabilities = false, - network = WifiNetworkModel.Active(NETWORK_ID, isValidated = false, level = 2), + network = WifiNetworkModel.Active(isValidated = false, level = 2), expected = Expected( iconResource = WIFI_NO_INTERNET_ICONS[2], @@ -316,7 +314,7 @@ internal class WifiViewModelIconParameterizedTest(private val testCase: TestCase ), TestCase( hasDataCapabilities = false, - network = WifiNetworkModel.Active(NETWORK_ID, isValidated = true, level = 0), + network = WifiNetworkModel.Active(isValidated = true, level = 0), expected = Expected( iconResource = WIFI_FULL_ICONS[0], @@ -343,7 +341,7 @@ internal class WifiViewModelIconParameterizedTest(private val testCase: TestCase ), TestCase( isDefault = true, - network = WifiNetworkModel.Active(NETWORK_ID, isValidated = false, level = 3), + network = WifiNetworkModel.Active(isValidated = false, level = 3), expected = Expected( iconResource = WIFI_NO_INTERNET_ICONS[3], @@ -356,7 +354,7 @@ internal class WifiViewModelIconParameterizedTest(private val testCase: TestCase ), TestCase( isDefault = true, - network = WifiNetworkModel.Active(NETWORK_ID, isValidated = true, level = 1), + network = WifiNetworkModel.Active(isValidated = true, level = 1), expected = Expected( iconResource = WIFI_FULL_ICONS[1], @@ -372,8 +370,7 @@ internal class WifiViewModelIconParameterizedTest(private val testCase: TestCase enabled = true, isDefault = true, forceHidden = false, - network = - WifiNetworkModel.CarrierMerged(NETWORK_ID, subscriptionId = 1, level = 1), + network = WifiNetworkModel.CarrierMerged(subscriptionId = 1, level = 1), expected = null, ), @@ -390,7 +387,7 @@ internal class WifiViewModelIconParameterizedTest(private val testCase: TestCase ), TestCase( isDefault = false, - network = WifiNetworkModel.Active(NETWORK_ID, isValidated = false, level = 3), + network = WifiNetworkModel.Active(isValidated = false, level = 3), expected = null, ), @@ -398,7 +395,7 @@ internal class WifiViewModelIconParameterizedTest(private val testCase: TestCase // because wifi isn't the default connection (b/272509965). TestCase( isDefault = false, - network = WifiNetworkModel.Active(NETWORK_ID, isValidated = true, level = 4), + network = WifiNetworkModel.Active(isValidated = true, level = 4), expected = null, ), ) @@ -406,4 +403,3 @@ internal class WifiViewModelIconParameterizedTest(private val testCase: TestCase } private val IMMEDIATE = Dispatchers.Main.immediate -private const val NETWORK_ID = 789 |