diff options
| author | 2022-08-31 23:36:14 +0000 | |
|---|---|---|
| committer | 2022-08-31 23:36:14 +0000 | |
| commit | ae685a115d7ee3f09b6681ac8969cc150db0386f (patch) | |
| tree | 98b327913751cfdcf8dd697f2b44b6963a5dca97 | |
| parent | c2ab75704c82fce573b6b0669e51db6fef4bbecb (diff) | |
| parent | b8713e871373309d94aaaa6ab4863de7a4981f04 (diff) | |
Merge "Fix NPEs in AuthContainerView" into tm-qpr-dev am: b8713e8713
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19784818
Change-Id: I01ad24865fe3187b58edd496396a11dbb8da20df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
| -rw-r--r-- | packages/SystemUI/src/com/android/systemui/biometrics/AuthContainerView.java | 42 |
1 files changed, 33 insertions, 9 deletions
diff --git a/packages/SystemUI/src/com/android/systemui/biometrics/AuthContainerView.java b/packages/SystemUI/src/com/android/systemui/biometrics/AuthContainerView.java index 86837366e0b7..436b756ea0cb 100644 --- a/packages/SystemUI/src/com/android/systemui/biometrics/AuthContainerView.java +++ b/packages/SystemUI/src/com/android/systemui/biometrics/AuthContainerView.java @@ -657,30 +657,50 @@ public class AuthContainerView extends LinearLayout @Override public void onAuthenticationSucceeded(@Modality int modality) { - mBiometricView.onAuthenticationSucceeded(modality); + if (mBiometricView != null) { + mBiometricView.onAuthenticationSucceeded(modality); + } else { + Log.e(TAG, "onAuthenticationSucceeded(): mBiometricView is null"); + } } @Override public void onAuthenticationFailed(@Modality int modality, String failureReason) { - mFailedModalities.add(modality); - mBiometricView.onAuthenticationFailed(modality, failureReason); + if (mBiometricView != null) { + mFailedModalities.add(modality); + mBiometricView.onAuthenticationFailed(modality, failureReason); + } else { + Log.e(TAG, "onAuthenticationFailed(): mBiometricView is null"); + } } @Override public void onHelp(@Modality int modality, String help) { - mBiometricView.onHelp(modality, help); + if (mBiometricView != null) { + mBiometricView.onHelp(modality, help); + } else { + Log.e(TAG, "onHelp(): mBiometricView is null"); + } } @Override public void onError(@Modality int modality, String error) { - mBiometricView.onError(modality, error); + if (mBiometricView != null) { + mBiometricView.onError(modality, error); + } else { + Log.e(TAG, "onError(): mBiometricView is null"); + } } @Override public void onPointerDown() { - if (mBiometricView.onPointerDown(mFailedModalities)) { - Log.d(TAG, "retrying failed modalities (pointer down)"); - mBiometricCallback.onAction(AuthBiometricView.Callback.ACTION_BUTTON_TRY_AGAIN); + if (mBiometricView != null) { + if (mBiometricView.onPointerDown(mFailedModalities)) { + Log.d(TAG, "retrying failed modalities (pointer down)"); + mBiometricCallback.onAction(AuthBiometricView.Callback.ACTION_BUTTON_TRY_AGAIN); + } + } else { + Log.e(TAG, "onPointerDown(): mBiometricView is null"); } } @@ -715,7 +735,11 @@ public class AuthContainerView extends LinearLayout @Override public void animateToCredentialUI() { - mBiometricView.startTransitionToCredentialUI(); + if (mBiometricView != null) { + mBiometricView.startTransitionToCredentialUI(); + } else { + Log.e(TAG, "animateToCredentialUI(): mBiometricView is null"); + } } void animateAway(@AuthDialogCallback.DismissedReason int reason) { |