summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Marco Nelissen <marcone@google.com> 2014-05-01 15:25:13 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> 2014-05-01 15:25:13 +0000
commitab3977d21161815c130bdedf21e2571382d208da (patch)
treebc4ddccb18548f5ce08eb3f3034dab7a45acdf19
parent1cec7f8539e6465ff80577169d7d07df3c2574b7 (diff)
parentc847a4835b2233d28f6479deeed0592d267ee7bd (diff)
Merge "MetadataRetriever: Check null pointer to avoid tombstone crash."
-rw-r--r--media/jni/android_media_MediaMetadataRetriever.cpp7
1 files changed, 7 insertions, 0 deletions
diff --git a/media/jni/android_media_MediaMetadataRetriever.cpp b/media/jni/android_media_MediaMetadataRetriever.cpp
index 6176f0f1f2b1..c2694f1fb9cb 100644
--- a/media/jni/android_media_MediaMetadataRetriever.cpp
+++ b/media/jni/android_media_MediaMetadataRetriever.cpp
@@ -262,6 +262,13 @@ static jobject android_media_MediaMetadataRetriever_getFrameAtTime(JNIEnv *env,
width,
height,
config);
+ if (jBitmap == NULL) {
+ if (env->ExceptionCheck()) {
+ env->ExceptionClear();
+ }
+ ALOGE("getFrameAtTime: create Bitmap failed!");
+ return NULL;
+ }
SkBitmap *bitmap =
(SkBitmap *) env->GetLongField(jBitmap, fields.nativeBitmap);