summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Treehugger Robot <android-test-infra-autosubmit@system.gserviceaccount.com> 2023-05-12 20:38:53 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2023-05-12 20:38:53 +0000
commitab109af8fae5cd542ea9d256c4fe993262b2b721 (patch)
treedd476e39a78be32da02af5ace49395156c24ef34
parent3090ffdceb35bc536dace715bf96699f3d97855e (diff)
parent08a8c4371af1a03115d748dd80df478e0afdd60c (diff)
Merge "Ensure only valid events are reported." into udc-dev
-rw-r--r--services/usage/java/com/android/server/usage/UsageStatsService.java10
1 files changed, 7 insertions, 3 deletions
diff --git a/services/usage/java/com/android/server/usage/UsageStatsService.java b/services/usage/java/com/android/server/usage/UsageStatsService.java
index a98429ad4902..72f2c1ddfc77 100644
--- a/services/usage/java/com/android/server/usage/UsageStatsService.java
+++ b/services/usage/java/com/android/server/usage/UsageStatsService.java
@@ -2539,10 +2539,14 @@ public class UsageStatsService extends SystemService implements
}
@Override
- public void reportChooserSelection(String packageName, int userId, String contentType,
- String[] annotations, String action) {
+ public void reportChooserSelection(@NonNull String packageName, int userId,
+ String contentType, String[] annotations, String action) {
if (packageName == null) {
- Slog.w(TAG, "Event report user selecting a null package");
+ throw new IllegalArgumentException("Package selection must not be null.");
+ }
+ // Verify if this package exists before reporting an event for it.
+ if (mPackageManagerInternal.getPackageUid(packageName, 0, userId) < 0) {
+ Slog.w(TAG, "Event report user selecting an invalid package");
return;
}