summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Sehee Park <sehee32.park@samsung.com> 2017-12-22 13:54:05 +0900
committer Sehee Park <sehee32.park@samsung.com> 2018-01-05 18:52:34 +0900
commita9139bc7c514441d258dedd70bde1646ff60d9d9 (patch)
treec50db2156c3f94c4b3b77f7172ab273d1c79b2a0
parent0d75603ea7da774d19bf5b015de42f374dad82ed (diff)
Add checking permission at the setDataSaverModeEnabled()
Add calling enforceCallingOrSelfPermission() to check for NETWORK_SETTINGS permission at the setDataSaverModeEnabled(). When an application calls for setDataSaverModeEnabled() passing a true parameter, the access to Internet from mobile data became unavailable. Test: Run test app to call setDataSaverModeEnabled() with a true parameter. Test: Check the access to Internet from mobile data is available. Change-Id: I14af89923e61d81355052704081edf121ef7d06d Signed-off-by: Sehee Park <sehee32.park@samsung.com>
-rw-r--r--services/core/java/com/android/server/NetworkManagementService.java3
1 files changed, 3 insertions, 0 deletions
diff --git a/services/core/java/com/android/server/NetworkManagementService.java b/services/core/java/com/android/server/NetworkManagementService.java
index 8a15ded2960f..9224b925aca8 100644
--- a/services/core/java/com/android/server/NetworkManagementService.java
+++ b/services/core/java/com/android/server/NetworkManagementService.java
@@ -18,6 +18,7 @@ package com.android.server;
import static android.Manifest.permission.CONNECTIVITY_INTERNAL;
import static android.Manifest.permission.DUMP;
+import static android.Manifest.permission.NETWORK_SETTINGS;
import static android.Manifest.permission.NETWORK_STACK;
import static android.Manifest.permission.SHUTDOWN;
import static android.net.ConnectivityManager.PRIVATE_DNS_DEFAULT_MODE;
@@ -1768,6 +1769,8 @@ public class NetworkManagementService extends INetworkManagementService.Stub
@Override
public boolean setDataSaverModeEnabled(boolean enable) {
+ mContext.enforceCallingOrSelfPermission(NETWORK_SETTINGS, TAG);
+
if (DBG) Log.d(TAG, "setDataSaverMode: " + enable);
synchronized (mQuotaLock) {
if (mDataSaverMode == enable) {