summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Camden Bickel <cambickel@google.com> 2024-09-30 18:47:01 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2024-09-30 18:47:01 +0000
commita823dd5482b7c839a8c941c81e46240dd0d37ea3 (patch)
treeec3bcba4ebe48471e5944ea2954864ce06571833
parentff11eeb034dcac7a710767770690f2d5098e06ff (diff)
parent5f6a21cdb957d933a3bcdc48e0b2c90339ab2af5 (diff)
Merge "audio: Update microphone string" into main
-rw-r--r--packages/SettingsLib/res/values/strings.xml4
-rw-r--r--packages/SettingsLib/src/com/android/settingslib/media/InputMediaDevice.java15
-rw-r--r--packages/SettingsLib/tests/robotests/src/com/android/settingslib/media/InputMediaDeviceTest.java2
3 files changed, 9 insertions, 12 deletions
diff --git a/packages/SettingsLib/res/values/strings.xml b/packages/SettingsLib/res/values/strings.xml
index efc98dbf7102..8b9ec389e3fd 100644
--- a/packages/SettingsLib/res/values/strings.xml
+++ b/packages/SettingsLib/res/values/strings.xml
@@ -1409,12 +1409,10 @@
<string name="media_transfer_this_device_name">This phone</string>
<!-- Name of the tablet device. [CHAR LIMIT=30] -->
<string name="media_transfer_this_device_name_tablet">This tablet</string>
- <!-- Name of the internal speaker. [CHAR LIMIT=30] -->
+ <!-- Name of the internal speaker and mic. [CHAR LIMIT=30] -->
<string name="media_transfer_this_device_name_desktop">This computer (internal)</string>
<!-- Name of the default media output of the TV. [CHAR LIMIT=30] -->
<string name="media_transfer_this_device_name_tv">@string/tv_media_transfer_default</string>
- <!-- Name of the internal mic. [CHAR LIMIT=30] -->
- <string name="media_transfer_internal_mic">Microphone (internal)</string>
<!-- Name of the dock device. [CHAR LIMIT=30] -->
<string name="media_transfer_dock_speaker_device_name">Dock speaker</string>
<!-- Default name of the external device. [CHAR LIMIT=30] -->
diff --git a/packages/SettingsLib/src/com/android/settingslib/media/InputMediaDevice.java b/packages/SettingsLib/src/com/android/settingslib/media/InputMediaDevice.java
index dae69e64934c..e44a13491758 100644
--- a/packages/SettingsLib/src/com/android/settingslib/media/InputMediaDevice.java
+++ b/packages/SettingsLib/src/com/android/settingslib/media/InputMediaDevice.java
@@ -98,14 +98,13 @@ public class InputMediaDevice extends MediaDevice {
@Override
public @NonNull String getName() {
- CharSequence name =
- switch (mAudioDeviceInfoType) {
- case TYPE_WIRED_HEADSET ->
- mContext.getString(R.string.media_transfer_wired_device_mic_name);
- case TYPE_USB_DEVICE, TYPE_USB_HEADSET, TYPE_USB_ACCESSORY ->
- mContext.getString(R.string.media_transfer_usb_device_mic_name);
- default -> mContext.getString(R.string.media_transfer_internal_mic);
- };
+ CharSequence name = switch (mAudioDeviceInfoType) {
+ case TYPE_WIRED_HEADSET -> mContext.getString(
+ R.string.media_transfer_wired_device_mic_name);
+ case TYPE_USB_DEVICE, TYPE_USB_HEADSET, TYPE_USB_ACCESSORY -> mContext.getString(
+ R.string.media_transfer_usb_device_mic_name);
+ default -> mContext.getString(R.string.media_transfer_this_device_name_desktop);
+ };
return name.toString();
}
diff --git a/packages/SettingsLib/tests/robotests/src/com/android/settingslib/media/InputMediaDeviceTest.java b/packages/SettingsLib/tests/robotests/src/com/android/settingslib/media/InputMediaDeviceTest.java
index 088d554326e7..2f0aa1cf0cb9 100644
--- a/packages/SettingsLib/tests/robotests/src/com/android/settingslib/media/InputMediaDeviceTest.java
+++ b/packages/SettingsLib/tests/robotests/src/com/android/settingslib/media/InputMediaDeviceTest.java
@@ -76,7 +76,7 @@ public class InputMediaDeviceTest {
IS_VOLUME_FIXED);
assertThat(builtinMediaDevice).isNotNull();
assertThat(builtinMediaDevice.getName())
- .isEqualTo(mContext.getString(R.string.media_transfer_internal_mic));
+ .isEqualTo(mContext.getString(R.string.media_transfer_this_device_name_desktop));
}
@Test