diff options
| author | 2025-01-17 10:46:32 -0800 | |
|---|---|---|
| committer | 2025-01-17 10:46:32 -0800 | |
| commit | a716a69a0a9734c91c19ff558528913ebeed751c (patch) | |
| tree | c2d521b88d206f69c25d79fda2097a9e6b717fec | |
| parent | ce9747fa441d189a7f775d942a59c2372ca3b564 (diff) | |
| parent | 1f8e5e71123249c396d03c8d495d350abb5a4fdb (diff) | |
Merge "Add aod_ui_rich_ongoing flag" into main
3 files changed, 71 insertions, 0 deletions
diff --git a/packages/SystemUI/aconfig/systemui.aconfig b/packages/SystemUI/aconfig/systemui.aconfig index 1a7ae724ec59..f753316cb67a 100644 --- a/packages/SystemUI/aconfig/systemui.aconfig +++ b/packages/SystemUI/aconfig/systemui.aconfig @@ -1940,3 +1940,10 @@ flag {      description: "Force promoted notifications to always be expanded"      bug: "380901479"  } + +flag { +    name: "aod_ui_rich_ongoing" +    namespace: "systemui" +    description: "Show a rich ongoing notification on the always-on display (depends on ui_rich_ongoing)" +    bug: "369151941" +}
\ No newline at end of file diff --git a/packages/SystemUI/src/com/android/systemui/flags/FlagDependencies.kt b/packages/SystemUI/src/com/android/systemui/flags/FlagDependencies.kt index 3911c196e967..e58807763597 100644 --- a/packages/SystemUI/src/com/android/systemui/flags/FlagDependencies.kt +++ b/packages/SystemUI/src/com/android/systemui/flags/FlagDependencies.kt @@ -31,6 +31,7 @@ import com.android.systemui.statusbar.notification.collection.SortBySectionTimeF  import com.android.systemui.statusbar.notification.emptyshade.shared.ModesEmptyShadeFix  import com.android.systemui.statusbar.notification.interruption.VisualInterruptionRefactor  import com.android.systemui.statusbar.notification.promoted.PromotedNotificationUi +import com.android.systemui.statusbar.notification.promoted.PromotedNotificationUiAod  import com.android.systemui.statusbar.notification.promoted.PromotedNotificationUiForceExpanded  import com.android.systemui.statusbar.notification.shared.NotificationAvalancheSuppression  import com.android.systemui.statusbar.notification.shared.NotificationMinimalism @@ -55,6 +56,9 @@ class FlagDependencies @Inject constructor(featureFlags: FeatureFlagsClassic, ha          ModesEmptyShadeFix.token dependsOn modesUi          PromotedNotificationUiForceExpanded.token dependsOn PromotedNotificationUi.token + +        PromotedNotificationUiAod.token dependsOn PromotedNotificationUi.token +          // SceneContainer dependencies          SceneContainerFlag.getFlagDependencies().forEach { (alpha, beta) -> alpha dependsOn beta } diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/notification/promoted/PromotedNotificationUiAod.kt b/packages/SystemUI/src/com/android/systemui/statusbar/notification/promoted/PromotedNotificationUiAod.kt new file mode 100644 index 000000000000..fa1f32cc367e --- /dev/null +++ b/packages/SystemUI/src/com/android/systemui/statusbar/notification/promoted/PromotedNotificationUiAod.kt @@ -0,0 +1,60 @@ +/* + * Copyright (C) 2025 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + *      http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.android.systemui.statusbar.notification.promoted + +import com.android.systemui.Flags +import com.android.systemui.flags.FlagToken +import com.android.systemui.flags.RefactorFlagUtils + +/** Helper for reading or using the promoted ongoing notifications AOD flag state. */ +object PromotedNotificationUiAod { +    /** The aconfig flag name */ +    const val FLAG_NAME = Flags.FLAG_AOD_UI_RICH_ONGOING + +    /** A token used for dependency declaration */ +    val token: FlagToken +        get() = FlagToken(FLAG_NAME, isEnabled) + +    /** Is the refactor enabled */ +    @JvmStatic +    inline val isEnabled +        get() = Flags.aodUiRichOngoing() + +    /** +     * Called to ensure code is only run when the flag is enabled. This protects users from the +     * unintended behaviors caused by accidentally running new logic, while also crashing on an eng +     * build to ensure that the refactor author catches issues in testing. +     */ +    @JvmStatic +    inline fun isUnexpectedlyInLegacyMode() = +        RefactorFlagUtils.isUnexpectedlyInLegacyMode(isEnabled, FLAG_NAME) + +    /** +     * Called to ensure code is only run when the flag is disabled. This will throw an exception if +     * the flag is not enabled to ensure that the refactor author catches issues in testing. +     * Caution!! Using this check incorrectly will cause crashes in nextfood builds! +     */ +    @JvmStatic +    inline fun assertInNewMode() = RefactorFlagUtils.assertInNewMode(isEnabled, FLAG_NAME) + +    /** +     * Called to ensure code is only run when the flag is disabled. This will throw an exception if +     * the flag is enabled to ensure that the refactor author catches issues in testing. +     */ +    @JvmStatic +    inline fun assertInLegacyMode() = RefactorFlagUtils.assertInLegacyMode(isEnabled, FLAG_NAME) +}  |