summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Bishoy Gendy <bishoygendy@google.com> 2023-01-20 10:14:53 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2023-01-20 10:14:53 +0000
commita6f366e392f8a3b3050918bcf6d99d60601a65cf (patch)
tree8514a16b1848d7112f4c09a21c8cc6a283dda833
parent7f22a4d59c5d6c8dca8c86fb92513bfa7e26f2a2 (diff)
Revert "Replace security exception with silent log in system ui."
This reverts commit 7f22a4d59c5d6c8dca8c86fb92513bfa7e26f2a2. Reason for revert: Exception is caught by Binder, so SystemUI won't crash. Change-Id: Ie82a61b9e297ea01447192557436e1a0b9505be5
-rw-r--r--packages/SystemUI/src/com/android/systemui/statusbar/CommandQueue.java4
1 files changed, 1 insertions, 3 deletions
diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/CommandQueue.java b/packages/SystemUI/src/com/android/systemui/statusbar/CommandQueue.java
index a66247412517..cd423dc13c9b 100644
--- a/packages/SystemUI/src/com/android/systemui/statusbar/CommandQueue.java
+++ b/packages/SystemUI/src/com/android/systemui/statusbar/CommandQueue.java
@@ -55,7 +55,6 @@ import android.os.ParcelFileDescriptor;
import android.os.Process;
import android.os.RemoteException;
import android.util.Pair;
-import android.util.Slog;
import android.util.SparseArray;
import android.view.InsetsState.InternalInsetsType;
import android.view.InsetsVisibilities;
@@ -1274,8 +1273,7 @@ public class CommandQueue extends IStatusBar.Stub implements
public void showMediaOutputSwitcher(String packageName) {
int callingUid = Binder.getCallingUid();
if (callingUid != 0 && callingUid != Process.SYSTEM_UID) {
- Slog.e(TAG, "Call only allowed from system server.");
- return;
+ throw new SecurityException("Call only allowed from system server.");
}
synchronized (mLock) {
SomeArgs args = SomeArgs.obtain();