summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Jeff Brown <jeffbrown@google.com> 2012-01-19 14:19:28 -0800
committer Android (Google) Code Review <android-gerrit@google.com> 2012-01-19 14:19:28 -0800
commita6885fa366116c9dbc8ecba2abe32bf516912e8f (patch)
treeff17853b01e929cc2aab4423e576b22bd6834cd8
parentea33f4bca5def40c75214dedb3ea63c70b2a462a (diff)
parent214f459b2c35ac0d95ad8ae9e2a68b94807ceba0 (diff)
Merge "Remove no longer needed EventHub usleep() optimization."
-rw-r--r--services/input/EventHub.cpp15
-rw-r--r--services/input/EventHub.h3
2 files changed, 0 insertions, 18 deletions
diff --git a/services/input/EventHub.cpp b/services/input/EventHub.cpp
index 990892384181..1f8cf630bc88 100644
--- a/services/input/EventHub.cpp
+++ b/services/input/EventHub.cpp
@@ -156,8 +156,6 @@ EventHub::EventHub(void) :
mPendingEventCount(0), mPendingEventIndex(0), mPendingINotify(false) {
acquire_wake_lock(PARTIAL_WAKE_LOCK, WAKE_LOCK_ID);
- mNumCpus = sysconf(_SC_NPROCESSORS_ONLN);
-
mEpollFd = epoll_create(EPOLL_SIZE_HINT);
LOG_ALWAYS_FATAL_IF(mEpollFd < 0, "Could not create epoll instance. errno=%d", errno);
@@ -775,19 +773,6 @@ size_t EventHub::getEvents(int timeoutMillis, RawEvent* buffer, size_t bufferSiz
} else {
// Some events occurred.
mPendingEventCount = size_t(pollResult);
-
- // On an SMP system, it is possible for the framework to read input events
- // faster than the kernel input device driver can produce a complete packet.
- // Because poll() wakes up as soon as the first input event becomes available,
- // the framework will often end up reading one event at a time until the
- // packet is complete. Instead of one call to read() returning 71 events,
- // it could take 71 calls to read() each returning 1 event.
- //
- // Sleep for a short period of time after waking up from the poll() to give
- // the kernel time to finish writing the entire packet of input events.
- if (mNumCpus > 1) {
- usleep(250);
- }
}
}
diff --git a/services/input/EventHub.h b/services/input/EventHub.h
index 9d8252ed4763..8a2afd32fcf0 100644
--- a/services/input/EventHub.h
+++ b/services/input/EventHub.h
@@ -367,9 +367,6 @@ private:
size_t mPendingEventCount;
size_t mPendingEventIndex;
bool mPendingINotify;
-
- // Set to the number of CPUs.
- int32_t mNumCpus;
};
}; // namespace android